Skip to content

🎨 Add flagEvaluationEndpointBuilder to TransportConfiguration interface. #4025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lisaah merged 1 commit into from
Dec 11, 2025
Merged

🎨 Add flagEvaluationEndpointBuilder to TransportConfiguration interface. #4025

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/domain/configuration/transportConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export interface TransportConfiguration {
sessionReplayEndpointBuilder: EndpointBuilder
profilingEndpointBuilder: EndpointBuilder
exposuresEndpointBuilder: EndpointBuilder
flagEvaluationEndpointBuilder: EndpointBuilder
Copy link
Collaborator

@bcaudan bcaudan Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought: ‏I wonder if it is something that should live in core as exposures and flagEvaluation are not even used by the browser-sdk.
cc @BenoitZugmeyer

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely! I even gave it a try, and it's almost working! Not sure exactly why I stopped there, I was focusing on other tasks. In the meantime I accepted @lisaah PR to avoid blocking her, as I think this is benign and can be improved later.

cc @thomas-lebeau as you were also talking about this.

datacenter?: string | undefined
replica?: ReplicaConfiguration
site: Site
Expand Down