✨[PANA-5288] Update rum-events-format to pull in BrowserChangeRecord#4035
Merged
sethfowler-datadog merged 4 commits intomainfrom Dec 22, 2025
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: a71b007 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
mormubis
reviewed
Dec 16, 2025
| * View properties | ||
| */ | ||
| readonly view: { | ||
| readonly view?: { |
Contributor
There was a problem hiding this comment.
Is this right? Is now the view optional?
Contributor
Author
There was a problem hiding this comment.
It's intended -- it comes from Téo's PR here. I don't have a full understanding of the context, though. It's not part of my changes; it just came along because Téo's changes hadn't been pulled into this repo yet.
mormubis
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As part of the new session replay data format arc of work, we need to pull in the new record type definitions that were recently merged into
rum-events-format.Changes
This PR updates the
rum-events-formatsubmodule. I've runyarn json-schemas:syncto automatically synchronize the type definitions in this repo. (It looks like some other changes fromrum-events-formathad not been pulled in yet, so this makes some additional changes besides addingBrowserChangeRecord.) I've also manually defined aChangeTypeenumeration for the differentChangevariants, just as we've already done for other similar types likeNodeTypeandIncrementalSource.I had to tweak
scripts/check-schemas.tsto runyarn format -wafter generating code from the JSON schemas, because Prettier disagrees with the code generator about how multiline array literals should be formatted.There are no functional changes in this PR.
Checklist