Skip to content

✨[PANA-5288] Update rum-events-format to pull in BrowserChangeRecord#4035

Merged
sethfowler-datadog merged 4 commits intomainfrom
seth.fowler/PANA-5228-update-rum-events-format-for-new-session-replay-record-type
Dec 22, 2025
Merged

✨[PANA-5288] Update rum-events-format to pull in BrowserChangeRecord#4035
sethfowler-datadog merged 4 commits intomainfrom
seth.fowler/PANA-5228-update-rum-events-format-for-new-session-replay-record-type

Conversation

@sethfowler-datadog
Copy link
Contributor

@sethfowler-datadog sethfowler-datadog commented Dec 16, 2025

Motivation

As part of the new session replay data format arc of work, we need to pull in the new record type definitions that were recently merged into rum-events-format.

Changes

This PR updates the rum-events-format submodule. I've run yarn json-schemas:sync to automatically synchronize the type definitions in this repo. (It looks like some other changes from rum-events-format had not been pulled in yet, so this makes some additional changes besides adding BrowserChangeRecord.) I've also manually defined a ChangeType enumeration for the different Change variants, just as we've already done for other similar types like NodeType and IncrementalSource.

I had to tweak scripts/check-schemas.ts to run yarn format -w after generating code from the JSON schemas, because Prettier disagrees with the code generator about how multiline array literals should be formatted.

There are no functional changes in this PR.

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@sethfowler-datadog sethfowler-datadog requested a review from a team as a code owner December 16, 2025 12:08
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 16, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.34 KiB 164.34 KiB 0 B 0.00%
Rum Profiler 4.32 KiB 4.32 KiB 0 B 0.00%
Rum Recorder 20.02 KiB 20.02 KiB 0 B 0.00%
Logs 56.14 KiB 56.14 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.62 KiB 121.62 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base CPU Time (ms) Local CPU Time (ms) 𝚫%
RUM - add global context 0.0051 0.0041 -19.61%
RUM - add action 0.0151 0.0114 -24.50%
RUM - add error 0.0149 0.0115 -22.82%
RUM - add timing 0.0037 0.0027 -27.03%
RUM - start view 0.005 0.0031 -38.00%
RUM - start/stop session replay recording 0.0008 0.0007 -12.50%
Logs - log message 0.0163 0.0124 -23.93%
🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.67 KiB 25.26 KiB -419 B
RUM - add action 48.08 KiB 46.78 KiB -1.30 KiB
RUM - add timing 24.94 KiB 24.55 KiB -401 B
RUM - add error 53.95 KiB 53.15 KiB -814 B
RUM - start/stop session replay recording 24.68 KiB 23.84 KiB -865 B
RUM - start view 422.07 KiB 425.12 KiB +3.05 KiB
Logs - log message 43.39 KiB 43.52 KiB +135 B

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 16, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 77.22% (-15.46%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a71b007 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

* View properties
*/
readonly view: {
readonly view?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? Is now the view optional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's intended -- it comes from Téo's PR here. I don't have a full understanding of the context, though. It's not part of my changes; it just came along because Téo's changes hadn't been pulled into this repo yet.

@sethfowler-datadog sethfowler-datadog merged commit 8749916 into main Dec 22, 2025
20 checks passed
@sethfowler-datadog sethfowler-datadog deleted the seth.fowler/PANA-5228-update-rum-events-format-for-new-session-replay-record-type branch December 22, 2025 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants