Skip to content

✨[PANA-5288] Update rum-events-format to pull in BrowserChangeRecord #4035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethfowler-datadog merged 4 commits into from
Dec 22, 2025
Merged

✨[PANA-5288] Update rum-events-format to pull in BrowserChangeRecord #4035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc7460d
✨[PANA-5288] Update rum-events-format to pull in BrowserChangeRecord
sethfowler-datadog Dec 16, 2025
e22fc06
Format code generated from JSON schemas
sethfowler-datadog Dec 16, 2025
97d5cd3
Add Change to RecordType enum
sethfowler-datadog Dec 16, 2025
a71b007
Update to include new Change types from PANA-5245
sethfowler-datadog Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/core/src/domain/telemetry/telemetryEvent.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,18 @@ export interface CommonTelemetryProperties {
* Model of the device
*/
model?: string
/**
* Number of device processors
*/
readonly processor_count?: number
/**
* Total RAM in megabytes
*/
readonly total_ram?: number
/**
* Whether the device is considered a low RAM device (Android)
*/
readonly is_low_ram_device?: boolean
[k: string]: unknown
}
/**
Expand Down
39 changes: 18 additions & 21 deletions packages/rum-core/src/rumEvent.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export type RumActionEvent = CommonProperties &
/**
* View properties
*/
readonly view: {
readonly view?: {
/**
* Is the action starting in the foreground (focus in browser)
*/
Expand Down Expand Up @@ -175,9 +175,6 @@ export type RumTransitionEvent = CommonProperties & {
* RUM event type
*/
readonly type: 'transition'
view: {
[k: string]: unknown
}
/**
* Stream properties
*/
Expand Down Expand Up @@ -482,7 +479,7 @@ export type RumErrorEvent = CommonProperties &
/**
* View properties
*/
readonly view: {
readonly view?: {
Copy link
Contributor

@mormubis mormubis Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? Is now the view optional?

Copy link
Contributor Author

@sethfowler-datadog sethfowler-datadog Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's intended -- it comes from Téo's PR here. I don't have a full understanding of the context, though. It's not part of my changes; it just came along because Téo's changes hadn't been pulled into this repo yet.

/**
* Is the error starting in the foreground (focus in browser)
*/
Expand All @@ -507,9 +504,6 @@ export type RumLongTaskEvent = CommonProperties &
* RUM event type
*/
readonly type: 'long_task'
view: {
[k: string]: unknown
}
/**
* Long Task properties
*/
Expand Down Expand Up @@ -634,9 +628,6 @@ export type RumResourceEvent = CommonProperties &
* RUM event type
*/
readonly type: 'resource'
view: {
[k: string]: unknown
}
/**
* Resource properties
*/
Expand Down Expand Up @@ -841,7 +832,7 @@ export type RumResourceEvent = CommonProperties &
/**
* Type of the GraphQL operation
*/
readonly operationType: 'query' | 'mutation' | 'subscription'
readonly operationType?: 'query' | 'mutation' | 'subscription'
/**
* Name of the GraphQL operation
*/
Expand Down Expand Up @@ -1329,13 +1320,10 @@ export type RumVitalEvent = RumVitalDurationEvent | RumVitalOperationStepEvent
* Schema for a duration vital event.
*/
export type RumVitalDurationEvent = RumVitalEventCommonProperties & {
view: {
[k: string]: unknown
}
/**
* Vital properties
*/
readonly vital: {
readonly vital?: {
/**
* Type of the vital.
*/
Expand Down Expand Up @@ -1381,13 +1369,10 @@ export type RumVitalEventCommonProperties = CommonProperties &
* Schema for a vital operation step event.
*/
export type RumVitalOperationStepEvent = RumVitalEventCommonProperties & {
view: {
[k: string]: unknown
}
/**
* Vital properties
*/
readonly vital: {
readonly vital?: {
/**
* Type of the vital.
*/
Expand Down Expand Up @@ -1484,7 +1469,7 @@ export interface CommonProperties {
/**
* View properties
*/
readonly view?: {
readonly view: {
/**
* UUID of the view
*/
Expand Down Expand Up @@ -1699,6 +1684,18 @@ export interface CommonProperties {
* Current screen brightness level (0.0 to 1.0).
*/
readonly brightness_level?: number
/**
* Number of device processors
*/
readonly processor_count?: number
/**
* Total RAM in megabytes
*/
readonly total_ram?: number
/**
* Whether the device is considered a low RAM device (Android)
*/
readonly is_low_ram_device?: boolean
[k: string]: unknown
}
/**
Expand Down
Loading