Inline dd-procmgrd Bazel build into omnibus packaging#46834
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom Feb 24, 2026
Merged
Inline dd-procmgrd Bazel build into omnibus packaging#46834gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
dd-procmgrd Bazel build into omnibus packaging#46834gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intomainfrom
Conversation
rdesgroppes
added
changelog/no-changelog
qa/no-code-change
Contributor
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 3 | 12 | 0 | 0 |
ℹ️ Diff available in the job log.
rdesgroppes
force-pushed
the
regis.desgroppes/inline-dd-procmgrd
branch
from
158d6f4 to
851c005
Compare
Contributor
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
30 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: dc3c3c7 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | -4.75 | [-7.74, -1.76] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_metrics_logs | memory utilization | +0.43 | [+0.21, +0.64] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.39 | [+0.16, +0.62] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.22 | [+0.12, +0.31] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.20 | [+0.15, +0.26] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.18 | [+0.11, +0.26] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.15 | [+0.11, +0.19] | 1 | Logs bounds checks dashboard |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.14 | [+0.09, +0.19] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.07 | [-0.09, +0.23] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.04 | [-0.38, +0.46] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.04 | [+0.00, +0.07] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.08, +0.11] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.11, +0.14] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.01 | [-0.48, +0.49] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.12, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.05, +0.04] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.01 | [-0.40, +0.37] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.11 | [-0.30, +0.08] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | -0.26 | [-0.41, -0.10] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.28 | [-0.33, -0.23] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | -0.85 | [-1.06, -0.64] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.02 | [-1.08, -0.95] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -3.29 | [-4.79, -1.79] | 1 | Logs bounds checks dashboard |
| ➖ | docker_containers_cpu | % cpu utilization | -4.75 | [-7.74, -1.76] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | lost_bytes | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
### What does this PR do?
Remove the dedicated `binary_build` stage jobs (`build_dd-procmgrd-{x64,arm64}`) that built the `dd-procmgrd` Rust binary, archived it as a GitLab artifact, and passed it to the packaging stage via `--dd-procmgrd-bin=...` (`DD_PROCMGRD_BIN=...` from omnibus perspective).
Instead, the build is triggered directly from within the omnibus software definition via `bazel run //pkg/procmgr/rust:install` when `--with-dd-procmgrd` is passed (`WITH_DD_PROCMGRD=true` from omnibus perspective).
### Motivation
Bazel in CI operates with two caching layers: a minimal GitLab cache for bootstrapping pre-fetched external repositories (read-only in PR branches, read/write on `main`), and an always-on remote cache, so any target built with identical inputs is fetched rather than rebuilt.
An orthogonal GitLab artifact carrying the same binary is therefore redundant: it imposes a fixed pack/upload/download/unpack overhead on every run, including those that would otherwise be remote cache hits, and introduces an inter-stage dependency that serializes the pipeline.
Running the build at the point of consumption lets Bazel's DAG do the right thing: unchanged sources yield a near-instant cache hit; if sources differ, the cost is paid once and cached for all subsequent runs.
### Describe how you validated your changes
CI.
rdesgroppes
force-pushed
the
regis.desgroppes/inline-dd-procmgrd
branch
from
851c005 to
f0b6151
Compare
Contributor
jose-manuel-almaza
left a comment
jose-manuel-almaza
left a comment
There was a problem hiding this comment.
Are we doing the same for sd_agent for example?
Contributor
Author
Yes, @jose-manuel-almaza, here's the corresponding PR: |
chouetz
approved these changes
Feb 24, 2026
jose-manuel-almaza
approved these changes
Feb 24, 2026
gh-worker-dd-mergequeue-cf854d
bot
deleted the
regis.desgroppes/inline-dd-procmgrd
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the dedicated
binary_buildstage jobs (build_dd-procmgrd-{x64,arm64}) that built thedd-procmgrdRust binary, archived it as a GitLab artifact, and passed it to the packaging stage via--dd-procmgrd-bin=...(DD_PROCMGRD_BIN=...from omnibus perspective).Instead, the build is triggered directly from within the omnibus software definition via
bazel run //pkg/procmgr/rust:installwhen--with-dd-procmgrdis passed (WITH_DD_PROCMGRD=truefrom omnibus perspective).Motivation
Bazel in CI operates with two caching layers: a minimal GitLab cache for bootstrapping pre-fetched external repositories (read-only in PR branches, read/write on
main), and an always-on remote cache, so any target built with identical inputs is fetched rather than rebuilt.An orthogonal GitLab artifact carrying the same binary is therefore redundant: it imposes a fixed pack/upload/download/unpack overhead on every run, including those that would otherwise be remote cache hits, and introduces an inter-stage dependency that serializes the pipeline.
Running the build at the point of consumption lets Bazel's DAG do the right thing: unchanged sources yield a near-instant cache hit; if sources differ, the cost is paid once and cached for all subsequent runs.
Describe how you validated your changes
CI.