[crashtracker] Add ping mechanism for .NET crashtracker #8028
+164
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gleocadie
force-pushed
the
gleocadie/crashtracker-use-ping-mechanism
branch
from
b706474 to
bab5835
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing This PR (8028) and master. ✅ No regressions detected - check the details below Full Metrics ComparisonFakeDbCommand
HttpMessageHandler
Comparison explanationExecution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). Duration chartsFakeDbCommand (.NET Framework 4.8)gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (69ms) : 67, 70
master - mean (68ms) : 67, 70
section Bailout
This PR (8028) - mean (72ms) : 71, 73
master - mean (72ms) : 71, 73
section CallTarget+Inlining+NGEN
This PR (8028) - mean (1,011ms) : 974, 1049
master - mean (1,008ms) : 966, 1050
FakeDbCommand (.NET Core 3.1)gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (106ms) : 104, 109
master - mean (106ms) : 104, 108
section Bailout
This PR (8028) - mean (107ms) : 106, 108
master - mean (107ms) : 106, 108
section CallTarget+Inlining+NGEN
This PR (8028) - mean (733ms) : 670, 797
master - mean (742ms) : 678, 806
FakeDbCommand (.NET 6)gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (94ms) : 92, 96
master - mean (94ms) : 92, 96
section Bailout
This PR (8028) - mean (95ms) : 94, 96
master - mean (94ms) : 93, 95
section CallTarget+Inlining+NGEN
This PR (8028) - mean (712ms) : 680, 745
master - mean (708ms) : 658, 759
FakeDbCommand (.NET 8)gantt
title Execution time (ms) FakeDbCommand (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (92ms) : 89, 94
master - mean (92ms) : 91, 94
section Bailout
This PR (8028) - mean (93ms) : 92, 94
master - mean (93ms) : 92, 95
section CallTarget+Inlining+NGEN
This PR (8028) - mean (631ms) : 616, 646
master - mean (630ms) : 615, 646
HttpMessageHandler (.NET Framework 4.8)gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (194ms) : 190, 197
master - mean (195ms) : 189, 202
section Bailout
This PR (8028) - mean (197ms) : 193, 201
master - mean (199ms) : 194, 203
section CallTarget+Inlining+NGEN
This PR (8028) - mean (1,121ms) : 1067, 1174
master - mean (1,134ms) : 1076, 1191
HttpMessageHandler (.NET Core 3.1)gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (277ms) : 270, 283
master - mean (278ms) : 273, 284
section Bailout
This PR (8028) - mean (277ms) : 273, 280
master - mean (285ms) : 272, 297
section CallTarget+Inlining+NGEN
This PR (8028) - mean (920ms) : 869, 971
master - mean (936ms) : 889, 982
HttpMessageHandler (.NET 6)gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (270ms) : 266, 274
master - mean (273ms) : 265, 281
section Bailout
This PR (8028) - mean (270ms) : 265, 276
master - mean (275ms) : 268, 282
section CallTarget+Inlining+NGEN
This PR (8028) - mean (926ms) : 880, 972
master - mean (928ms) : 886, 970
HttpMessageHandler (.NET 8)gantt
title Execution time (ms) HttpMessageHandler (.NET 8)
dateFormat x
axisFormat %Q
todayMarker off
section Baseline
This PR (8028) - mean (270ms) : 266, 275
master - mean (271ms) : 266, 276
section Bailout
This PR (8028) - mean (271ms) : 266, 276
master - mean (271ms) : 267, 275
section CallTarget+Inlining+NGEN
This PR (8028) - mean (823ms) : 801, 845
master - mean (828ms) : 802, 854
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
BenchmarksBenchmark execution time: 2026-01-07 23:35:25 Comparing candidate commit 61b2c62 in PR branch Found 4 performance improvements and 6 performance regressions! Performance is the same for 164 metrics, 12 unstable metrics. scenario:Benchmarks.Trace.ActivityBenchmark.StartStopWithChild netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0
scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1
scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack netcoreapp3.1
scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net472
scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool net472
scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1
|
gleocadie
force-pushed
the
gleocadie/crashtracker-use-ping-mechanism
branch
5 times, most recently
from
bd6ecd9 to
50254c4
Compare
gleocadie
force-pushed
the
gleocadie/crashtracker-use-ping-mechanism
branch
2 times, most recently
from
6c1a917 to
1239a8a
Compare
gleocadie
force-pushed
the
gleocadie/crashtracker-use-ping-mechanism
branch
2 times, most recently
from
6c0c046 to
7c531f5
Compare
gleocadie
force-pushed
the
gleocadie/crashtracker-use-ping-mechanism
branch
from
7c531f5 to
61b2c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Implementation details
Test coverage
Other details