-
Notifications
You must be signed in to change notification settings - Fork 323
Fix test name uniqueness #8255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix test name uniqueness #8255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060777
Total [baseline] (8.64 s) : 0, 8639968
Agent [candidate] (1.064 s) : 0, 1063726
Total [candidate] (8.666 s) : 0, 8665979
section iast
Agent [baseline] (1.199 s) : 0, 1198855
Total [baseline] (9.29 s) : 0, 9290345
Agent [candidate] (1.186 s) : 0, 1186311
Total [candidate] (9.235 s) : 0, 9235220
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.204 s) : 0, 1203594
Total [baseline] (9.234 s) : 0, 9234368
Agent [candidate] (1.184 s) : 0, 1183942
Total [candidate] (9.189 s) : 0, 9188917
section iast_TELEMETRY_OFF
Agent [baseline] (1.18 s) : 0, 1180136
Total [baseline] (9.206 s) : 0, 9205544
Agent [candidate] (1.199 s) : 0, 1198770
Total [candidate] (9.21 s) : 0, 9209902
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.178 ms) : 0, 718178
BytebuddyAgent [candidate] (719.313 ms) : 0, 719313
GlobalTracer [baseline] (256.634 ms) : 0, 256634
GlobalTracer [candidate] (257.855 ms) : 0, 257855
AppSec [baseline] (56.501 ms) : 0, 56501
AppSec [candidate] (56.787 ms) : 0, 56787
Remote Config [baseline] (758.086 µs) : 0, 758
Remote Config [candidate] (748.534 µs) : 0, 749
Telemetry [baseline] (13.554 ms) : 0, 13554
Telemetry [candidate] (13.869 ms) : 0, 13869
section iast
BytebuddyAgent [baseline] (844.02 ms) : 0, 844020
BytebuddyAgent [candidate] (834.231 ms) : 0, 834231
GlobalTracer [baseline] (249.476 ms) : 0, 249476
GlobalTracer [candidate] (247.735 ms) : 0, 247735
AppSec [baseline] (58.736 ms) : 0, 58736
AppSec [candidate] (58.428 ms) : 0, 58428
Remote Config [baseline] (691.29 µs) : 0, 691
Remote Config [candidate] (670.241 µs) : 0, 670
Telemetry [baseline] (8.94 ms) : 0, 8940
Telemetry [candidate] (8.78 ms) : 0, 8780
IAST [baseline] (21.835 ms) : 0, 21835
IAST [candidate] (21.369 ms) : 0, 21369
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (848.815 ms) : 0, 848815
BytebuddyAgent [candidate] (833.181 ms) : 0, 833181
GlobalTracer [baseline] (249.056 ms) : 0, 249056
GlobalTracer [candidate] (246.835 ms) : 0, 246835
AppSec [baseline] (58.842 ms) : 0, 58842
AppSec [candidate] (58.113 ms) : 0, 58113
Remote Config [baseline] (707.43 µs) : 0, 707
Remote Config [candidate] (684.585 µs) : 0, 685
Telemetry [baseline] (8.897 ms) : 0, 8897
Telemetry [candidate] (8.758 ms) : 0, 8758
IAST [baseline] (21.817 ms) : 0, 21817
IAST [candidate] (21.339 ms) : 0, 21339
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (830.694 ms) : 0, 830694
BytebuddyAgent [candidate] (842.97 ms) : 0, 842970
GlobalTracer [baseline] (246.274 ms) : 0, 246274
GlobalTracer [candidate] (250.605 ms) : 0, 250605
AppSec [baseline] (57.821 ms) : 0, 57821
AppSec [candidate] (58.913 ms) : 0, 58913
Remote Config [baseline] (664.957 µs) : 0, 665
Remote Config [candidate] (685.399 µs) : 0, 685
Telemetry [baseline] (8.658 ms) : 0, 8658
Telemetry [candidate] (8.927 ms) : 0, 8927
IAST [baseline] (20.932 ms) : 0, 20932
IAST [candidate] (21.398 ms) : 0, 21398
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055424
Total [baseline] (10.48 s) : 0, 10480074
Agent [candidate] (1.059 s) : 0, 1058798
Total [candidate] (10.484 s) : 0, 10483643
section appsec
Agent [baseline] (1.192 s) : 0, 1192484
Total [baseline] (10.706 s) : 0, 10706180
Agent [candidate] (1.19 s) : 0, 1190467
Total [candidate] (10.78 s) : 0, 10779632
section iast
Agent [baseline] (1.191 s) : 0, 1190992
Total [baseline] (10.989 s) : 0, 10989346
Agent [candidate] (1.189 s) : 0, 1189389
Total [candidate] (10.996 s) : 0, 10995799
section profiling
Agent [baseline] (1.254 s) : 0, 1254125
Total [baseline] (10.827 s) : 0, 10826625
Agent [candidate] (1.256 s) : 0, 1256332
Total [candidate] (10.861 s) : 0, 10860869
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.386 ms) : 0, 714386
BytebuddyAgent [candidate] (716.609 ms) : 0, 716609
GlobalTracer [baseline] (255.35 ms) : 0, 255350
GlobalTracer [candidate] (256.248 ms) : 0, 256248
AppSec [baseline] (55.46 ms) : 0, 55460
AppSec [candidate] (56.401 ms) : 0, 56401
Remote Config [baseline] (743.093 µs) : 0, 743
Remote Config [candidate] (743.343 µs) : 0, 743
Telemetry [baseline] (14.451 ms) : 0, 14451
Telemetry [candidate] (13.745 ms) : 0, 13745
section appsec
BytebuddyAgent [baseline] (733.947 ms) : 0, 733947
BytebuddyAgent [candidate] (731.606 ms) : 0, 731606
GlobalTracer [baseline] (253.932 ms) : 0, 253932
GlobalTracer [candidate] (253.53 ms) : 0, 253530
AppSec [baseline] (170.778 ms) : 0, 170778
AppSec [candidate] (171.733 ms) : 0, 171733
Remote Config [baseline] (670.577 µs) : 0, 671
Remote Config [candidate] (662.705 µs) : 0, 663
Telemetry [baseline] (8.163 ms) : 0, 8163
Telemetry [candidate] (8.231 ms) : 0, 8231
IAST [baseline] (19.944 ms) : 0, 19944
IAST [candidate] (19.338 ms) : 0, 19338
section iast
BytebuddyAgent [baseline] (838.324 ms) : 0, 838324
BytebuddyAgent [candidate] (836.214 ms) : 0, 836214
GlobalTracer [baseline] (247.52 ms) : 0, 247520
GlobalTracer [candidate] (247.94 ms) : 0, 247940
AppSec [baseline] (58.56 ms) : 0, 58560
AppSec [candidate] (58.595 ms) : 0, 58595
Remote Config [baseline] (668.036 µs) : 0, 668
Remote Config [candidate] (675.802 µs) : 0, 676
Telemetry [baseline] (8.887 ms) : 0, 8887
Telemetry [candidate] (8.899 ms) : 0, 8899
IAST [baseline] (21.772 ms) : 0, 21772
IAST [candidate] (21.958 ms) : 0, 21958
section profiling
BytebuddyAgent [baseline] (702.998 ms) : 0, 702998
BytebuddyAgent [candidate] (704.309 ms) : 0, 704309
GlobalTracer [baseline] (349.577 ms) : 0, 349577
GlobalTracer [candidate] (350.836 ms) : 0, 350836
AppSec [baseline] (54.706 ms) : 0, 54706
AppSec [candidate] (54.283 ms) : 0, 54283
Remote Config [baseline] (717.029 µs) : 0, 717
Remote Config [candidate] (703.308 µs) : 0, 703
Telemetry [baseline] (8.825 ms) : 0, 8825
Telemetry [candidate] (8.761 ms) : 0, 8761
ProfilingAgent [baseline] (95.176 ms) : 0, 95176
ProfilingAgent [candidate] (95.398 ms) : 0, 95398
Profiling [baseline] (95.2 ms) : 0, 95200
Profiling [candidate] (95.422 ms) : 0, 95422
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section baseline
no_agent (372.371 µs) : 353, 392
. : milestone, 372,
iast (508.711 µs) : 487, 531
. : milestone, 509,
iast_FULL (745.772 µs) : 724, 768
. : milestone, 746,
iast_GLOBAL (549.794 µs) : 528, 571
. : milestone, 550,
iast_HARDCODED_SECRET_DISABLED (507.845 µs) : 486, 529
. : milestone, 508,
iast_INACTIVE (455.466 µs) : 434, 477
. : milestone, 455,
iast_TELEMETRY_OFF (495.184 µs) : 474, 517
. : milestone, 495,
tracing (449.069 µs) : 429, 470
. : milestone, 449,
section candidate
no_agent (379.265 µs) : 360, 399
. : milestone, 379,
iast (510.249 µs) : 488, 532
. : milestone, 510,
iast_FULL (746.578 µs) : 725, 768
. : milestone, 747,
iast_GLOBAL (565.579 µs) : 542, 589
. : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (513.819 µs) : 492, 536
. : milestone, 514,
iast_INACTIVE (455.542 µs) : 435, 477
. : milestone, 456,
iast_TELEMETRY_OFF (495.893 µs) : 474, 518
. : milestone, 496,
tracing (454.251 µs) : 433, 476
. : milestone, 454,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section baseline
no_agent (1.374 ms) : 1354, 1394
. : milestone, 1374,
appsec (1.746 ms) : 1722, 1770
. : milestone, 1746,
appsec_no_iast (1.757 ms) : 1734, 1781
. : milestone, 1757,
iast (1.516 ms) : 1491, 1540
. : milestone, 1516,
profiling (1.514 ms) : 1490, 1538
. : milestone, 1514,
tracing (1.492 ms) : 1467, 1516
. : milestone, 1492,
section candidate
no_agent (1.355 ms) : 1335, 1375
. : milestone, 1355,
appsec (1.771 ms) : 1748, 1795
. : milestone, 1771,
appsec_no_iast (1.739 ms) : 1714, 1763
. : milestone, 1739,
iast (1.513 ms) : 1488, 1537
. : milestone, 1513,
profiling (1.506 ms) : 1483, 1529
. : milestone, 1506,
tracing (1.486 ms) : 1461, 1511
. : milestone, 1486,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section baseline
no_agent (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
appsec (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
iast (18.615 s) : 18615000, 18615000
. : milestone, 18615000,
iast_GLOBAL (18.117 s) : 18117000, 18117000
. : milestone, 18117000,
profiling (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
tracing (15.082 s) : 15082000, 15082000
. : milestone, 15082000,
section candidate
no_agent (15.657 s) : 15657000, 15657000
. : milestone, 15657000,
appsec (15.022 s) : 15022000, 15022000
. : milestone, 15022000,
iast (18.188 s) : 18188000, 18188000
. : milestone, 18188000,
iast_GLOBAL (18.069 s) : 18069000, 18069000
. : milestone, 18069000,
profiling (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
tracing (15.192 s) : 15192000, 15192000
. : milestone, 15192000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~05bf0d1e6f, baseline=1.46.0-SNAPSHOT~441582ae47
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
. : milestone, 1469,
appsec (2.365 ms) : 2323, 2408
. : milestone, 2365,
iast (2.097 ms) : 2043, 2152
. : milestone, 2097,
iast_GLOBAL (2.15 ms) : 2095, 2204
. : milestone, 2150,
profiling (1.989 ms) : 1944, 2033
. : milestone, 1989,
tracing (1.95 ms) : 1908, 1992
. : milestone, 1950,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.367 ms) : 2325, 2410
. : milestone, 2367,
iast (2.118 ms) : 2064, 2173
. : milestone, 2118,
iast_GLOBAL (2.154 ms) : 2100, 2209
. : milestone, 2154,
profiling (1.971 ms) : 1928, 2015
. : milestone, 1971,
tracing (1.949 ms) : 1907, 1991
. : milestone, 1949,
|
85c6920 to
c4225cc
Compare
c4225cc to
05bf0d1
Compare
smola
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR fixes test name uniqueness.
Motivation
This will help with CI monitoring to keep track of test execution.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]