Skip to content

Fix test name uniqueness #8255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PerfectSlayer merged 1 commit into from
Jan 21, 2025
Merged

Fix test name uniqueness #8255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal-api/src/test/groovy/datadog/trace/api/telemetry/MetricCollectorTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import spock.lang.Specification

class MetricCollectorTest extends Specification {

void 'test metric equality'() {
void 'test metric equality #iterationIndex'() {
when:
final sameMetric = first == second

Expand All @@ -23,6 +23,14 @@ class MetricCollectorTest extends Specification {
counter(tags: ['a:b', 'c:d'], value: 2) | counter(tags: ['a:b', 'c:d'], value: 6) | true
}

void 'test metric toString'() {
expect:
metric.toString() != null

where:
metric << [counter(value: 2), counter(namespace: 'other', value: 6), counter(tags: ['a:b', 'c:d'], value: 2)]
}

private static MetricCollector.Metric counter(final Map metric) {
metric.namespace = metric.namespace ?: 'namespace'
metric.metric = metric.metric ?: 'metric'
Expand Down
Loading