Skip to content

Add dependency on Maven Central deployment to OCI publish jobs #9204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Jul 19, 2025

What Does This Do

OCI publishing jobs (gated by the one-pipeline publishing-gate job) now depend on images to be successfully published to Maven Central before proceeding. This is done through a new verify_maven_central_deployment job.

In case the verify_maven_central_deployment job fails, we can override the failure by manually triggering the override_verify_maven_central job. This ensures that the publishing jobs can still run regardless.

Motivation

Previously, all OCI-related jobs were triggered as soon as the build step was successful. This gave little buffer between when a release begins and when OCI images are published and enter customer prod environments. The additional dependency added in this PR avoids prematurely publishing OCI images.

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@sarahchen6 sarahchen6 added type: enhancement Enhancements and improvements comp: tooling Build & Tooling labels Jul 19, 2025
@pr-commenter
Copy link

pr-commenter bot commented Jul 19, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/change-release-job-dependencies
git_commit_date 1755014538 1755114814
git_commit_sha ee43e5f f9652e7
release_version 1.53.0-SNAPSHOT~ee43e5f19c 1.53.0-SNAPSHOT~f9652e7ab8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755116529 1755116529
ci_job_id 1079468142 1079468142
ci_pipeline_id 73611742 73611742
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-mqx7sx41 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-mqx7sx41 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1045328
Total [baseline] (8.585 s) : 0, 8584855
Agent [candidate] (1.048 s) : 0, 1048090
Total [candidate] (8.594 s) : 0, 8593798
section iast
Agent [baseline] (1.178 s) : 0, 1177765
Total [baseline] (9.291 s) : 0, 9290915
Agent [candidate] (1.179 s) : 0, 1178628
Total [candidate] (9.313 s) : 0, 9312502
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.178 s 132.437 ms (12.7%)
Total tracing 8.585 s -
Total iast 9.291 s 706.06 ms (8.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.179 s 130.538 ms (12.5%)
Total tracing 8.594 s -
Total iast 9.313 s 718.704 ms (8.4%)
gantt
    title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (732.121 ms) : 0, 732121
BytebuddyAgent [candidate] (732.52 ms) : 0, 732520
GlobalTracer [baseline] (242.199 ms) : 0, 242199
GlobalTracer [candidate] (242.576 ms) : 0, 242576
AppSec [baseline] (29.938 ms) : 0, 29938
AppSec [candidate] (30.118 ms) : 0, 30118
Debugger [baseline] (6.007 ms) : 0, 6007
Debugger [candidate] (6.044 ms) : 0, 6044
Remote Config [baseline] (650.677 µs) : 0, 651
Remote Config [candidate] (653.411 µs) : 0, 653
Telemetry [baseline] (12.067 ms) : 0, 12067
Telemetry [candidate] (13.81 ms) : 0, 13810
section iast
crashtracking [baseline] (1.428 ms) : 0, 1428
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (850.445 ms) : 0, 850445
BytebuddyAgent [candidate] (850.913 ms) : 0, 850913
GlobalTracer [baseline] (233.687 ms) : 0, 233687
GlobalTracer [candidate] (234.005 ms) : 0, 234005
IAST [baseline] (28.314 ms) : 0, 28314
IAST [candidate] (28.26 ms) : 0, 28260
AppSec [baseline] (28.245 ms) : 0, 28245
AppSec [candidate] (27.496 ms) : 0, 27496
Debugger [baseline] (5.738 ms) : 0, 5738
Debugger [candidate] (6.583 ms) : 0, 6583
Remote Config [baseline] (579.625 µs) : 0, 580
Remote Config [candidate] (593.318 µs) : 0, 593
Telemetry [baseline] (8.335 ms) : 0, 8335
Telemetry [candidate] (8.23 ms) : 0, 8230
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043551
Total [baseline] (10.655 s) : 0, 10654696
Agent [candidate] (1.044 s) : 0, 1044422
Total [candidate] (10.769 s) : 0, 10768861
section appsec
Agent [baseline] (1.234 s) : 0, 1234057
Total [baseline] (10.771 s) : 0, 10771442
Agent [candidate] (1.223 s) : 0, 1222567
Total [candidate] (10.808 s) : 0, 10808008
section iast
Agent [baseline] (1.177 s) : 0, 1176543
Total [baseline] (10.864 s) : 0, 10863758
Agent [candidate] (1.181 s) : 0, 1180982
Total [candidate] (10.945 s) : 0, 10944617
section profiling
Agent [baseline] (1.213 s) : 0, 1213214
Total [baseline] (10.947 s) : 0, 10947002
Agent [candidate] (1.198 s) : 0, 1197775
Total [candidate] (10.82 s) : 0, 10819777
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent appsec 1.234 s 190.506 ms (18.3%)
Agent iast 1.177 s 132.991 ms (12.7%)
Agent profiling 1.213 s 169.662 ms (16.3%)
Total tracing 10.655 s -
Total appsec 10.771 s 116.745 ms (1.1%)
Total iast 10.864 s 209.061 ms (2.0%)
Total profiling 10.947 s 292.306 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.044 s -
Agent appsec 1.223 s 178.145 ms (17.1%)
Agent iast 1.181 s 136.56 ms (13.1%)
Agent profiling 1.198 s 153.353 ms (14.7%)
Total tracing 10.769 s -
Total appsec 10.808 s 39.147 ms (0.4%)
Total iast 10.945 s 175.755 ms (1.6%)
Total profiling 10.82 s 50.916 ms (0.5%)
gantt
    title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.446 ms) : 0, 1446
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (732.35 ms) : 0, 732350
BytebuddyAgent [candidate] (731.386 ms) : 0, 731386
GlobalTracer [baseline] (242.215 ms) : 0, 242215
GlobalTracer [candidate] (241.788 ms) : 0, 241788
AppSec [baseline] (29.949 ms) : 0, 29949
AppSec [candidate] (30.1 ms) : 0, 30100
Debugger [baseline] (6.001 ms) : 0, 6001
Debugger [candidate] (6.023 ms) : 0, 6023
Remote Config [baseline] (647.049 µs) : 0, 647
Remote Config [candidate] (649.202 µs) : 0, 649
Telemetry [baseline] (9.955 ms) : 0, 9955
Telemetry [candidate] (12.085 ms) : 0, 12085
section appsec
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (764.385 ms) : 0, 764385
BytebuddyAgent [candidate] (754.831 ms) : 0, 754831
GlobalTracer [baseline] (236.785 ms) : 0, 236785
GlobalTracer [candidate] (235.62 ms) : 0, 235620
IAST [baseline] (23.694 ms) : 0, 23694
IAST [candidate] (23.445 ms) : 0, 23445
AppSec [baseline] (169.507 ms) : 0, 169507
AppSec [candidate] (169.054 ms) : 0, 169054
Debugger [baseline] (7.245 ms) : 0, 7245
Debugger [candidate] (8.053 ms) : 0, 8053
Remote Config [baseline] (614.36 µs) : 0, 614
Remote Config [candidate] (610.45 µs) : 0, 610
Telemetry [baseline] (9.077 ms) : 0, 9077
Telemetry [candidate] (8.376 ms) : 0, 8376
section iast
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.432 ms) : 0, 1432
BytebuddyAgent [baseline] (848.986 ms) : 0, 848986
BytebuddyAgent [candidate] (852.947 ms) : 0, 852947
GlobalTracer [baseline] (233.167 ms) : 0, 233167
GlobalTracer [candidate] (234.303 ms) : 0, 234303
IAST [baseline] (29.803 ms) : 0, 29803
IAST [candidate] (29.771 ms) : 0, 29771
AppSec [baseline] (27.441 ms) : 0, 27441
AppSec [candidate] (25.968 ms) : 0, 25968
Debugger [baseline] (5.741 ms) : 0, 5741
Debugger [candidate] (6.66 ms) : 0, 6660
Remote Config [baseline] (580.457 µs) : 0, 580
Remote Config [candidate] (587.278 µs) : 0, 587
Telemetry [baseline] (8.302 ms) : 0, 8302
Telemetry [candidate] (8.251 ms) : 0, 8251
section profiling
crashtracking [baseline] (1.423 ms) : 0, 1423
crashtracking [candidate] (1.409 ms) : 0, 1409
BytebuddyAgent [baseline] (772.946 ms) : 0, 772946
BytebuddyAgent [candidate] (763.062 ms) : 0, 763062
GlobalTracer [baseline] (224.897 ms) : 0, 224897
GlobalTracer [candidate] (222.381 ms) : 0, 222381
AppSec [baseline] (30.619 ms) : 0, 30619
AppSec [candidate] (30.016 ms) : 0, 30016
Debugger [baseline] (6.448 ms) : 0, 6448
Debugger [candidate] (6.32 ms) : 0, 6320
Remote Config [baseline] (698.199 µs) : 0, 698
Remote Config [candidate] (679.947 µs) : 0, 680
Telemetry [baseline] (15.628 ms) : 0, 15628
Telemetry [candidate] (15.415 ms) : 0, 15415
ProfilingAgent [baseline] (110.403 ms) : 0, 110403
ProfilingAgent [candidate] (108.569 ms) : 0, 108569
Profiling [baseline] (111.053 ms) : 0, 111053
Profiling [candidate] (109.209 ms) : 0, 109209
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/change-release-job-dependencies
git_commit_date 1755014538 1755114814
git_commit_sha ee43e5f f9652e7
release_version 1.53.0-SNAPSHOT~ee43e5f19c 1.53.0-SNAPSHOT~f9652e7ab8
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1755116196 1755116196
ci_job_id 1079468143 1079468143
ci_pipeline_id 73611742 73611742
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-anqbtg8w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-anqbtg8w 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 3 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load better
[-203.946µs; -90.647µs] or [-4.647%; -2.065%]
unstable
[-82.253op/s; +153.128op/s] or [-7.866%; +14.644%]
4.242ms 1081.125op/s 4.389ms 1045.688op/s
scenario:load:insecure-bank:profiling:high_load worse
[+267.272µs; +580.565µs] or [+3.171%; +6.887%]
unstable
[-95.651op/s; +43.526op/s] or [-17.390%; +7.913%]
8.853ms 523.969op/s 8.429ms 550.031op/s
scenario:load:insecure-bank:iast_GLOBAL:high_load better
[-1011.576µs; -617.842µs] or [-9.372%; -5.724%]
unstable
[-16.932op/s; +86.307op/s] or [-3.931%; +20.039%]
9.979ms 465.375op/s 10.794ms 430.688op/s
scenario:load:petclinic:appsec:high_load worse
[+1.258ms; +2.157ms] or [+2.743%; +4.703%]
unstable
[-11.033op/s; +3.783op/s] or [-10.817%; +3.709%]
47.569ms 98.375op/s 45.862ms 102.000op/s
scenario:load:petclinic:iast:high_load worse
[+1.641ms; +2.464ms] or [+3.837%; +5.764%]
unstable
[-12.821op/s; +2.746op/s] or [-11.717%; +2.510%]
44.806ms 104.388op/s 42.754ms 109.425op/s
scenario:load:petclinic:profiling:high_load better
[-3.800ms; -2.836ms] or [-7.646%; -5.707%]
unstable
[-0.589op/s; +14.039op/s] or [-0.625%; +14.899%]
46.375ms 100.950op/s 49.693ms 94.225op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.245 ms) : 36947, 37544
.   : milestone, 37245,
appsec (45.862 ms) : 45445, 46278
.   : milestone, 45862,
code_origins (44.686 ms) : 44307, 45066
.   : milestone, 44686,
iast (42.754 ms) : 42388, 43120
.   : milestone, 42754,
profiling (49.693 ms) : 49233, 50153
.   : milestone, 49693,
tracing (44.918 ms) : 44536, 45299
.   : milestone, 44918,
section candidate
no_agent (36.648 ms) : 36348, 36947
.   : milestone, 36648,
appsec (47.569 ms) : 47151, 47987
.   : milestone, 47569,
code_origins (43.802 ms) : 43419, 44185
.   : milestone, 43802,
iast (44.806 ms) : 44408, 45205
.   : milestone, 44806,
profiling (46.375 ms) : 45941, 46810
.   : milestone, 46375,
tracing (45.312 ms) : 44927, 45698
.   : milestone, 45312,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.245 ms [36.947 ms, 37.544 ms] -
appsec 45.862 ms [45.445 ms, 46.278 ms] 8.616 ms (23.1%)
code_origins 44.686 ms [44.307 ms, 45.066 ms] 7.441 ms (20.0%)
iast 42.754 ms [42.388 ms, 43.12 ms] 5.509 ms (14.8%)
profiling 49.693 ms [49.233 ms, 50.153 ms] 12.448 ms (33.4%)
tracing 44.918 ms [44.536 ms, 45.299 ms] 7.672 ms (20.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.648 ms [36.348 ms, 36.947 ms] -
appsec 47.569 ms [47.151 ms, 47.987 ms] 10.921 ms (29.8%)
code_origins 43.802 ms [43.419 ms, 44.185 ms] 7.155 ms (19.5%)
iast 44.806 ms [44.408 ms, 45.205 ms] 8.159 ms (22.3%)
profiling 46.375 ms [45.941 ms, 46.81 ms] 9.728 ms (26.5%)
tracing 45.312 ms [44.927 ms, 45.698 ms] 8.664 ms (23.6%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.389 ms) : 4333, 4446
.   : milestone, 4389,
iast (9.215 ms) : 9064, 9366
.   : milestone, 9215,
iast_FULL (14.427 ms) : 14140, 14714
.   : milestone, 14427,
iast_GLOBAL (10.794 ms) : 10603, 10985
.   : milestone, 10794,
profiling (8.429 ms) : 8294, 8565
.   : milestone, 8429,
tracing (7.419 ms) : 7318, 7520
.   : milestone, 7419,
section candidate
no_agent (4.242 ms) : 4194, 4290
.   : milestone, 4242,
iast (9.497 ms) : 9329, 9664
.   : milestone, 9497,
iast_FULL (13.961 ms) : 13679, 14243
.   : milestone, 13961,
iast_GLOBAL (9.979 ms) : 9804, 10154
.   : milestone, 9979,
profiling (8.853 ms) : 8698, 9008
.   : milestone, 8853,
tracing (7.449 ms) : 7347, 7552
.   : milestone, 7449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.389 ms [4.333 ms, 4.446 ms] -
iast 9.215 ms [9.064 ms, 9.366 ms] 4.826 ms (109.9%)
iast_FULL 14.427 ms [14.14 ms, 14.714 ms] 10.038 ms (228.7%)
iast_GLOBAL 10.794 ms [10.603 ms, 10.985 ms] 6.405 ms (145.9%)
profiling 8.429 ms [8.294 ms, 8.565 ms] 4.04 ms (92.0%)
tracing 7.419 ms [7.318 ms, 7.52 ms] 3.03 ms (69.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.242 ms [4.194 ms, 4.29 ms] -
iast 9.497 ms [9.329 ms, 9.664 ms] 5.255 ms (123.9%)
iast_FULL 13.961 ms [13.679 ms, 14.243 ms] 9.719 ms (229.1%)
iast_GLOBAL 9.979 ms [9.804 ms, 10.154 ms] 5.737 ms (135.2%)
profiling 8.853 ms [8.698 ms, 9.008 ms] 4.611 ms (108.7%)
tracing 7.449 ms [7.347 ms, 7.552 ms] 3.207 ms (75.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/change-release-job-dependencies
git_commit_date 1755014538 1755114814
git_commit_sha ee43e5f f9652e7
release_version 1.53.0-SNAPSHOT~ee43e5f19c 1.53.0-SNAPSHOT~f9652e7ab8
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1755116693 1755116693
ci_job_id 1079468144 1079468144
ci_pipeline_id 73611742 73611742
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-2atrm3ic 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-2atrm3ic 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.966 s) : 14966000, 14966000
.   : milestone, 14966000,
appsec (14.538 s) : 14538000, 14538000
.   : milestone, 14538000,
iast (18.913 s) : 18913000, 18913000
.   : milestone, 18913000,
iast_GLOBAL (18.14 s) : 18140000, 18140000
.   : milestone, 18140000,
profiling (15.316 s) : 15316000, 15316000
.   : milestone, 15316000,
tracing (15.063 s) : 15063000, 15063000
.   : milestone, 15063000,
section candidate
no_agent (15.284 s) : 15284000, 15284000
.   : milestone, 15284000,
appsec (14.897 s) : 14897000, 14897000
.   : milestone, 14897000,
iast (18.245 s) : 18245000, 18245000
.   : milestone, 18245000,
iast_GLOBAL (18.092 s) : 18092000, 18092000
.   : milestone, 18092000,
profiling (16.041 s) : 16041000, 16041000
.   : milestone, 16041000,
tracing (15.145 s) : 15145000, 15145000
.   : milestone, 15145000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.966 s [14.966 s, 14.966 s] -
appsec 14.538 s [14.538 s, 14.538 s] -428.0 ms (-2.9%)
iast 18.913 s [18.913 s, 18.913 s] 3.947 s (26.4%)
iast_GLOBAL 18.14 s [18.14 s, 18.14 s] 3.174 s (21.2%)
profiling 15.316 s [15.316 s, 15.316 s] 350.0 ms (2.3%)
tracing 15.063 s [15.063 s, 15.063 s] 97.0 ms (0.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.284 s [15.284 s, 15.284 s] -
appsec 14.897 s [14.897 s, 14.897 s] -387.0 ms (-2.5%)
iast 18.245 s [18.245 s, 18.245 s] 2.961 s (19.4%)
iast_GLOBAL 18.092 s [18.092 s, 18.092 s] 2.808 s (18.4%)
profiling 16.041 s [16.041 s, 16.041 s] 757.0 ms (5.0%)
tracing 15.145 s [15.145 s, 15.145 s] -139.0 ms (-0.9%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~f9652e7ab8, baseline=1.53.0-SNAPSHOT~ee43e5f19c
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
.   : milestone, 1472,
appsec (3.652 ms) : 3435, 3868
.   : milestone, 3652,
iast (2.193 ms) : 2130, 2255
.   : milestone, 2193,
iast_GLOBAL (2.234 ms) : 2171, 2298
.   : milestone, 2234,
profiling (2.024 ms) : 1974, 2075
.   : milestone, 2024,
tracing (2.021 ms) : 1972, 2070
.   : milestone, 2021,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (3.644 ms) : 3427, 3861
.   : milestone, 3644,
iast (2.185 ms) : 2122, 2248
.   : milestone, 2185,
iast_GLOBAL (2.242 ms) : 2179, 2306
.   : milestone, 2242,
profiling (2.053 ms) : 2001, 2106
.   : milestone, 2053,
tracing (2.027 ms) : 1978, 2076
.   : milestone, 2027,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.472 ms [1.461 ms, 1.484 ms] -
appsec 3.652 ms [3.435 ms, 3.868 ms] 2.18 ms (148.1%)
iast 2.193 ms [2.13 ms, 2.255 ms] 720.552 µs (48.9%)
iast_GLOBAL 2.234 ms [2.171 ms, 2.298 ms] 762.258 µs (51.8%)
profiling 2.024 ms [1.974 ms, 2.075 ms] 552.35 µs (37.5%)
tracing 2.021 ms [1.972 ms, 2.07 ms] 548.642 µs (37.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 3.644 ms [3.427 ms, 3.861 ms] 2.17 ms (147.3%)
iast 2.185 ms [2.122 ms, 2.248 ms] 710.917 µs (48.2%)
iast_GLOBAL 2.242 ms [2.179 ms, 2.306 ms] 768.736 µs (52.2%)
profiling 2.053 ms [2.001 ms, 2.106 ms] 579.575 µs (39.3%)
tracing 2.027 ms [1.978 ms, 2.076 ms] 553.238 µs (37.5%)

@sarahchen6 sarahchen6 marked this pull request as ready for review July 21, 2025 15:19
@sarahchen6 sarahchen6 requested a review from a team as a code owner July 21, 2025 15:19
@sarahchen6 sarahchen6 requested review from bqbits, randomanderson and erikayasuda and removed request for a team July 21, 2025 15:19
@sarahchen6 sarahchen6 marked this pull request as draft July 21, 2025 17:52
@bqbits bqbits removed their request for review July 21, 2025 19:26
@sarahchen6 sarahchen6 force-pushed the sarahchen6/change-release-job-dependencies branch 6 times, most recently from a7ccd00 to 5e179f7 Compare July 23, 2025 20:48
@sarahchen6 sarahchen6 marked this pull request as ready for review July 23, 2025 21:05
@sarahchen6 sarahchen6 marked this pull request as draft July 28, 2025 15:12
@sarahchen6 sarahchen6 force-pushed the sarahchen6/change-release-job-dependencies branch 2 times, most recently from 5aee06c to ee81d85 Compare July 28, 2025 15:31
when: on_success
- when: manual
allow_failure: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The publishing-gate job can be manually overridden in case verify_maven_central_deployment fails and we still want to publish OCI images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work as you expect. If verify_maven_central_deploymentfails, publishing-gate won't be runnable, manually or otherwise. There is no simple workaround supported by Gitlab. One option would be a pipeline variable, but then you have to rerun the entire pipeline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing this by running a test-job with the same parameters as the publishing-gate job (commit here), and the behavior in CI seems like what we want 👀 . Here are the pipeline results where I force verify_maven_central_deployment to fail and am still able to manually run test-job: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/pipelines/72112529.

It seems like even if verify_maven_central_deployment fails, we can still manually trigger publishing-gate..? From the docs here, publishing-gate can run as long as verify_maven_central_deployment completes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just kidding -- you can see here in @randomanderson 's reproduction (pipeline, code) that if verify_maven_central_deployment fails, then there's no way to run publishing-gate, which is a problem.

@sarahchen6 sarahchen6 marked this pull request as ready for review July 28, 2025 21:42
@sarahchen6 sarahchen6 requested a review from PerfectSlayer July 28, 2025 21:43
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about checking for the other artefacts too? (ie dd-trace-api and dd-trace-ot)

Otherwise, looking good from LP perspective. I would recommend having review from RP too as I’m no GitLab CI expert 😇

when: on_success
- when: manual
allow_failure: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't work as you expect. If verify_maven_central_deploymentfails, publishing-gate won't be runnable, manually or otherwise. There is no simple workaround supported by Gitlab. One option would be a pipeline variable, but then you have to rerun the entire pipeline

@sarahchen6 sarahchen6 force-pushed the sarahchen6/change-release-job-dependencies branch from 6180035 to 4f1db26 Compare July 29, 2025 22:35
@sarahchen6 sarahchen6 force-pushed the sarahchen6/change-release-job-dependencies branch from fe7374c to f9652e7 Compare August 13, 2025 19:53
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Aug 13, 2025

Code coverage: total 57.29%, base diff -0.04%, patch 100.00% (view details)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f9652e7 | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling type: enhancement Enhancements and improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants