-
Notifications
You must be signed in to change notification settings - Fork 311
Add policy for GHA workflow #9303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
@sarahchen6 would you mind to trigger action manually once merged to master? |
@AlexeyKuznetsov-DD Will do. I'll test on the #9302 branch first, but once that goes in, I'll retrigger the failed workflows on |
Code coverage: total 57.13%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 7cbc1f3 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044854
Total [baseline] (10.682 s) : 0, 10681628
Agent [candidate] (1.042 s) : 0, 1041553
Total [candidate] (10.731 s) : 0, 10731327
section appsec
Agent [baseline] (1.219 s) : 0, 1218972
Total [baseline] (10.747 s) : 0, 10747123
Agent [candidate] (1.222 s) : 0, 1221601
Total [candidate] (10.884 s) : 0, 10884316
section iast
Agent [baseline] (1.177 s) : 0, 1177132
Total [baseline] (10.909 s) : 0, 10908787
Agent [candidate] (1.183 s) : 0, 1182883
Total [candidate] (10.984 s) : 0, 10983642
section profiling
Agent [baseline] (1.189 s) : 0, 1189427
Total [baseline] (10.887 s) : 0, 10886911
Agent [candidate] (1.192 s) : 0, 1192099
Total [candidate] (10.872 s) : 0, 10872031
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (732.237 ms) : 0, 732237
BytebuddyAgent [candidate] (730.259 ms) : 0, 730259
GlobalTracer [baseline] (241.976 ms) : 0, 241976
GlobalTracer [candidate] (241.446 ms) : 0, 241446
AppSec [baseline] (30.255 ms) : 0, 30255
AppSec [candidate] (30.186 ms) : 0, 30186
Debugger [baseline] (6.032 ms) : 0, 6032
Debugger [candidate] (6.037 ms) : 0, 6037
Remote Config [baseline] (643.605 µs) : 0, 644
Remote Config [candidate] (651.278 µs) : 0, 651
Telemetry [baseline] (11.259 ms) : 0, 11259
Telemetry [candidate] (10.587 ms) : 0, 10587
section appsec
crashtracking [baseline] (1.43 ms) : 0, 1430
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (752.641 ms) : 0, 752641
BytebuddyAgent [candidate] (753.507 ms) : 0, 753507
GlobalTracer [baseline] (234.894 ms) : 0, 234894
GlobalTracer [candidate] (235.601 ms) : 0, 235601
IAST [baseline] (23.627 ms) : 0, 23627
IAST [candidate] (23.636 ms) : 0, 23636
AppSec [baseline] (167.913 ms) : 0, 167913
AppSec [candidate] (168.666 ms) : 0, 168666
Debugger [baseline] (8.632 ms) : 0, 8632
Debugger [candidate] (7.957 ms) : 0, 7957
Remote Config [baseline] (623.317 µs) : 0, 623
Remote Config [candidate] (616.444 µs) : 0, 616
Telemetry [baseline] (8.17 ms) : 0, 8170
Telemetry [candidate] (9.084 ms) : 0, 9084
section iast
crashtracking [baseline] (1.432 ms) : 0, 1432
crashtracking [candidate] (1.447 ms) : 0, 1447
BytebuddyAgent [baseline] (850.008 ms) : 0, 850008
BytebuddyAgent [candidate] (854.593 ms) : 0, 854593
GlobalTracer [baseline] (232.471 ms) : 0, 232471
GlobalTracer [candidate] (232.453 ms) : 0, 232453
IAST [baseline] (30.549 ms) : 0, 30549
IAST [candidate] (31.772 ms) : 0, 31772
AppSec [baseline] (25.302 ms) : 0, 25302
AppSec [candidate] (25.908 ms) : 0, 25908
Debugger [baseline] (7.609 ms) : 0, 7609
Debugger [candidate] (6.692 ms) : 0, 6692
Remote Config [baseline] (587.298 µs) : 0, 587
Remote Config [candidate] (597.641 µs) : 0, 598
Telemetry [baseline] (8.106 ms) : 0, 8106
Telemetry [candidate] (8.326 ms) : 0, 8326
section profiling
crashtracking [baseline] (1.408 ms) : 0, 1408
crashtracking [candidate] (1.408 ms) : 0, 1408
BytebuddyAgent [baseline] (757.99 ms) : 0, 757990
BytebuddyAgent [candidate] (759.538 ms) : 0, 759538
GlobalTracer [baseline] (221.146 ms) : 0, 221146
GlobalTracer [candidate] (221.721 ms) : 0, 221721
AppSec [baseline] (29.763 ms) : 0, 29763
AppSec [candidate] (29.859 ms) : 0, 29859
Debugger [baseline] (6.194 ms) : 0, 6194
Debugger [candidate] (6.31 ms) : 0, 6310
Remote Config [baseline] (684.978 µs) : 0, 685
Remote Config [candidate] (697.712 µs) : 0, 698
Telemetry [baseline] (15.891 ms) : 0, 15891
Telemetry [candidate] (15.325 ms) : 0, 15325
ProfilingAgent [baseline] (107.134 ms) : 0, 107134
ProfilingAgent [candidate] (107.933 ms) : 0, 107933
Profiling [baseline] (107.753 ms) : 0, 107753
Profiling [candidate] (108.569 ms) : 0, 108569
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054605
Total [baseline] (8.637 s) : 0, 8637300
Agent [candidate] (1.043 s) : 0, 1043079
Total [candidate] (8.589 s) : 0, 8588789
section iast
Agent [baseline] (1.175 s) : 0, 1175495
Total [baseline] (9.273 s) : 0, 9273235
Agent [candidate] (1.176 s) : 0, 1175692
Total [candidate] (9.28 s) : 0, 9280488
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.435 ms) : 0, 1435
BytebuddyAgent [baseline] (739.063 ms) : 0, 739063
BytebuddyAgent [candidate] (729.434 ms) : 0, 729434
GlobalTracer [baseline] (243.847 ms) : 0, 243847
GlobalTracer [candidate] (241.441 ms) : 0, 241441
AppSec [baseline] (30.214 ms) : 0, 30214
AppSec [candidate] (29.8 ms) : 0, 29800
Debugger [baseline] (6.066 ms) : 0, 6066
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (656.05 µs) : 0, 656
Remote Config [candidate] (648.259 µs) : 0, 648
Telemetry [baseline] (12.088 ms) : 0, 12088
Telemetry [candidate] (13.387 ms) : 0, 13387
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (848.881 ms) : 0, 848881
BytebuddyAgent [candidate] (848.593 ms) : 0, 848593
GlobalTracer [baseline] (232.062 ms) : 0, 232062
GlobalTracer [candidate] (232.35 ms) : 0, 232350
IAST [baseline] (29.772 ms) : 0, 29772
IAST [candidate] (29.749 ms) : 0, 29749
AppSec [baseline] (26.968 ms) : 0, 26968
AppSec [candidate] (27.174 ms) : 0, 27174
Debugger [baseline] (6.705 ms) : 0, 6705
Debugger [candidate] (6.661 ms) : 0, 6661
Remote Config [baseline] (604.427 µs) : 0, 604
Remote Config [candidate] (591.636 µs) : 0, 592
Telemetry [baseline] (8.072 ms) : 0, 8072
Telemetry [candidate] (8.133 ms) : 0, 8133
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section baseline
no_agent (36.336 ms) : 36045, 36628
. : milestone, 36336,
appsec (46.202 ms) : 45805, 46599
. : milestone, 46202,
code_origins (43.286 ms) : 42900, 43671
. : milestone, 43286,
iast (44.493 ms) : 44108, 44877
. : milestone, 44493,
profiling (48.692 ms) : 48253, 49130
. : milestone, 48692,
tracing (42.954 ms) : 42594, 43313
. : milestone, 42954,
section candidate
no_agent (36.052 ms) : 35759, 36345
. : milestone, 36052,
appsec (47.834 ms) : 47405, 48264
. : milestone, 47834,
code_origins (44.947 ms) : 44531, 45362
. : milestone, 44947,
iast (45.506 ms) : 45099, 45913
. : milestone, 45506,
profiling (48.399 ms) : 47929, 48870
. : milestone, 48399,
tracing (44.057 ms) : 43664, 44450
. : milestone, 44057,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section baseline
no_agent (4.29 ms) : 4240, 4341
. : milestone, 4290,
iast (9.34 ms) : 9185, 9494
. : milestone, 9340,
iast_FULL (13.951 ms) : 13675, 14228
. : milestone, 13951,
iast_GLOBAL (10.344 ms) : 10161, 10527
. : milestone, 10344,
profiling (8.94 ms) : 8800, 9080
. : milestone, 8940,
tracing (7.659 ms) : 7551, 7766
. : milestone, 7659,
section candidate
no_agent (4.324 ms) : 4276, 4372
. : milestone, 4324,
iast (9.279 ms) : 9125, 9433
. : milestone, 9279,
iast_FULL (14.193 ms) : 13912, 14473
. : milestone, 14193,
iast_GLOBAL (10.134 ms) : 9956, 10311
. : milestone, 10134,
profiling (8.437 ms) : 8308, 8565
. : milestone, 8437,
tracing (7.658 ms) : 7548, 7767
. : milestone, 7658,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section baseline
no_agent (15.362 s) : 15362000, 15362000
. : milestone, 15362000,
appsec (14.613 s) : 14613000, 14613000
. : milestone, 14613000,
iast (18.701 s) : 18701000, 18701000
. : milestone, 18701000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
. : milestone, 18029000,
profiling (15.397 s) : 15397000, 15397000
. : milestone, 15397000,
tracing (15.002 s) : 15002000, 15002000
. : milestone, 15002000,
section candidate
no_agent (15.65 s) : 15650000, 15650000
. : milestone, 15650000,
appsec (14.762 s) : 14762000, 14762000
. : milestone, 14762000,
iast (18.833 s) : 18833000, 18833000
. : milestone, 18833000,
iast_GLOBAL (18.113 s) : 18113000, 18113000
. : milestone, 18113000,
profiling (15.295 s) : 15295000, 15295000
. : milestone, 15295000,
tracing (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~7cbc1f3e43, baseline=1.53.0-SNAPSHOT~ee6947e276
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.691 ms) : 3473, 3908
. : milestone, 3691,
iast (2.198 ms) : 2135, 2261
. : milestone, 2198,
iast_GLOBAL (2.247 ms) : 2183, 2310
. : milestone, 2247,
profiling (2.057 ms) : 2005, 2109
. : milestone, 2057,
tracing (2.024 ms) : 1975, 2073
. : milestone, 2024,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.411 ms) : 2361, 2461
. : milestone, 2411,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.239 ms) : 2176, 2303
. : milestone, 2239,
profiling (2.051 ms) : 2000, 2103
. : milestone, 2051,
tracing (2.024 ms) : 1975, 2073
. : milestone, 2024,
|
What Does This Do
This PR supercedes #9302. Only policies on
master
are valid, so merging this PR separately will allow testing #9302.Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-722