-
Notifications
You must be signed in to change notification settings - Fork 323
Improve stability of FixedSizeCacheTest identity/weak tests #9362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
by eliminating the chance identity hash might collide even after 3 rehashes the easiest way to do this is to bump the size of the cache used in testing note this is only necessary because we want to keep both keys in the cache to test the 'visit' method - otherwise we'd need to relax that assertion
|
Code coverage: total 49.90%, base diff -7.43%, patch 100.00% (view details) This comment will be updated automatically if new data arrives.🔗 Commit SHA: 65f79d7 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1050576
Total [baseline] (8.587 s) : 0, 8587240
Agent [candidate] (1.044 s) : 0, 1043997
Total [candidate] (8.561 s) : 0, 8560645
section iast
Agent [baseline] (1.177 s) : 0, 1176935
Total [baseline] (9.327 s) : 0, 9327160
Agent [candidate] (1.181 s) : 0, 1181479
Total [candidate] (9.328 s) : 0, 9327664
gantt
title insecure-bank - break down per module: candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.44 ms) : 0, 1440
crashtracking [candidate] (1.419 ms) : 0, 1419
BytebuddyAgent [baseline] (737.488 ms) : 0, 737488
BytebuddyAgent [candidate] (731.98 ms) : 0, 731980
GlobalTracer [baseline] (242.418 ms) : 0, 242418
GlobalTracer [candidate] (241.746 ms) : 0, 241746
AppSec [baseline] (30.151 ms) : 0, 30151
AppSec [candidate] (29.944 ms) : 0, 29944
Debugger [baseline] (6.027 ms) : 0, 6027
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (656.967 µs) : 0, 657
Remote Config [candidate] (648.393 µs) : 0, 648
Telemetry [baseline] (11.323 ms) : 0, 11323
Telemetry [candidate] (11.324 ms) : 0, 11324
section iast
crashtracking [baseline] (1.426 ms) : 0, 1426
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (849.768 ms) : 0, 849768
BytebuddyAgent [candidate] (852.177 ms) : 0, 852177
GlobalTracer [baseline] (232.755 ms) : 0, 232755
GlobalTracer [candidate] (234.262 ms) : 0, 234262
IAST [baseline] (29.3 ms) : 0, 29300
IAST [candidate] (27.62 ms) : 0, 27620
AppSec [baseline] (27.262 ms) : 0, 27262
AppSec [candidate] (29.258 ms) : 0, 29258
Debugger [baseline] (6.613 ms) : 0, 6613
Debugger [candidate] (6.575 ms) : 0, 6575
Remote Config [baseline] (582.907 µs) : 0, 583
Remote Config [candidate] (574.887 µs) : 0, 575
Telemetry [baseline] (8.263 ms) : 0, 8263
Telemetry [candidate] (8.471 ms) : 0, 8471
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1041805
Total [baseline] (10.732 s) : 0, 10732425
Agent [candidate] (1.048 s) : 0, 1048382
Total [candidate] (10.746 s) : 0, 10745837
section appsec
Agent [baseline] (1.217 s) : 0, 1216874
Total [baseline] (10.758 s) : 0, 10758272
Agent [candidate] (1.219 s) : 0, 1219230
Total [candidate] (10.894 s) : 0, 10893698
section iast
Agent [baseline] (1.189 s) : 0, 1188524
Total [baseline] (10.97 s) : 0, 10970075
Agent [candidate] (1.177 s) : 0, 1177270
Total [candidate] (10.926 s) : 0, 10925723
section profiling
Agent [baseline] (1.192 s) : 0, 1192225
Total [baseline] (10.879 s) : 0, 10878953
Agent [candidate] (1.191 s) : 0, 1190569
Total [candidate] (10.837 s) : 0, 10837159
gantt
title petclinic - break down per module: candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.418 ms) : 0, 1418
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (729.407 ms) : 0, 729407
BytebuddyAgent [candidate] (735.424 ms) : 0, 735424
GlobalTracer [baseline] (240.818 ms) : 0, 240818
GlobalTracer [candidate] (241.849 ms) : 0, 241849
AppSec [baseline] (29.982 ms) : 0, 29982
AppSec [candidate] (30.072 ms) : 0, 30072
Debugger [baseline] (5.991 ms) : 0, 5991
Debugger [candidate] (5.996 ms) : 0, 5996
Remote Config [baseline] (643.163 µs) : 0, 643
Remote Config [candidate] (643.272 µs) : 0, 643
Telemetry [baseline] (12.689 ms) : 0, 12689
Telemetry [candidate] (11.934 ms) : 0, 11934
section appsec
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.43 ms) : 0, 1430
BytebuddyAgent [baseline] (751.8 ms) : 0, 751800
BytebuddyAgent [candidate] (753.435 ms) : 0, 753435
GlobalTracer [baseline] (234.497 ms) : 0, 234497
GlobalTracer [candidate] (235.012 ms) : 0, 235012
IAST [baseline] (23.383 ms) : 0, 23383
IAST [candidate] (23.276 ms) : 0, 23276
AppSec [baseline] (169.344 ms) : 0, 169344
AppSec [candidate] (169.601 ms) : 0, 169601
Debugger [baseline] (5.727 ms) : 0, 5727
Debugger [candidate] (6.447 ms) : 0, 6447
Remote Config [baseline] (610.393 µs) : 0, 610
Remote Config [candidate] (623.48 µs) : 0, 623
Telemetry [baseline] (9.149 ms) : 0, 9149
Telemetry [candidate] (8.386 ms) : 0, 8386
section iast
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (858.532 ms) : 0, 858532
BytebuddyAgent [candidate] (850.059 ms) : 0, 850059
GlobalTracer [baseline] (234.289 ms) : 0, 234289
GlobalTracer [candidate] (232.495 ms) : 0, 232495
IAST [baseline] (29.542 ms) : 0, 29542
IAST [candidate] (29.073 ms) : 0, 29073
AppSec [baseline] (27.019 ms) : 0, 27019
AppSec [candidate] (26.768 ms) : 0, 26768
Debugger [baseline] (7.5 ms) : 0, 7500
Debugger [candidate] (7.516 ms) : 0, 7516
Remote Config [baseline] (598.983 µs) : 0, 599
Remote Config [candidate] (596.856 µs) : 0, 597
Telemetry [baseline] (8.411 ms) : 0, 8411
Telemetry [candidate] (8.348 ms) : 0, 8348
section profiling
crashtracking [baseline] (1.399 ms) : 0, 1399
crashtracking [candidate] (1.389 ms) : 0, 1389
BytebuddyAgent [baseline] (760.026 ms) : 0, 760026
BytebuddyAgent [candidate] (758.447 ms) : 0, 758447
GlobalTracer [baseline] (221.197 ms) : 0, 221197
GlobalTracer [candidate] (221.554 ms) : 0, 221554
AppSec [baseline] (30.002 ms) : 0, 30002
AppSec [candidate] (29.834 ms) : 0, 29834
Debugger [baseline] (6.264 ms) : 0, 6264
Debugger [candidate] (6.24 ms) : 0, 6240
Remote Config [baseline] (708.116 µs) : 0, 708
Remote Config [candidate] (668.57 µs) : 0, 669
Telemetry [baseline] (15.895 ms) : 0, 15895
Telemetry [candidate] (15.096 ms) : 0, 15096
ProfilingAgent [baseline] (107.357 ms) : 0, 107357
ProfilingAgent [candidate] (108.028 ms) : 0, 108028
Profiling [baseline] (107.984 ms) : 0, 107984
Profiling [candidate] (108.662 ms) : 0, 108662
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (35.465 ms) : 35185, 35745
. : milestone, 35465,
appsec (45.526 ms) : 45107, 45945
. : milestone, 45526,
code_origins (45.882 ms) : 45485, 46280
. : milestone, 45882,
iast (44.772 ms) : 44398, 45146
. : milestone, 44772,
profiling (48.409 ms) : 47948, 48871
. : milestone, 48409,
tracing (43.756 ms) : 43381, 44132
. : milestone, 43756,
section candidate
no_agent (35.749 ms) : 35463, 36036
. : milestone, 35749,
appsec (48.15 ms) : 47717, 48583
. : milestone, 48150,
code_origins (45.249 ms) : 44867, 45631
. : milestone, 45249,
iast (45.039 ms) : 44663, 45415
. : milestone, 45039,
profiling (47.574 ms) : 47094, 48055
. : milestone, 47574,
tracing (44.422 ms) : 44037, 44806
. : milestone, 44422,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (4.454 ms) : 4404, 4505
. : milestone, 4454,
iast (9.28 ms) : 9119, 9442
. : milestone, 9280,
iast_FULL (14.181 ms) : 13895, 14467
. : milestone, 14181,
iast_GLOBAL (10.412 ms) : 10232, 10592
. : milestone, 10412,
profiling (8.667 ms) : 8529, 8806
. : milestone, 8667,
tracing (7.452 ms) : 7348, 7556
. : milestone, 7452,
section candidate
no_agent (4.36 ms) : 4309, 4412
. : milestone, 4360,
iast (9.379 ms) : 9217, 9540
. : milestone, 9379,
iast_FULL (14.193 ms) : 13913, 14472
. : milestone, 14193,
iast_GLOBAL (10.581 ms) : 10392, 10771
. : milestone, 10581,
profiling (8.737 ms) : 8601, 8873
. : milestone, 8737,
tracing (7.392 ms) : 7291, 7492
. : milestone, 7392,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (15.533 s) : 15533000, 15533000
. : milestone, 15533000,
appsec (14.713 s) : 14713000, 14713000
. : milestone, 14713000,
iast (18.913 s) : 18913000, 18913000
. : milestone, 18913000,
iast_GLOBAL (17.985 s) : 17985000, 17985000
. : milestone, 17985000,
profiling (15.486 s) : 15486000, 15486000
. : milestone, 15486000,
tracing (14.908 s) : 14908000, 14908000
. : milestone, 14908000,
section candidate
no_agent (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
appsec (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
iast (18.648 s) : 18648000, 18648000
. : milestone, 18648000,
iast_GLOBAL (17.982 s) : 17982000, 17982000
. : milestone, 17982000,
profiling (15.269 s) : 15269000, 15269000
. : milestone, 15269000,
tracing (14.948 s) : 14948000, 14948000
. : milestone, 14948000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.53.0-SNAPSHOT~65f79d77f5, baseline=1.53.0-SNAPSHOT~ee43e5f19c
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.6 ms) : 3388, 3812
. : milestone, 3600,
iast (2.202 ms) : 2140, 2264
. : milestone, 2202,
iast_GLOBAL (2.234 ms) : 2171, 2297
. : milestone, 2234,
profiling (2.06 ms) : 2009, 2112
. : milestone, 2060,
tracing (2.016 ms) : 1968, 2065
. : milestone, 2016,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.657 ms) : 3442, 3872
. : milestone, 3657,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.246 ms) : 2184, 2309
. : milestone, 2246,
profiling (2.035 ms) : 1985, 2085
. : milestone, 2035,
tracing (2.008 ms) : 1960, 2057
. : milestone, 2008,
|
What Does This Do
Improve stability of
FixedSizeCacheTestidentity/weak tests by eliminating the chance identity hash might collide even after 3 rehashes - the easiest way to do this is to bump the size of the cache used in testing.Motivation
Note this is only necessary because we want to keep both keys in the cache to test the 'visit' method - otherwise we could just relax that assertion.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]