Skip to content

Add support for Guava and FastUtil #9727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpbempel merged 2 commits into from
Oct 14, 2025
Merged

Add support for Guava and FastUtil #9727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3e167d
Add support for Guava and FastUtil
jpbempel Oct 10, 2025
fd45ccd
use a list for safe packages
jpbempel Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions ...ugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/util/WellKnownClasses.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,14 @@ public static boolean isSafe(Collection<?> collection) {
// All Collection implementations from Google ProtoBuf are considered as safe
return true;
}
if (className.startsWith("com.google.common.collect.")) {
Copy link
Contributor

@evanchooly evanchooly Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe collect these packages in a list and iterate so we're not duplicating so much now that the list is growing. otherwise 👍🏻

Copy link
Member Author

@jpbempel jpbempel Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

// All Collection implementations from Google Guava are considered as safe
return true;
}
if (className.startsWith("it.unimi.dsi.fastutil.")) {
// All Collection implementations from fastutil are considered as safe
return true;
}
return false;
}

Expand All @@ -229,6 +237,14 @@ public static boolean isSafe(Map<?, ?> map) {
// All Map implementations from Google ProtoBuf are considered as safe
return true;
}
if (className.startsWith("com.google.common.collect.")) {
// All Map implementations from Google Guava are considered as safe
return true;
}
if (className.startsWith("it.unimi.dsi.fastutil.")) {
// All Map implementations from fastutil are considered as safe
return true;
}
return false;
}

Expand Down