Skip to content

Conversation

@watson
Copy link
Collaborator

@watson watson commented Jan 9, 2026

What does this PR do?

Move all code related to configuration into the config directory (both regular code and test):

  • packages/dd-trace/src/{config_defaults.js => config/defaults.js}
  • packages/dd-trace/src/{ => config}/git_properties.js
  • packages/dd-trace/src/{config-helper.js => config/helper.js}
  • packages/dd-trace/src/{config.js => config/index.js}
  • packages/dd-trace/src/{config_stable.js => config/stable.js}
  • packages/dd-trace/src/{ => config}/supported-configurations.json
  • packages/dd-trace/test/{ => config}/git_properties.spec.js
  • packages/dd-trace/test/{config.spec.js => config/index.spec.js}

Motivation

Improved overview, encapsulation, and code ownership.

@datadog-official

This comment has been minimized.

Copy link
Collaborator Author

watson commented Jan 9, 2026

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Overall package size

Self size: 4.39 MB
Deduped: 5.22 MB
No deduping: 5.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.51%. Comparing base (9317837) to head (c73e589).

Additional details and impacted files
@@                         Coverage Diff                          @@
##           watson/DEBUG-4402/remote-enablement    #7204   +/-   ##
====================================================================
  Coverage                                84.50%   84.51%           
====================================================================
  Files                                      532      532           
  Lines                                    22741    22745    +4     
====================================================================
+ Hits                                     19218    19222    +4     
  Misses                                    3523     3523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watson watson force-pushed the watson/refactor-config branch 3 times, most recently from 852427a to ea80fa8 Compare January 9, 2026 12:28
@watson watson force-pushed the watson/refactor-config branch from ea80fa8 to c73e589 Compare January 9, 2026 12:35
@pr-commenter
Copy link

pr-commenter bot commented Jan 9, 2026

Benchmarks

Benchmark execution time: 2026-01-09 12:42:27

Comparing candidate commit c73e589 in PR branch watson/refactor-config with baseline commit 9317837 in branch watson/DEBUG-4402/remote-enablement.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants