Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ stages:
validate_supported_configurations_local_file:
extends: .validate_supported_configurations_local_file
variables:
LOCAL_JSON_PATH: "packages/dd-trace/src/supported-configurations.json"
LOCAL_JSON_PATH: "packages/dd-trace/src/config/supported-configurations.json"

update_central_configurations_version_range:
extends: .update_central_configurations_version_range
variables:
LOCAL_REPO_NAME: "dd-trace-js"
LOCAL_JSON_PATH: "packages/dd-trace/src/supported-configurations.json"
LOCAL_JSON_PATH: "packages/dd-trace/src/config/supported-configurations.json"
LANGUAGE_NAME: "nodejs"
MULTIPLE_RELEASE_LINES: "true"

Expand Down
8 changes: 4 additions & 4 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,13 @@ Avoid try/catch in hot paths - validate inputs early

## Adding New Configuration Options

1. **Add default value** in `packages/dd-trace/src/config_defaults.js`
2. **Map environment variable** in `packages/dd-trace/src/config.js` (`#applyEnvironment()` method)
1. **Add default value** in `packages/dd-trace/src/config/defaults.js`
2. **Map environment variable** in `packages/dd-trace/src/config/index.js` (`#applyEnvironment()` method)
3. **Add TypeScript definitions** in `index.d.ts`
4. **Add to telemetry name mapping** (if applicable) in `packages/dd-trace/src/telemetry/telemetry.js`
5. **Update** `packages/dd-trace/src/supported-configurations.json`
5. **Update** `packages/dd-trace/src/config/supported-configurations.json`
6. **Document** in `docs/API.md` (non-internal/experimental options only)
7. **Add tests** in `packages/dd-trace/test/config.spec.js`
7. **Add tests** in `packages/dd-trace/test/config/index.spec.js`

**Naming Convention:** Size/time-based config options should have unit suffixes (e.g., `timeoutMs`, `maxBytes`, `intervalSeconds`).

Expand Down
4 changes: 2 additions & 2 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@
# API SDK
/packages/dd-trace/src/telemetry/ @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/test/telemetry/ @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/src/config.js @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/test/config.spec.js @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/src/config/ @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/test/config/ @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/src/opentelemetry/ @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/test/opentelemetry/ @DataDog/apm-sdk-capabilities-js
/packages/dd-trace/src/opentracing/ @DataDog/apm-sdk-capabilities-js
Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,13 @@ Never use the type `any` - be specific.

To add a new configuration option:

1. **Add the default value** in `packages/dd-trace/src/config_defaults.js`
2. **Map the environment variable** in `packages/dd-trace/src/config.js` (add to destructuring in `#applyEnvironment()` method)
1. **Add the default value** in `packages/dd-trace/src/config/defaults.js`
2. **Map the environment variable** in `packages/dd-trace/src/config/index.js` (add to destructuring in `#applyEnvironment()` method)
3. **Add TypeScript definitions** in `index.d.ts`
4. **Add to telemetry name mapping** (if applicable) in `packages/dd-trace/src/telemetry/telemetry.js`
5. **Update supported configurations** in `packages/dd-trace/src/supported-configurations.json`
5. **Update supported configurations** in `packages/dd-trace/src/config/supported-configurations.json`
6. **Document the option** in `docs/API.md` (for non-internal/experimental options)
7. **Add tests** in `packages/dd-trace/test/config.spec.js`
7. **Add tests** in `packages/dd-trace/test/config/index.spec.js`

**Naming Convention:** Size/time-based config options should have unit suffixes (e.g., `timeoutMs`, `maxBytes`, `intervalSeconds`).

Expand Down
2 changes: 1 addition & 1 deletion benchmark/sirun/exporting-pipeline/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const SpanProcessor = require('../../../packages/dd-trace/src/span_processor')
const Exporter = require('../../../packages/dd-trace/src/exporters/agent/index')
const PrioritySampler = require('../../../packages/dd-trace/src/priority_sampler')
const id = require('../../../packages/dd-trace/src/id')
const defaults = require('../../../packages/dd-trace/src/config_defaults')
const defaults = require('../../../packages/dd-trace/src/config/defaults')

const config = {
url: `http://${defaults.hostname}:${defaults.port}`,
Expand Down
2 changes: 1 addition & 1 deletion benchmark/sirun/statsd.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const dgram = require('dgram')
const defaults = require('../../../packages/dd-trace/src/config_defaults')
const defaults = require('../../packages/dd-trace/src/config/defaults')
const port = process.env.SIRUN_STATSD_PORT || defaults['dogstatsd.port']

class StatsD {
Expand Down
2 changes: 1 addition & 1 deletion ci/init.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
const tracer = require('../packages/dd-trace')
const { isTrue, isFalse } = require('../packages/dd-trace/src/util')
const log = require('../packages/dd-trace/src/log')
const { getEnvironmentVariable } = require('../packages/dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../packages/dd-trace/src/config/helper')

const PACKAGE_MANAGERS = ['npm', 'yarn', 'pnpm']
const DEFAULT_FLUSH_INTERVAL = 5000
Expand Down
2 changes: 1 addition & 1 deletion eslint-rules/eslint-env-aliases.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const __filename = fileURLToPath(import.meta.url)

const supportedConfigsPath = path.resolve(
path.dirname(__filename),
'../packages/dd-trace/src/supported-configurations.json'
'../packages/dd-trace/src/config/supported-configurations.json'
)
const { aliases } = JSON.parse(fs.readFileSync(supportedConfigsPath, 'utf8'))

Expand Down
2 changes: 1 addition & 1 deletion loader-hook.mjs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as iitm from 'import-in-the-middle/hook.mjs'
import regexpEscapeModule from './vendor/dist/escape-string-regexp/index.js'
import hooks from './packages/datadog-instrumentations/src/helpers/hooks.js'
import configHelper from './packages/dd-trace/src/config-helper.js'
import configHelper from './packages/dd-trace/src/config/helper.js'
import * as rewriterLoader from './packages/datadog-instrumentations/src/helpers/rewriter/loader.mjs'
import { isRelativeRequire } from './packages/datadog-instrumentations/src/helpers/shared-utils.js'

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-instrumentations/src/cucumber.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const { createCoverageMap } = require('../../../vendor/dist/istanbul-lib-coverage')
const shimmer = require('../../datadog-shimmer')
const log = require('../../dd-trace/src/log')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')
const {
getCoveredFilenamesFromCoverage,
resetCoverage,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const requirePackageJson = require('../../../dd-trace/src/require-package-json')
const log = require('../../../dd-trace/src/log')
const telemetry = require('../../../dd-trace/src/guardrails/telemetry')
const { isInServerlessEnvironment } = require('../../../dd-trace/src/serverless')
const { getEnvironmentVariables } = require('../../../dd-trace/src/config-helper')
const { getEnvironmentVariables } = require('../../../dd-trace/src/config/helper')
const checkRequireCache = require('./check-require-cache')
const Hook = require('./hook')
const { isRelativeRequire } = require('./shared-utils')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const { readFileSync } = require('fs')
const { join } = require('path')
const semifies = require('../../../../../vendor/dist/semifies')
const log = require('../../../../dd-trace/src/log')
const { getEnvironmentVariable } = require('../../../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../../../dd-trace/src/config/helper')
const transforms = require('./transforms')
const { generate, parse, traverse } = require('./compiler')
const instrumentations = require('./instrumentations')
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-instrumentations/src/mocha.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

if (getEnvironmentVariable('MOCHA_WORKER_ID')) {
require('./mocha/worker')
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-instrumentations/src/mocha/main.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const { addHook, channel } = require('../helpers/instrument')
const shimmer = require('../../../datadog-shimmer')
const { isMarkedAsUnskippable } = require('../../../datadog-plugin-jest/src/util')
const log = require('../../../dd-trace/src/log')
const { getEnvironmentVariable } = require('../../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../../dd-trace/src/config/helper')
const {
getTestSuitePath,
MOCHA_WORKER_TRACE_PAYLOAD_CODE,
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-instrumentations/src/nyc.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const shimmer = require('../../datadog-shimmer')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')
const { addHook, channel } = require('./helpers/instrument')

const codeCoverageWrapCh = channel('ci:nyc:wrap')
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-instrumentations/src/otel-sdk-trace.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const shimmer = require('../../datadog-shimmer')
const tracer = require('../../dd-trace')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')
const { addHook } = require('./helpers/instrument')

const otelSdkEnabled = getEnvironmentVariable('DD_TRACE_OTEL_ENABLED') ||
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-instrumentations/src/playwright.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const {
const log = require('../../dd-trace/src/log')
const {
getEnvironmentVariable
} = require('../../dd-trace/src/config-helper')
} = require('../../dd-trace/src/config/helper')
const { DD_MAJOR } = require('../../../version')
const { addHook, channel } = require('./helpers/instrument')

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-instrumentations/src/selenium.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const shimmer = require('../../datadog-shimmer')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')
const { addHook, channel } = require('./helpers/instrument')

const ciSeleniumDriverGetStartCh = channel('ci:selenium:driver:get')
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-aws-sdk/src/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const ClientPlugin = require('../../dd-trace/src/plugins/client')
const { storage } = require('../../datadog-core')
const { isTrue } = require('../../dd-trace/src/util')
const { tagsFromRequest, tagsFromResponse } = require('../../dd-trace/src/payload-tagging')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

class BaseAwsSdkPlugin extends ClientPlugin {
static id = 'aws'
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-azure-event-hubs/src/producer.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')
const ProducerPlugin = require('../../dd-trace/src/plugins/producer')

const spanContexts = new WeakMap()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')
const ProducerPlugin = require('../../dd-trace/src/plugins/producer')
const spanContexts = new WeakMap()

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-cucumber/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const CiPlugin = require('../../dd-trace/src/plugins/ci_plugin')
const { storage } = require('../../datadog-core')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

const {
TEST_SKIP_REASON,
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-cypress/src/cypress-plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const {
} = require('../../dd-trace/src/plugins/util/test')
const { isMarkedAsUnskippable } = require('../../datadog-plugin-jest/src/util')
const { ORIGIN_KEY, COMPONENT } = require('../../dd-trace/src/constants')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')
const { appClosing: appClosingTelemetry } = require('../../dd-trace/src/telemetry')
const log = require('../../dd-trace/src/log')

Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-dd-trace-api/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const Plugin = require('../../dd-trace/src/plugins/plugin')
const telemetryMetrics = require('../../dd-trace/src/telemetry/metrics')
const apiMetrics = telemetryMetrics.manager.namespace('tracers')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

// api ==> here
const objectMap = new WeakMap()
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-jest/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const CiPlugin = require('../../dd-trace/src/plugins/ci_plugin')
const { storage } = require('../../datadog-core')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

const {
TEST_STATUS,
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-mocha/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const CiPlugin = require('../../dd-trace/src/plugins/ci_plugin')
const { storage } = require('../../datadog-core')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

const {
TEST_STATUS,
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-mongodb-core/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const { isTrue } = require('../../dd-trace/src/util')
const DatabasePlugin = require('../../dd-trace/src/plugins/database')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

class MongodbCorePlugin extends DatabasePlugin {
static id = 'mongodb-core'
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-playwright/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const { storage } = require('../../datadog-core')
const id = require('../../dd-trace/src/id')
const CiPlugin = require('../../dd-trace/src/plugins/ci_plugin')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

const {
TEST_STATUS,
Expand Down
2 changes: 1 addition & 1 deletion packages/datadog-plugin-vitest/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const CiPlugin = require('../../dd-trace/src/plugins/ci_plugin')
const { storage } = require('../../datadog-core')
const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable } = require('../../dd-trace/src/config/helper')

const {
TEST_STATUS,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const { getName } = require('../telemetry/verbosity')
const telemetry = require('../telemetry')
const log = require('../../../log')
const orchestrionConfig = require('../../../../../datadog-instrumentations/src/orchestrion-config')
const { getEnvironmentVariable } = require('../../../config-helper')
const { getEnvironmentVariable } = require('../../../config/helper')
const { LOG_MESSAGE, REWRITTEN_MESSAGE } = require('./constants')
const { incrementTelemetryIfNeeded } = require('./rewriter-telemetry')
const { csiMethods } = require('./csi-methods')
Expand Down
2 changes: 1 addition & 1 deletion packages/dd-trace/src/azure_metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// Modeled after https://github.com/DataDog/libdatadog/blob/f3994857a59bb5679a65967138c5a3aec418a65f/ddcommon/src/azure_app_services.rs

const os = require('os')
const { getEnvironmentVariable, getEnvironmentVariables } = require('../../dd-trace/src/config-helper')
const { getEnvironmentVariable, getEnvironmentVariables } = require('../../dd-trace/src/config/helper')
const { getIsAzureFunction, getIsFlexConsumptionAzureFunction } = require('./serverless')

function extractSubscriptionID (ownerName) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const { join } = require('path')
const { Worker, threadId: parentThreadId } = require('worker_threads')
const { randomUUID } = require('crypto')
const log = require('../../log')
const { getEnvironmentVariables } = require('../../config-helper')
const { getEnvironmentVariables } = require('../../config/helper')
const getDebuggerConfig = require('../../debugger/config')

const probeIdToResolveBreakpointSet = new Map()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const request = require('../../exporters/common/request')
const id = require('../../id')
const log = require('../../log')
const { getEnvironmentVariable } = require('../../config-helper')
const { getEnvironmentVariable } = require('../../config/helper')

const {
incrementCountMetric,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const request = require('../../../exporters/common/request')
const log = require('../../../log')
const { safeJSONStringify } = require('../../../exporters/common/util')
const { getEnvironmentVariable } = require('../../../config-helper')
const { getEnvironmentVariable } = require('../../../config/helper')

const { CoverageCIVisibilityEncoder } = require('../../../encode/coverage-ci-visibility')
const BaseWriter = require('../../../exporters/common/writer')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const request = require('../../../exporters/common/request')
const log = require('../../../log')
const { safeJSONStringify } = require('../../../exporters/common/util')
const { JSONEncoder } = require('../../encode/json-encoder')
const { getEnvironmentVariable } = require('../../../config-helper')
const { getEnvironmentVariable } = require('../../../config/helper')

const BaseWriter = require('../../../exporters/common/writer')

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
const request = require('../../../exporters/common/request')
const { safeJSONStringify } = require('../../../exporters/common/util')
const log = require('../../../log')
const { getEnvironmentVariable } = require('../../../config-helper')
const { getEnvironmentVariable } = require('../../../config/helper')

const { AgentlessCiVisibilityEncoder } = require('../../../encode/agentless-ci-visibility')
const BaseWriter = require('../../../exporters/common/writer')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const path = require('path')

const FormData = require('../../../exporters/common/form-data')
const request = require('../../../exporters/common/request')
const { getEnvironmentVariable } = require('../../../config-helper')
const { getEnvironmentVariable } = require('../../../config/helper')

const log = require('../../../log')
const { isFalse } = require('../../../util')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const {
VITEST_WORKER_TRACE_PAYLOAD_CODE,
VITEST_WORKER_LOGS_PAYLOAD_CODE
} = require('../../../plugins/util/test')
const { getEnvironmentVariable } = require('../../../config-helper')
const { getEnvironmentVariable } = require('../../../config/helper')
const Writer = require('./writer')

function getInterprocessTraceCode () {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'
const { JSONEncoder } = require('../../encode/json-encoder')
const { getEnvironmentVariable } = require('../../../config-helper')
const { getEnvironmentVariable } = require('../../../config/helper')
const log = require('../../../log')
const {
VITEST_WORKER_TRACE_PAYLOAD_CODE,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const request = require('../../exporters/common/request')
const log = require('../../log')
const { getEnvironmentVariable } = require('../../config-helper')
const { getEnvironmentVariable } = require('../../config/helper')
const {
incrementCountMetric,
distributionMetric,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const Plugin = require('../../plugins/plugin')
const log = require('../../log')
const { getEnvironmentVariable } = require('../../config-helper')
const { getEnvironmentVariable } = require('../../config/helper')

function getWinstonLogSubmissionParameters (config) {
const { site, service } = config
Expand Down
Loading
Loading