Fix build on macos (probs with case insensitivity)#3549
Fix build on macos (probs with case insensitivity)#3549cataphract wants to merge 1 commit intomasterfrom
Conversation
864dd92 to
f12de2b
Compare
Benchmarks [ profiler ]Benchmark execution time: 2025-12-24 14:51:51 Comparing candidate commit efef243 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 24 metrics, 6 unstable metrics. scenario:php-profiler-timeline-memory-control
scenario:php-profiler-timeline-memory-with-profiler
scenario:php-profiler-timeline-memory-with-profiler-and-timeline
|
f12de2b to
cbce4e9
Compare
cbce4e9 to
efef243
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3549 +/- ##
==========================================
+ Coverage 61.64% 61.65% +0.01%
==========================================
Files 139 139
Lines 13051 13051
Branches 1712 1712
==========================================
+ Hits 8045 8047 +2
+ Misses 4241 4238 -3
- Partials 765 766 +1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-12-24 15:47:50 Comparing candidate commit efef243 in PR branch Found 2 performance improvements and 7 performance regressions! Performance is the same for 184 metrics, 1 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache
scenario:SamplingRuleMatchingBench/benchRegexMatching1
scenario:SamplingRuleMatchingBench/benchRegexMatching2
scenario:SamplingRuleMatchingBench/benchRegexMatching3
scenario:SamplingRuleMatchingBench/benchRegexMatching4
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceSerializationBench/benchSerializeTrace
|
|
I'm going on a less intrusive route: creating a directory with symlinks to the relevant subdirectories and using that as the include path |
Description
Having a file named
VERSIONin the root makes it difficult to use the root as an include path (and from there have more meaningful include paths, like#include <components-rs/telemetry.h>instead of possibly conflicting#include <telemetry.h>.This is because on mac os,
#include <version>, which sometimes comes from other libraries/stdlib, will try to include this file.Rather than trying to mess with the exact order of the components of the include path (I think this is even complicated because -I has even priority over -isystem iirc), rename
VERSION.Reviewer checklist