-
Notifications
You must be signed in to change notification settings - Fork 15
feat(library-config): support windows memory file #1262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implement a memfd-like for Windows to store in-memory the tracer configuration. It relies on Windows API to create in-memory file that can be shared and accessed by other processes.
BenchmarksComparisonBenchmark execution time: 2025-10-09 09:11:49 Comparing candidate commit 57a4e3d in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/378282246310005
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 71.85% 71.80% -0.05%
==========================================
Files 356 356
Lines 56685 56692 +7
==========================================
- Hits 40731 40709 -22
- Misses 15954 15983 +29
🚀 New features to boost your workflow:
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
What does this PR do?
Implement a memfd-like for Windows to store in-memory the tracer configuration. It relies on Windows API to create in-memory file that can be shared and accessed by other processes.
Main difference with the linux implementation is the anonymous file format:
datadog-tracer-info-<PID>
.Motivation
@raphaelgavache
How to test the change?
Boot a windows VM. Compile this code:
writer
reader
Expected result:
