Skip to content

[SVLS-7934] Log error details when trace request fails #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 2 commits into from
Dec 11, 2025
Merged

[SVLS-7934] Log error details when trace request fails #1392

dd-mergequeue merged 2 commits into from
Dec 11, 2025

Conversation

@lym953
Copy link
Contributor

@lym953 lym953 commented Dec 10, 2025 •
edited
Loading

What does this PR do?

When the request to send traces fails, log more details of the error.

Motivation

Right now the error message is too general, making it hard for customers and our engineers to debug network errors.
Example:

Additional Notes

How to test the change?

Deploy an AWS Lambda function in VPC. The Lambda uses Datadog extension, which uses this library.

Result
Before:

DD_EXTENSION | DEBUG | Request failed with error error=Network error: client error (Connect) attempt=1 max_retries=1

After:

DD_EXTENSION | DEBUG | Request failed with error error=Network(hyper_util::client::legacy::Error(Connect, Custom { kind: Other, error: "unsuccessful tunnel (HTTP/1.1 502 Bad)" })) attempt=1 max_retries=1

@lym953 lym953 requested review from a team as code owners December 10, 2025 00:00
@lym953 lym953 changed the title Log error details when trace request fails [SVLS-7934] Log error details when trace request fails Dec 10, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-12-11 17:11:30

Comparing candidate commit a5f62e4 in PR branch yiming.luo/log-trace-send-error with baseline commit c9ff30b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.601ms 10.629ms ± 0.015ms 10.627ms ± 0.009ms 10.638ms 10.655ms 10.671ms 10.681ms 0.51% 0.771 0.670 0.14% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.627ms; 10.631ms] or [-0.019%; +0.019%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 84.951µs 85.291µs ± 0.222µs 85.287µs ± 0.051µs 85.326µs 85.431µs 85.576µs 88.061µs 3.25% 9.770 119.837 0.26% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [85.260µs; 85.321µs] or [-0.036%; +0.036%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 187.475ns 190.173ns ± 1.883ns 189.884ns ± 1.248ns 191.089ns 193.730ns 195.659ns 196.323ns 3.39% 0.894 0.431 0.99% 0.133ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [189.912ns; 190.434ns] or [-0.137%; +0.137%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 161.259µs 162.256µs ± 0.358µs 162.240µs ± 0.143µs 162.370µs 162.606µs 163.026µs 165.812µs 2.20% 5.170 48.672 0.22% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [162.206µs; 162.306µs] or [-0.031%; +0.031%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 145.144µs 147.057µs ± 1.861µs 146.730µs ± 0.574µs 147.380µs 148.851µs 154.065µs 165.831µs 13.02% 6.335 55.022 1.26% 0.132µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.799µs; 147.315µs] or [-0.175%; +0.175%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.676ms 9.975ms ± 0.081ms 9.982ms ± 0.034ms 10.012ms 10.079ms 10.165ms 10.268ms 2.86% -0.588 2.922 0.81% 0.006ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.964ms; 9.986ms] or [-0.112%; +0.112%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 525.247µs 525.796µs ± 0.565µs 525.669µs ± 0.158µs 525.836µs 526.689µs 528.072µs 530.768µs 0.97% 4.798 32.905 0.11% 0.040µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [525.718µs; 525.874µs] or [-0.015%; +0.015%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.404µs 2.427µs ± 0.020µs 2.423µs ± 0.007µs 2.430µs 2.480µs 2.487µs 2.580µs 6.48% 3.450 17.225 0.84% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.424µs; 2.430µs] or [-0.116%; +0.116%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.896µs 3.913µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.918µs 3.920µs 3.922µs 0.24% -0.482 8.448 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 254992938.312op/s 255581615.759op/s ± 174838.200op/s 255595616.535op/s ± 87250.282op/s 255683435.899op/s 255777880.735op/s 255865451.470op/s 256705528.027op/s 0.43% 0.504 8.564 0.07% 12362.928op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 80.355µs 82.011µs ± 0.698µs 82.069µs ± 0.480µs 82.484µs 83.113µs 83.358µs 83.559µs 1.82% -0.250 -0.498 0.85% 0.049µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 11967524.226op/s 12194400.738op/s ± 104055.330op/s 12184852.536op/s ± 71707.078op/s 12264464.711op/s 12384481.733op/s 12420838.266op/s 12444719.645op/s 2.13% 0.286 -0.484 0.85% 7357.823op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 74.421µs 75.081µs ± 0.212µs 75.046µs ± 0.114µs 75.198µs 75.439µs 75.582µs 76.005µs 1.28% 0.598 2.058 0.28% 0.015µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13157110.530op/s 13319053.160op/s ± 37476.499op/s 13325229.477op/s ± 20178.974op/s 13342262.360op/s 13366280.110op/s 13407276.593op/s 13437040.546op/s 0.84% -0.567 2.001 0.28% 2649.989op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.895µs 3.913µs ± 0.004µs 3.913µs ± 0.002µs 3.915µs 3.918µs 3.930µs 3.939µs 0.66% 2.126 14.430 0.10% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 253896128.471op/s 255546616.786op/s ± 251879.914op/s 255578850.855op/s ± 113032.414op/s 255681479.305op/s 255788196.168op/s 255884844.198op/s 256717491.239op/s 0.45% -2.091 14.287 0.10% 17810.600op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 71.473µs 72.131µs ± 0.195µs 72.134µs ± 0.115µs 72.255µs 72.437µs 72.504µs 72.608µs 0.66% -0.506 0.809 0.27% 0.014µs 1 200
credit_card/is_card_number/378282246310005 throughput 13772621.159op/s 13863859.231op/s ± 37441.278op/s 13862999.655op/s ± 22054.805op/s 13881699.790op/s 13920708.581op/s 13977501.043op/s 13991226.997op/s 0.92% 0.526 0.847 0.27% 2647.498op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 52.144µs 52.205µs ± 0.029µs 52.205µs ± 0.019µs 52.223µs 52.255µs 52.290µs 52.311µs 0.20% 0.568 0.879 0.05% 0.002µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 19116259.314op/s 19155135.044op/s ± 10538.951op/s 19155283.905op/s ± 7010.799op/s 19162772.004op/s 19172055.196op/s 19175123.461op/s 19177571.830op/s 0.12% -0.564 0.870 0.05% 745.216op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 5.705µs 5.859µs ± 0.065µs 5.865µs ± 0.042µs 5.902µs 5.961µs 5.994µs 6.036µs 2.92% -0.119 -0.471 1.10% 0.005µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165678046.404op/s 170706591.209op/s ± 1884306.390op/s 170514943.246op/s ± 1216259.088op/s 172317033.127op/s 173806595.869op/s 175075756.174op/s 175275799.507op/s 2.79% 0.169 -0.475 1.10% 133240.583op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.891µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.914µs 3.917µs 3.918µs 3.921µs 0.23% -2.058 16.654 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255010670.341op/s 255575977.968op/s ± 184133.728op/s 255585546.640op/s ± 106131.612op/s 255682879.616op/s 255817356.501op/s 255859100.837op/s 257007992.587op/s 0.56% 2.089 16.934 0.07% 13020.221op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 64.226µs 64.542µs ± 0.220µs 64.481µs ± 0.120µs 64.648µs 65.026µs 65.187µs 65.270µs 1.22% 1.109 0.871 0.34% 0.016µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15320966.891op/s 15493856.589op/s ± 52734.076op/s 15508379.611op/s ± 28869.459op/s 15531705.926op/s 15556793.728op/s 15565425.649op/s 15570041.683op/s 0.40% -1.093 0.824 0.34% 3728.862op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 57.364µs 57.553µs ± 0.130µs 57.525µs ± 0.056µs 57.592µs 57.815µs 58.033µs 58.170µs 1.12% 2.009 5.209 0.22% 0.009µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 17190912.093op/s 17375377.393op/s ± 38927.831op/s 17383815.668op/s ± 16926.413op/s 17399003.472op/s 17417339.136op/s 17428631.970op/s 17432487.183op/s 0.28% -1.987 5.101 0.22% 2752.613op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.895µs 3.913µs ± 0.002µs 3.913µs ± 0.002µs 3.914µs 3.916µs 3.919µs 3.920µs 0.18% -1.399 10.731 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255127427.466op/s 255582149.578op/s ± 162276.794op/s 255589444.157op/s ± 103126.098op/s 255691505.598op/s 255795930.735op/s 255881631.301op/s 256716898.209op/s 0.44% 1.420 10.886 0.06% 11474.702op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 54.604µs 54.858µs ± 0.200µs 54.802µs ± 0.098µs 54.939µs 55.260µs 55.501µs 55.866µs 1.94% 1.683 3.794 0.36% 0.014µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 17899983.694op/s 18229057.346op/s ± 66126.514op/s 18247541.057op/s ± 32624.050op/s 18274867.951op/s 18299645.449op/s 18312097.246op/s 18313592.348op/s 0.36% -1.652 3.621 0.36% 4675.851op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 52.125µs 52.208µs ± 0.039µs 52.204µs ± 0.022µs 52.228µs 52.278µs 52.322µs 52.380µs 0.34% 0.953 1.932 0.07% 0.003µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 19091163.188op/s 19154015.171op/s ± 14183.787op/s 19155451.130op/s ± 8239.426op/s 19162885.325op/s 19174512.185op/s 19178284.333op/s 19184581.352op/s 0.15% -0.946 1.909 0.07% 1002.945op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 5.725µs 5.887µs ± 0.068µs 5.892µs ± 0.042µs 5.933µs 6.000µs 6.035µs 6.036µs 2.44% -0.185 -0.232 1.14% 0.005µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165674130.666op/s 169875939.760op/s ± 1952478.905op/s 169708558.133op/s ± 1197060.192op/s 171225574.531op/s 173397451.029op/s 174530291.677op/s 174672148.485op/s 2.92% 0.244 -0.205 1.15% 138061.107op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255557384.866op/s; 255605846.652op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [81.914µs; 82.108µs] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12179979.670op/s; 12208821.806op/s] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [75.052µs; 75.110µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/ 378282246310005 throughput [13313859.278op/s; 13324247.043op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.914µs] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/37828224631 throughput [255511708.653op/s; 255581524.920op/s] or [-0.014%; +0.014%] None None None
credit_card/is_card_number/378282246310005 execution_time [72.104µs; 72.157µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/378282246310005 throughput [13858670.230op/s; 13869048.232op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [52.201µs; 52.209µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [19153674.447op/s; 19156595.641op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/x371413321323331 execution_time [5.850µs; 5.868µs] or [-0.153%; +0.153%] None None None
credit_card/is_card_number/x371413321323331 throughput [170445444.465op/s; 170967737.952op/s] or [-0.153%; +0.153%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255550458.804op/s; 255601497.131op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [64.512µs; 64.573µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15486548.153op/s; 15501165.025op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [57.535µs; 57.571µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [17369982.370op/s; 17380772.416op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.912µs; 3.913µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255559659.575op/s; 255604639.581op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [54.830µs; 54.886µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [18219892.847op/s; 18238221.845op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [52.203µs; 52.214µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [19152049.434op/s; 19155980.907op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [5.878µs; 5.897µs] or [-0.159%; +0.159%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [169605344.962op/s; 170146534.559op/s] or [-0.159%; +0.159%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.223µs 3.199µs ± 1.445µs 3.025µs ± 0.027µs 3.049µs 3.407µs 13.822µs 15.453µs 410.80% 7.553 57.599 45.05% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [2.999µs; 3.399µs] or [-6.259%; +6.259%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 14.202ms 14.273ms ± 0.035ms 14.269ms ± 0.020ms 14.288ms 14.324ms 14.394ms 14.458ms 1.33% 1.684 5.598 0.24% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [14.268ms; 14.278ms] or [-0.034%; +0.034%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.024µs 5.091µs ± 0.050µs 5.074µs ± 0.033µs 5.138µs 5.186µs 5.188µs 5.195µs 2.38% 0.665 -0.993 0.98% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.084µs; 5.098µs] or [-0.137%; +0.137%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 34.421µs 35.003µs ± 0.936µs 34.584µs ± 0.081µs 34.708µs 36.980µs 37.021µs 38.661µs 11.79% 1.759 1.461 2.67% 0.066µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [34.874µs; 35.133µs] or [-0.371%; +0.371%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 61.568ms 62.185ms ± 2.242ms 61.931ms ± 0.137ms 62.016ms 62.310ms 72.937ms 83.695ms 35.14% 8.547 74.133 3.60% 0.159ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.874ms; 62.496ms] or [-0.500%; +0.500%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 206.161µs 210.193µs ± 3.108µs 212.633µs ± 0.613µs 212.893µs 213.270µs 213.569µs 213.750µs 0.53% -0.273 -1.885 1.48% 0.220µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4678366.122op/s 4758582.121op/s ± 70658.562op/s 4702935.579op/s ± 13526.239op/s 4839855.082op/s 4845753.828op/s 4847858.739op/s 4850566.500op/s 3.14% 0.274 -1.884 1.48% 4996.315op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.586µs 18.660µs ± 0.050µs 18.647µs ± 0.022µs 18.675µs 18.741µs 18.848µs 18.920µs 1.47% 2.174 6.628 0.26% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52853080.976op/s 53590041.313op/s ± 141548.598op/s 53629014.030op/s ± 62736.997op/s 53671628.336op/s 53750691.358op/s 53799061.045op/s 53804723.508op/s 0.33% -2.144 6.463 0.26% 10008.997op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.715µs 10.798µs ± 0.034µs 10.795µs ± 0.019µs 10.815µs 10.862µs 10.903µs 10.932µs 1.27% 0.895 1.745 0.31% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 91477572.283op/s 92609036.625op/s ± 286715.810op/s 92635675.968op/s ± 165338.558op/s 92796067.714op/s 92997966.576op/s 93138540.638op/s 93330236.574op/s 0.75% -0.868 1.671 0.31% 20273.869op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [209.762µs; 210.623µs] or [-0.205%; +0.205%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4748789.524op/s; 4768374.718op/s] or [-0.206%; +0.206%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.653µs; 18.667µs] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53570424.039op/s; 53609658.587op/s] or [-0.037%; +0.037%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.794µs; 10.803µs] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/good throughput [92569300.571op/s; 92648772.678op/s] or [-0.043%; +0.043%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 533.099µs 534.004µs ± 0.957µs 533.879µs ± 0.242µs 534.187µs 534.673µs 535.056µs 546.308µs 2.33% 10.726 135.298 0.18% 0.068µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1830470.442op/s 1872652.018op/s ± 3291.898op/s 1873083.292op/s ± 850.075op/s 1873864.452op/s 1874882.113op/s 1875251.026op/s 1875824.397op/s 0.15% -10.606 133.238 0.18% 232.772op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 381.508µs 382.069µs ± 0.278µs 382.089µs ± 0.198µs 382.262µs 382.562µs 382.703µs 382.770µs 0.18% 0.104 -0.478 0.07% 0.020µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2612535.833op/s 2617326.981op/s ± 1902.077op/s 2617188.602op/s ± 1356.830op/s 2618821.929op/s 2620295.084op/s 2621093.318op/s 2621180.299op/s 0.15% -0.101 -0.480 0.07% 134.497op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.230µs 189.849µs ± 0.596µs 189.811µs ± 0.112µs 189.908µs 190.124µs 190.405µs 195.491µs 2.99% 8.202 74.411 0.31% 0.042µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5115312.925op/s 5267397.854op/s ± 16112.397op/s 5268408.529op/s ± 3117.197op/s 5271740.302op/s 5278987.707op/s 5284135.828op/s 5284580.772op/s 0.31% -8.116 73.373 0.31% 1139.319op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 36.829µs 36.928µs ± 0.096µs 36.919µs ± 0.028µs 36.947µs 37.009µs 37.027µs 38.133µs 3.29% 9.989 122.952 0.26% 0.007µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26223861.518op/s 27080229.689op/s ± 68613.301op/s 27086334.779op/s ± 20561.643op/s 27106894.189op/s 27131121.390op/s 27146503.850op/s 27152781.439op/s 0.25% -9.793 119.680 0.25% 4851.693op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.928µs 45.142µs ± 0.145µs 45.146µs ± 0.131µs 45.253µs 45.383µs 45.419µs 45.425µs 0.62% 0.145 -1.187 0.32% 0.010µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 22014481.615op/s 22152786.882op/s ± 71146.921op/s 22150116.781op/s ± 63929.091op/s 22223437.692op/s 22250380.773op/s 22256190.445op/s 22257939.345op/s 0.49% -0.137 -1.192 0.32% 5030.847op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [533.871µs; 534.136µs] or [-0.025%; +0.025%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1872195.792op/s; 1873108.243op/s] or [-0.024%; +0.024%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [382.031µs; 382.108µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2617063.372op/s; 2617590.591op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [189.766µs; 189.931µs] or [-0.043%; +0.043%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5265164.831op/s; 5269630.878op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [36.914µs; 36.941µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [27070720.546op/s; 27089738.833op/s] or [-0.035%; +0.035%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.121µs; 45.162µs] or [-0.045%; +0.045%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22142926.603op/s; 22162647.161op/s] or [-0.045%; +0.045%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.781µs 26.040µs ± 9.725µs 18.547µs ± 0.616µs 34.485µs 43.557µs 44.325µs 72.072µs 288.59% 0.975 0.905 37.25% 0.688µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.692µs; 27.388µs] or [-5.176%; +5.176%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.977ms 3.983ms ± 0.008ms 3.981ms ± 0.001ms 3.982ms 3.987ms 4.009ms 4.068ms 2.20% 7.624 73.481 0.20% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.981ms; 3.984ms] or [-0.027%; +0.027%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz a5f62e4 1765471723 yiming.luo/log-trace-send-error
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 247.108ns 258.940ns ± 14.834ns 252.050ns ± 3.282ns 259.456ns 292.494ns 298.854ns 303.340ns 20.35% 1.563 1.069 5.71% 1.049ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [256.884ns; 260.996ns] or [-0.794%; +0.794%] None None None

Baseline

Omitted due to size.

tobz
tobz reviewed Dec 10, 2025
View reviewed changes
libdd-trace-utils/src/send_with_retry/mod.rs Outdated
attempt = request_attempt,
max_retries = retry_strategy.max_retries(),
"Request failed with error"
"Request failed with error: {e:?}."
Copy link
Member

@tobz tobz Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do this with an even smaller diff of just going from error = %e to error = ?e.

Copy link
Contributor

@ekump ekump Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller and better! The change as is is making the event less structured. We should really keep the error in the error field.

Copy link
Contributor Author

@lym953 lym953 Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Good to know this syntax!

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.14%. Comparing base (c9ff30b) to head (a5f62e4).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1392   +/-   ##
=======================================
  Coverage   71.13%   71.14%           
=======================================
  Files         403      403           
  Lines       64140    64140           
=======================================
+ Hits        45626    45630    +4     
+ Misses      18514    18510    -4
Components Coverage Δ
libdd-crashtracker 58.79% <ø> (+0.01%) ⬆️
libdd-crashtracker-ffi 16.74% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 85.81% <ø> (ø)
libdd-data-pipeline-ffi 76.59% <ø> (ø)
libdd-common 81.13% <ø> (ø)
libdd-common-ffi 74.96% <ø> (ø)
libdd-telemetry 59.95% <ø> (ø)
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.61% <ø> (ø)
libdd-profiling 80.45% <ø> (+0.03%) ⬆️
libdd-profiling-ffi 63.41% <ø> (ø)
datadog-sidecar 35.86% <ø> (ø)
datdog-sidecar-ffi 10.79% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 98.24% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 59.65% <ø> (ø)
libdd-trace-utils 89.88% <ø> (ø)
datadog-tracer-flare 63.49% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lym953
Copy link
Contributor Author

lym953 commented Dec 11, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-11 15:47:03 UTC ℹ️ Start processing command /merge

2025-12-11 15:47:11 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 34m (p90).

2025-12-11 16:11:43 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit e76b915:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@lym953 lym953 force-pushed the yiming.luo/log-trace-send-error branch from 63324d6 to a5f62e4 Compare December 11, 2025 16:54
@lym953
Copy link
Contributor Author

lym953 commented Dec 11, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-11 16:55:09 UTC ℹ️ Start processing command /merge

2025-12-11 16:55:18 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-11 17:20:49 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 35m (p90).

2025-12-11 17:45:18 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 983cf01:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@lym953
Copy link
Contributor Author

lym953 commented Dec 11, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 11, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-11 20:45:06 UTC ℹ️ Start processing command /merge

2025-12-11 20:45:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 34m (p90).

2025-12-11 21:10:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 928e65f into main Dec 11, 2025
38 checks passed
@dd-mergequeue dd-mergequeue bot deleted the yiming.luo/log-trace-send-error branch December 11, 2025 21:10
@lym953 lym953 mentioned this pull request Dec 23, 2025
Open
@lym953 lym953 mentioned this pull request Jan 12, 2026
Merged
@github-actions github-actions bot mentioned this pull request Jan 14, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobz tobz tobz left review comments

@ekump ekump ekump approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done mini-agent

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lym953 @codecov-commenter @tobz @ekump