Skip to content

refactor: simplify ProfileStatus encoding #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dd-mergequeue merged 2 commits into from
Dec 17, 2025
Merged

refactor: simplify ProfileStatus encoding #1416

dd-mergequeue merged 2 commits into from
Dec 17, 2025
+63 −68

Conversation

@morrisonlevi
Copy link
Contributor

@morrisonlevi morrisonlevi commented Dec 17, 2025

What does this PR do?

This simplifies ProfileStatus's internal encoding.

Motivation

I had a feeling it could be done, and when Daniel suggested something in a code review on another PR, it finally clicked.

Additional Notes

This would be a BC break except we haven't made any releases with the old encoding, so it's fine and not a BC break.

How to test the change?

Regular testing is fine.

@morrisonlevi morrisonlevi requested review from a team as code owners December 17, 2025 20:19
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.67%. Comparing base (379c66e) to head (23528d2).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1416   +/-   ##
=======================================
  Coverage   71.66%   71.67%           
=======================================
  Files         411      411           
  Lines       66069    66057   -12     
=======================================
- Hits        47349    47347    -2     
+ Misses      18720    18710   -10
Components Coverage Δ
libdd-crashtracker 58.99% <ø> (+0.07%) ⬆️
libdd-crashtracker-ffi 16.74% <ø> (ø)
libdd-alloc 98.73% <ø> (ø)
libdd-data-pipeline 86.62% <ø> (ø)
libdd-data-pipeline-ffi 81.08% <ø> (ø)
libdd-common 81.33% <ø> (ø)
libdd-common-ffi 74.96% <ø> (ø)
libdd-telemetry 59.95% <ø> (ø)
libdd-telemetry-ffi 21.17% <ø> (ø)
libdd-dogstatsd-client 83.75% <ø> (ø)
datadog-ipc 82.61% <ø> (ø)
libdd-profiling 82.36% <94.73%> (+0.02%) ⬆️
libdd-profiling-ffi 70.99% <94.73%> (+0.02%) ⬆️
datadog-sidecar 36.22% <ø> (ø)
datdog-sidecar-ffi 12.62% <ø> (ø)
spawn-worker 55.18% <ø> (ø)
libdd-tinybytes 92.44% <ø> (ø)
libdd-trace-normalization 82.33% <ø> (ø)
libdd-trace-obfuscation 94.17% <ø> (ø)
libdd-trace-protobuf 61.18% <ø> (ø)
libdd-trace-utils 90.07% <ø> (ø)
datadog-tracer-flare 63.49% <ø> (ø)
libdd-log 75.57% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2025 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-12-17 21:28:15

Comparing candidate commit 23528d2 in PR branch levi/refactor-profilestatus with baseline commit 379c66e in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 56 metrics, 2 unstable metrics.

scenario:ip_address/quantize_peer_ip_address_benchmark

  • 🟥 execution_time [+254.364ns; +267.918ns] or [+5.033%; +5.301%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching serializing traces from their internal representation to msgpack execution_time 13.887ms 13.920ms ± 0.026ms 13.916ms ± 0.008ms 13.924ms 13.951ms 14.014ms 14.115ms 1.43% 3.594 18.617 0.19% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching serializing traces from their internal representation to msgpack execution_time [13.916ms; 13.923ms] or [-0.026%; +0.026%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sdk_test_data/rules-based execution_time 144.579µs 146.519µs ± 1.543µs 146.222µs ± 0.456µs 146.730µs 148.240µs 152.843µs 159.185µs 8.87% 4.478 28.125 1.05% 0.109µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sdk_test_data/rules-based execution_time [146.305µs; 146.733µs] or [-0.146%; +0.146%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.080ms 60.495ms ± 1.952ms 60.251ms ± 0.063ms 60.313ms 60.560ms 70.954ms 82.075ms 36.22% 9.050 86.377 3.22% 0.138ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [60.224ms; 60.765ms] or [-0.447%; +0.447%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 89.833µs 90.244µs ± 0.190µs 90.203µs ± 0.096µs 90.325µs 90.579µs 90.984µs 91.065µs 0.96% 1.577 3.944 0.21% 0.013µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [90.217µs; 90.270µs] or [-0.029%; +0.029%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 160.887µs 161.414µs ± 0.291µs 161.354µs ± 0.157µs 161.548µs 161.913µs 162.318µs 163.192µs 1.14% 1.844 6.810 0.18% 0.021µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [161.373µs; 161.454µs] or [-0.025%; +0.025%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
single_flag_killswitch/rules-based execution_time 185.785ns 188.778ns ± 2.324ns 188.496ns ± 1.600ns 189.937ns 193.506ns 195.335ns 197.520ns 4.79% 0.950 0.822 1.23% 0.164ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
single_flag_killswitch/rules-based execution_time [188.456ns; 189.100ns] or [-0.171%; +0.171%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
receiver_entry_point/report/2597 execution_time 9.596ms 9.873ms ± 0.069ms 9.878ms ± 0.034ms 9.911ms 9.963ms 10.042ms 10.065ms 1.89% -0.952 3.417 0.70% 0.005ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
receiver_entry_point/report/2597 execution_time [9.864ms; 9.883ms] or [-0.097%; +0.097%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample_frames_x1000 execution_time 3.932ms 3.938ms ± 0.006ms 3.937ms ± 0.001ms 3.939ms 3.941ms 3.944ms 4.016ms 2.01% 11.333 145.858 0.15% 0.000ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample_frames_x1000 execution_time [3.937ms; 3.939ms] or [-0.021%; +0.021%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 246.778ns 257.566ns ± 12.175ns 251.641ns ± 3.898ns 259.412ns 284.160ns 290.022ns 292.408ns 16.20% 1.366 0.599 4.71% 0.861ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [255.879ns; 259.253ns] or [-0.655%; +0.655%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 3.895µs 3.911µs ± 0.003µs 3.911µs ± 0.002µs 3.913µs 3.915µs 3.916µs 3.917µs 0.16% -1.032 5.461 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 255270711.245op/s 255673422.394op/s ± 171823.632op/s 255670265.548op/s ± 108090.224op/s 255764273.562op/s 255933789.121op/s 256009146.918op/s 256715824.518op/s 0.41% 1.045 5.544 0.07% 12149.766op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 77.093µs 78.650µs ± 0.825µs 78.606µs ± 0.535µs 79.140µs 80.111µs 81.076µs 81.344µs 3.48% 0.560 0.329 1.05% 0.058µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 12293478.039op/s 12715909.215op/s ± 132691.612op/s 12721731.261op/s ± 86668.913op/s 12807771.727op/s 12924122.774op/s 12956042.483op/s 12971363.519op/s 1.96% -0.498 0.218 1.04% 9382.714op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 70.629µs 70.974µs ± 0.268µs 70.924µs ± 0.167µs 71.096µs 71.502µs 71.767µs 72.069µs 1.61% 1.070 0.924 0.38% 0.019µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 13875613.295op/s 14089895.542op/s ± 53066.125op/s 14099579.138op/s ± 33365.114op/s 14132143.561op/s 14148690.812op/s 14153721.370op/s 14158413.366op/s 0.42% -1.050 0.847 0.38% 3752.342op/s 1 200
credit_card/is_card_number/37828224631 execution_time 3.894µs 3.913µs ± 0.003µs 3.913µs ± 0.002µs 3.915µs 3.917µs 3.918µs 3.918µs 0.14% -1.355 8.061 0.07% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 255206012.957op/s 255557858.173op/s ± 187503.849op/s 255558663.395op/s ± 132167.063op/s 255691844.511op/s 255809619.397op/s 255890640.647op/s 256805444.758op/s 0.49% 1.373 8.203 0.07% 13258.524op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 67.424µs 67.716µs ± 0.304µs 67.570µs ± 0.094µs 67.826µs 68.321µs 68.646µs 69.231µs 2.46% 1.955 4.796 0.45% 0.021µs 1 200
credit_card/is_card_number/378282246310005 throughput 14444485.110op/s 14767871.578op/s ± 65720.507op/s 14799385.087op/s ± 20700.575op/s 14811830.580op/s 14822816.690op/s 14828957.425op/s 14831464.953op/s 0.22% -1.916 4.547 0.44% 4647.142op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 44.587µs 45.207µs ± 0.203µs 45.236µs ± 0.144µs 45.357µs 45.489µs 45.544µs 45.557µs 0.71% -0.690 0.304 0.45% 0.014µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 21950367.253op/s 22120760.996op/s ± 99473.847op/s 22106058.203op/s ± 70599.009op/s 22187943.644op/s 22302464.776op/s 22393297.530op/s 22427901.117op/s 1.46% 0.715 0.359 0.45% 7033.863op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.027µs 6.036µs ± 0.004µs 6.036µs ± 0.003µs 6.038µs 6.044µs 6.048µs 6.052µs 0.27% 0.836 0.805 0.07% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 165243196.525op/s 165675508.504op/s ± 119733.344op/s 165683681.777op/s ± 69390.001op/s 165763212.999op/s 165834758.137op/s 165866817.021op/s 165914663.624op/s 0.14% -0.831 0.794 0.07% 8466.426op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 3.893µs 3.912µs ± 0.003µs 3.912µs ± 0.001µs 3.914µs 3.917µs 3.919µs 3.921µs 0.22% -1.186 12.037 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 255044001.324op/s 255592152.259op/s ± 183838.346op/s 255604991.628op/s ± 90558.984op/s 255694662.375op/s 255804345.160op/s 255879271.069op/s 256901863.990op/s 0.51% 1.214 12.233 0.07% 12999.334op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 65.625µs 65.899µs ± 0.050µs 65.896µs ± 0.031µs 65.928µs 65.982µs 66.028µs 66.032µs 0.21% -0.398 3.964 0.08% 0.004µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 15144180.067op/s 15174785.029op/s ± 11501.433op/s 15175355.981op/s ± 7216.308op/s 15182031.688op/s 15191196.246op/s 15194244.782op/s 15238162.454op/s 0.41% 0.411 4.022 0.08% 813.274op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 52.948µs 53.021µs ± 0.034µs 53.020µs ± 0.024µs 53.043µs 53.081µs 53.099µs 53.101µs 0.15% 0.123 -0.416 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 18832087.725op/s 18860562.278op/s ± 12106.294op/s 18860908.881op/s ± 8443.478op/s 18869399.496op/s 18880906.779op/s 18885245.996op/s 18886341.398op/s 0.13% -0.120 -0.417 0.06% 856.044op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 3.894µs 3.912µs ± 0.003µs 3.912µs ± 0.002µs 3.914µs 3.916µs 3.918µs 3.918µs 0.15% -1.311 7.548 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 255238097.901op/s 255632197.759op/s ± 184893.715op/s 255618481.216op/s ± 106414.825op/s 255747943.792op/s 255889094.575op/s 255977754.309op/s 256837623.456op/s 0.48% 1.328 7.673 0.07% 13073.960op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 49.741µs 49.797µs ± 0.028µs 49.797µs ± 0.016µs 49.813µs 49.844µs 49.868µs 49.903µs 0.21% 0.351 0.690 0.06% 0.002µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 20038903.387op/s 20081689.522op/s ± 11217.677op/s 20081532.020op/s ± 6622.810op/s 20088168.571op/s 20100548.544op/s 20103591.547op/s 20104127.377op/s 0.11% -0.347 0.681 0.06% 793.210op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 44.567µs 45.155µs ± 0.220µs 45.173µs ± 0.163µs 45.323µs 45.464µs 45.506µs 45.518µs 0.76% -0.503 -0.480 0.49% 0.016µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 21969361.252op/s 22146281.080op/s ± 108104.519op/s 22137144.899op/s ± 79944.034op/s 22221968.083op/s 22339578.149op/s 22405003.127op/s 22438206.241op/s 1.36% 0.522 -0.454 0.49% 7644.144op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.029µs 6.037µs ± 0.004µs 6.037µs ± 0.003µs 6.040µs 6.044µs 6.046µs 6.049µs 0.20% 0.061 -0.460 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 165308648.306op/s 165632401.795op/s ± 109067.473op/s 165637331.116op/s ± 82390.124op/s 165716219.489op/s 165808832.775op/s 165861861.940op/s 165876044.246op/s 0.14% -0.058 -0.461 0.07% 7712.235op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [3.911µs; 3.912µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ throughput [255649609.291op/s; 255697235.497op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [78.536µs; 78.765µs] or [-0.145%; +0.145%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [12697519.434op/s; 12734298.996op/s] or [-0.145%; +0.145%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [70.937µs; 71.011µs] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/ 378282246310005 throughput [14082541.088op/s; 14097249.997op/s] or [-0.052%; +0.052%] None None None
credit_card/is_card_number/37828224631 execution_time [3.913µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/37828224631 throughput [255531871.943op/s; 255583844.403op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/378282246310005 execution_time [67.674µs; 67.758µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/378282246310005 throughput [14758763.348op/s; 14776979.808op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [45.179µs; 45.235µs] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [22106974.878op/s; 22134547.115op/s] or [-0.062%; +0.062%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.035µs; 6.037µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/x371413321323331 throughput [165658914.614op/s; 165692102.394op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ execution_time [3.912µs; 3.913µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [255566674.033op/s; 255617630.486op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [65.892µs; 65.906µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [15173191.041op/s; 15176379.017op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [53.016µs; 53.025µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [18858884.463op/s; 18862240.094op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [3.911µs; 3.912µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [255606573.268op/s; 255657822.250op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [49.793µs; 49.800µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [20080134.860op/s; 20083244.184op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [45.125µs; 45.186µs] or [-0.067%; +0.067%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [22131298.834op/s; 22161263.327op/s] or [-0.068%; +0.068%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.037µs; 6.038µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [165617286.092op/s; 165647517.498op/s] or [-0.009%; +0.009%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.202µs 3.280µs ± 1.446µs 3.052µs ± 0.028µs 3.082µs 3.729µs 14.388µs 14.887µs 387.77% 7.281 54.376 43.96% 0.102µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.080µs; 3.480µs] or [-6.108%; +6.108%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 33.534µs 34.083µs ± 0.973µs 33.635µs ± 0.058µs 33.755µs 36.132µs 36.159µs 38.015µs 13.02% 1.794 1.620 2.85% 0.069µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [33.948µs; 34.218µs] or [-0.396%; +0.396%] None None None

Group 13

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 204.294µs 204.947µs ± 0.375µs 204.927µs ± 0.256µs 205.174µs 205.617µs 205.890µs 206.185µs 0.61% 0.590 0.077 0.18% 0.026µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 4850020.331op/s 4879332.808op/s ± 8909.132op/s 4879794.185op/s ± 6091.631op/s 4886016.984op/s 4892295.519op/s 4893788.605op/s 4894910.246op/s 0.31% -0.580 0.058 0.18% 629.971op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 18.586µs 18.667µs ± 0.065µs 18.647µs ± 0.027µs 18.679µs 18.804µs 18.880µs 18.976µs 1.76% 1.859 3.853 0.35% 0.005µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 52697556.664op/s 53571544.322op/s ± 184223.415op/s 53626930.185op/s ± 77598.953op/s 53692991.443op/s 53751249.603op/s 53781848.009op/s 53803153.412op/s 0.33% -1.834 3.725 0.34% 13026.563op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 10.845µs 10.940µs ± 0.046µs 10.936µs ± 0.031µs 10.967µs 11.023µs 11.073µs 11.107µs 1.56% 0.701 0.726 0.42% 0.003µs 1 200
normalization/normalize_name/normalize_name/good throughput 90033249.972op/s 91413118.417op/s ± 385006.999op/s 91440243.667op/s ± 258626.436op/s 91692888.960op/s 91964079.707op/s 92114678.908op/s 92211661.229op/s 0.84% -0.673 0.659 0.42% 27224.106op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [204.895µs; 204.999µs] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [4878098.088op/s; 4880567.528op/s] or [-0.025%; +0.025%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [18.658µs; 18.676µs] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [53546012.729op/s; 53597075.916op/s] or [-0.048%; +0.048%] None None None
normalization/normalize_name/normalize_name/good execution_time [10.933µs; 10.946µs] or [-0.059%; +0.059%] None None None
normalization/normalize_name/normalize_name/good throughput [91359760.150op/s; 91466476.684op/s] or [-0.058%; +0.058%] None None None

Group 14

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
ip_address/quantize_peer_ip_address_benchmark execution_time 5.254µs 5.316µs ± 0.043µs 5.299µs ± 0.028µs 5.357µs 5.388µs 5.392µs 5.394µs 1.80% 0.518 -1.167 0.80% 0.003µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark execution_time [5.310µs; 5.321µs] or [-0.111%; +0.111%] None None None

Group 15

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 534.005µs 534.936µs ± 1.049µs 534.858µs ± 0.303µs 535.114µs 535.568µs 536.620µs 544.615µs 1.82% 7.626 66.948 0.20% 0.074µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1836159.687op/s 1869389.866op/s ± 3613.161op/s 1869655.740op/s ± 1057.133op/s 1870890.301op/s 1871851.742op/s 1872218.058op/s 1872641.229op/s 0.16% -7.562 66.181 0.19% 255.489op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 380.244µs 381.021µs ± 0.313µs 380.988µs ± 0.203µs 381.215µs 381.596µs 381.759µs 381.806µs 0.21% 0.093 -0.106 0.08% 0.022µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2619133.568op/s 2624529.027op/s ± 2154.853op/s 2624752.938op/s ± 1400.332op/s 2625715.700op/s 2628243.063op/s 2629072.581op/s 2629890.582op/s 0.20% -0.089 -0.107 0.08% 152.371op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 189.879µs 190.417µs ± 0.320µs 190.334µs ± 0.140µs 190.533µs 191.083µs 191.310µs 191.865µs 0.80% 1.470 2.530 0.17% 0.023µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5211993.840op/s 5251635.621op/s ± 8806.250op/s 5253914.267op/s ± 3869.086op/s 5256969.782op/s 5262182.190op/s 5263744.722op/s 5266499.030op/s 0.24% -1.459 2.480 0.17% 622.696op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 37.003µs 37.210µs ± 0.078µs 37.209µs ± 0.057µs 37.271µs 37.334µs 37.365µs 37.383µs 0.47% -0.139 -0.528 0.21% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 26750028.512op/s 26874434.248op/s ± 56522.837op/s 26875289.748op/s ± 40855.729op/s 26912497.561op/s 26969719.758op/s 27000825.244op/s 27024634.654op/s 0.56% 0.149 -0.522 0.21% 3996.768op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 45.776µs 45.914µs ± 0.062µs 45.909µs ± 0.035µs 45.945µs 46.017µs 46.053µs 46.295µs 0.84% 1.465 6.651 0.13% 0.004µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21600743.801op/s 21779697.139op/s ± 29165.613op/s 21782334.921op/s ± 16687.040op/s 21798175.563op/s 21819409.107op/s 21830257.523op/s 21845381.642op/s 0.29% -1.439 6.478 0.13% 2062.320op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [534.790µs; 535.081µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1868889.116op/s; 1869890.615op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [380.978µs; 381.064µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2624230.385op/s; 2624827.668op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [190.373µs; 190.462µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5250415.159op/s; 5252856.082op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [37.199µs; 37.221µs] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [26866600.727op/s; 26882267.770op/s] or [-0.029%; +0.029%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.906µs; 45.923µs] or [-0.019%; +0.019%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [21775655.066op/s; 21783739.213op/s] or [-0.019%; +0.019%] None None None

Group 16

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.386µs 2.445µs ± 0.017µs 2.443µs ± 0.004µs 2.448µs 2.485µs 2.494µs 2.498µs 2.21% 0.330 3.449 0.68% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.443µs; 2.448µs] or [-0.094%; +0.094%] None None None

Group 17

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 10.697ms 10.727ms ± 0.016ms 10.726ms ± 0.009ms 10.734ms 10.755ms 10.772ms 10.816ms 0.84% 1.318 4.351 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [10.725ms; 10.729ms] or [-0.021%; +0.021%] None None None

Group 18

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
profile_add_sample2_frames_x1000 execution_time 541.015µs 541.754µs ± 0.459µs 541.655µs ± 0.205µs 541.911µs 542.514µs 543.511µs 544.275µs 0.48% 1.968 6.732 0.08% 0.032µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
profile_add_sample2_frames_x1000 execution_time [541.691µs; 541.818µs] or [-0.012%; +0.012%] None None None

Group 19

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 23528d2 1766005983 levi/refactor-profilestatus
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.797µs 25.696µs ± 9.504µs 18.028µs ± 0.185µs 33.798µs 43.453µs 46.348µs 51.584µs 186.13% 0.717 -0.889 36.90% 0.672µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.379µs; 27.013µs] or [-5.126%; +5.126%] None None None

Baseline

Omitted due to size.

Base automatically changed from levi/profile-add2-api to main December 17, 2025 21:02
@morrisonlevi
Copy link
Contributor Author

morrisonlevi commented Dec 17, 2025

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Dec 17, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-12-17 21:10:53 UTC ℹ️ Start processing command /merge

2025-12-17 21:10:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-12-17 21:38:18 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 29m (p90).

2025-12-17 22:07:52 UTC ℹ️ MergeQueue: This merge request was merged

gyuheon0h
gyuheon0h approved these changes Dec 17, 2025
View reviewed changes
@morrisonlevi morrisonlevi force-pushed the levi/refactor-profilestatus branch from aac786a to 7de41d3 Compare December 17, 2025 21:11
@gyuheon0h
Copy link
Contributor

gyuheon0h commented Dec 17, 2025 •
edited
Loading

Now, our validation is basically just

if err == null -> OK
else if flags == FLAG_ALLOCATED -> Owned
else -> Borrowed

This lets previously invalid states pass through; I assume that is fine, since we are assuming we probably won't get such invalid states?

For example, if

flags = FLAG_ALLOCATED, err = NULL

Then previously we detected as “allocated but not error” then panic in but now we just treat as OK.

Also, if

flags = garbage, err != NULL

Then previously we panicked and detected that the FFI produced garbage but now our flow of checks are

flags != FLAG_ALLOCATED
err != NULL
-> treat as STATIC error

Which is not necessarily correct

We are assuming this stuff won't happen or is not an issue?

@dd-mergequeue dd-mergequeue bot merged commit cf34d04 into main Dec 17, 2025
37 of 38 checks passed
@dd-mergequeue dd-mergequeue bot deleted the levi/refactor-profilestatus branch December 17, 2025 22:07
@morrisonlevi morrisonlevi mentioned this pull request Dec 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gyuheon0h gyuheon0h gyuheon0h approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrisonlevi @codecov-commenter @gyuheon0h