Skip to content

Change system chain RPC name of Spreehafen parachain #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: ilya/parachain
Choose a base branch
from
Open

Change system chain RPC name of Spreehafen parachain #201

wants to merge 1 commit into from

Conversation

ltfschoen
Copy link
Collaborator

@ltfschoen ltfschoen commented Jun 9, 2021 •
edited
Loading

Change for compatibility and clarity with Polkadot.js Apps

See DataHighway-DHX/apps#2

@ltfschoen ltfschoen mentioned this pull request Jun 9, 2021
Merged
ayushmishra2005
ayushmishra2005 reviewed Jun 10, 2021
View reviewed changes
Copy link
Contributor

@ayushmishra2005 ayushmishra2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltfschoen Can we fix test-casers?

@ltfschoen
Copy link
Collaborator Author

ltfschoen commented Jun 10, 2021 •
edited
Loading

@ltfschoen Can we fix test-casers?

yes, i just noticed that too.
in the CI test logs it's using cargo +nightly-2020-12-12 ... for doing the tests
but in our 'master' branch we're using a mixture of nightly-2020-10-06 and nightly-2020-12-12
so ideally we try to update this branch to use the same version as the 'master' branch, which is currently nightly-2021-03-10 so those pallets work, so we'll need to create a Jira task for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@festelo festelo Awaiting requested review from festelo

1 more reviewer

@ayushmishra2005 ayushmishra2005 ayushmishra2005 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ltfschoen @ayushmishra2005