docker: avoid the use of the ADD instruction#130
Merged
sanket-deepsource merged 2 commits intoDeepSourceCorp:masterfrom Feb 25, 2025
Merged
docker: avoid the use of the ADD instruction#130sanket-deepsource merged 2 commits intoDeepSourceCorp:masterfrom
ADD instruction#130sanket-deepsource merged 2 commits intoDeepSourceCorp:masterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hrideshmg
force-pushed
the
docker_add
branch
from
24178d2 to
ed51d13
Compare
sanket-deepsource
requested changes
Feb 25, 2025
Signed-off-by: Sanket Saurav <sanket@deepsource.io>
sanket-deepsource
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This PR adds a checker to detect the use of the
ADDinstruction in Dockerfiles; If used for copying filesADDhas certain side effects, for example - The ability to do automatic archive extraction and remote URL downloads which can introduce security risks. This checker warns the user and tells them to prefer theCOPYinstruction instead.See - Dockerfile Best Practices
✅ Example
🚨 Flagged
ADD https://example.com/file.tar.gz /destination/