-
Notifications
You must be signed in to change notification settings - Fork 46
docker: avoid the use of the ADD instruction
#130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanket-deepsource
merged 2 commits into
DeepSourceCorp:master
from
hrideshmg:docker_add
Feb 25, 2025
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| ## These should be flagged | ||
|
|
||
| # <expect-error> | ||
| ADD ./source /destination | ||
|
|
||
| # <expect-error> | ||
| ADD https://example.com/file.tar.gz /destination/ | ||
|
|
||
| # <expect-error> | ||
| ADD archive.tar.gz /extract-here/ | ||
|
|
||
| # <expect-error> | ||
| ADD ["file1", "file2", "/dest/"] | ||
|
|
||
| # <expect-error> | ||
| ADD --chown=1000:1000 sourcefile /destination/ | ||
|
|
||
| ## These are safe and should not be flagged | ||
|
|
||
| # Using COPY instead of ADD | ||
| COPY ./source /destination | ||
|
|
||
| COPY ["file1", "file2", "/dest/"] | ||
|
|
||
| # Comments containing "ADD" should not trigger detection | ||
| # This is an example: ADD should not be used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| language: dockerfile | ||
| name: avoid_add | ||
| message: "Avoid using the 'ADD' instruction in Dockerfiles, prefer 'COPY' instead for copying files" | ||
| category: antipattern | ||
| severity: warning | ||
|
|
||
| pattern: | | ||
| (add_instruction) @avoid_add | ||
|
|
||
| description: | | ||
| The 'ADD' instruction in Dockerfiles should be avoided due to its unintended side effects, | ||
| such as automatic archive extraction and remote URL downloads, which can introduce security risks. | ||
| If you only need to copy files into the image, prefer the use of 'COPY'. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.