avoid failing on empty mcp.json file #1469
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanstephens
requested review from
KevyVo
and removed request for
lionello and
nullfunc
|
Oh I think your branch is outdated @jordanstephens, I just made a fix for that yesterday. #1451 |
|
I also want to refactor the two functions handleVSCodeConfig and handleStandardConfig to be one source of logic. I need help refactoring this since it a bit hard to define with having specific types. #1464 Maybe you can have a discussion to help me? |
|
Fixed by #1451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
mcp.jsonexists, but is empty, we would fail to parse it and so we would fail to proceed and configure our server. it seems reasonable to me that we can keep going : )Linked Issues
Checklist