Skip to content

avoid failing on empty mcp.json file #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

avoid failing on empty mcp.json file #1469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/pkg/mcp/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,11 @@ func handleVSCodeConfig(configPath string) error {

// Check if the file exists
if data, err := os.ReadFile(configPath); err == nil {
// File exists, parse it
if err := json.Unmarshal(data, &existingData); err != nil {
return fmt.Errorf("failed to unmarshal existing vscode config %w", err)
if string(data) != "" {
// File exists and is not empty, try to parse it
if err := json.Unmarshal(data, &existingData); err != nil {
return fmt.Errorf("failed to unmarshal existing vscode config %w", err)
}
}

// Check if "servers" section exists
Expand Down
Loading