Skip to content

Conversation

commit111
Copy link
Contributor

@commit111 commit111 commented Nov 14, 2024

Description

For BYOC, when AWS region is not set, the error now links to the docs: missing AWS region: set AWS_REGION or edit your AWS profile (https://docs.defang.io/docs/providers/aws#region)

Linked Issues

#853 (for aws missing credentials)
#782

Checklist

  • I have performed a self-review of my code
  • I have added appropriate tests
  • I have updated the Defang CLI docs and/or README to reflect my changes, if necessary

@commit111 commit111 requested a review from edwardrf November 14, 2024 21:18
Copy link
Member

@lionello lionello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test failure? might be intermittent.

@commit111 commit111 requested a review from lionello November 15, 2024 19:55
@lionello lionello merged commit 537e821 into main Nov 19, 2024
13 checks passed
@lionello lionello deleted the linda-aws-region branch November 19, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants