Skip to content

AWS region error links to docs #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2024
Merged

AWS region error links to docs #859

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b05a785
added link to docs on aws region error
commit111 Nov 14, 2024
8038376
fix proto to pass test
commit111 Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/pkg/cli/client/byoc/aws/byoc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,18 @@ func (e ErrMissingAwsCreds) Unwrap() error {
return e.err
}

type ErrMissingAwsRegion struct {
err error
}

func (e ErrMissingAwsRegion) Error() string {
return "missing AWS region: set AWS_REGION or edit your AWS profile (https://docs.defang.io/docs/providers/aws#region)"
}

func (e ErrMissingAwsRegion) Unwrap() error {
return e.err
}

func AnnotateAwsError(err error) error {
if err == nil {
return nil
Expand All @@ -82,6 +94,9 @@ func AnnotateAwsError(err error) error {
if strings.Contains(err.Error(), "get credentials:") {
return connect.NewError(connect.CodeUnauthenticated, ErrMissingAwsCreds{err})
}
if strings.Contains(err.Error(), "missing AWS region:") {
return connect.NewError(connect.CodeUnauthenticated, ErrMissingAwsRegion{err})
}
if cerr := new(aws.ErrNoSuchKey); errors.As(err, &cerr) {
return connect.NewError(connect.CodeNotFound, err)
}
Expand Down
Loading