GRIDEDIT-1926 '-Wno-unused-parameters' behind optional configuration parameter#517
Merged
ScottWillcox merged 4 commits intofeature/GRIDEDIT-1926-build-meshkernel-on-macos-with-clang-compilerfrom Jan 20, 2026
Conversation
… Only needed on MacOS15-intel runners
ScottWillcox
changed the base branch from
master
to
feature/GRIDEDIT-1926-build-meshkernel-on-macos-with-clang-compiler
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a configurable option to suppress unused parameter warnings (-Wno-unused-parameter) specifically for macOS 15 Intel builds, addressing platform-specific compiler issues identified in GRIDEDIT-1926.
Changes:
- Added a new CMake option
SUPPRESS_UNUSED_PARAMETER_WARNINGto control the suppression of unused parameter warnings - Modified the macOS Clang compiler configuration to conditionally apply
-Wno-unused-parameterbased on the new option - Updated the GitHub Actions workflow to enable this option specifically for
macos-15-intelbuilds
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmake/options.cmake | Introduces the new SUPPRESS_UNUSED_PARAMETER_WARNING configuration option |
| cmake/compiler_config.cmake | Removes unconditional -Wno-unused-parameter flag and applies it conditionally based on the new option |
| .github/workflows/build-and-test-workflow.yml | Enables the suppression flag for macOS 15 Intel builds and removes unused ARM64 architecture logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@ScottWillcox I've opened a new pull request, #518, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * Remove unused ARCH_FLAG variable Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com>
ScottWillcox
merged commit f4c89fe
into
feature/GRIDEDIT-1926-build-meshkernel-on-macos-with-clang-compiler
20 checks passed
ScottWillcox
deleted the
feature/GRIDEDIT-1926-handling-review-comments
branch
ScottWillcox
added a commit
that referenced
this pull request
Feb 3, 2026
) *NOTE* Bypassing rules to merge. Sonarcloud rule is failing due to code coverage, this has not been changed by this PR, this is already an issue on main. Failed conditions 79.7% Coverage on New Code (required ≥ 80%) * GRIDEDIT-1926 Update cmake compiler configuration to use Apple/Clang on MacOS * GRIDEDIT-1926 Disabled CMP0175 during netcdf_static build. produces to many log entries. * GRIDEDIT-1926 Updating README.md file with information regarding Apple/Clang building MeshKernel on MacOS * GRIDEDIT-1926 compiler directives and code changes required for building with Apple/Clang on MacOS * GRIDEDIT-1926 updated github workflow configuration to build MeshKernel using Apple/Clang * GRIDEDIT-1926 export zlib path * GRIDEDIT-1926 echo commands to find out where the libz.1.dylib can be found * GRIDEDIT-1926 Creating links so that the libz lib can be found. * GRIDEDIT-1926 Explicitly constructs the UndoActionForMesh struct with designated member initialization. * GRIDEDIT-1926 fix: Make CMake OpenMP and architecture flags conditional per runner architecture (#515) * GRIDEDIT-1926 fix: Make CMake OpenMP and architecture flags conditional per runner architecture * GRIDEDIT-1926 Replaced BoundingBox constructor calls with aggregate initialization * GRIDEDIT-1926 ignore more boost directories. * GRIDEDIT-1926 add compiler config "-Wno-unused-parameter" for boost. * GRIDEDIT-1926 Changed point location to prevent rounding errors Due to different platform architectures and compilers rounding errors may occur. ARM64 vs intel resulting in different results. * GRIDEDIT-1926 Handling review comments. Removed 'brew update'. github action runners use upto date versions of brew.(Doing brew update can take a long time) * GRIDEDIT-1926 '-Wno-unused-parameters' behind optional configuration parameter (#517) * GRIDEDIT-1926 '-Wno-unused-parameters' behind optional configuration. Only needed on MacOS15-intel runners * Update cmake/compiler_config.cmake Fix typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove unused ARCH_FLAG variable from workflow (#518) * Initial plan * Remove unused ARCH_FLAG variable Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> * Use Boost::boost imported target in CMake configuration (#520) * Initial plan * Use Boost::boost imported target instead of manual include directories Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: ScottWillcox <54632073+ScottWillcox@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option is only needed for the MacOS15-intel builds.