Closed
Conversation
metrapoliten
force-pushed
the
refactor/normalize-includes
branch
from
dfccc22 to
a662e42
Compare
Normalize include directives to follow Google styleguide and ensure all includes are listed as descendants of the source dir (src/).
Due to the normalisation of includes and their subsequent formatting, the order in which they're included has changed, and the build has broken. Adding this include solves the build problem.
Replace library #include "..." with <...> for consistency with project style and proper formatting.
metrapoliten
force-pushed
the
refactor/normalize-includes
branch
from
a662e42 to
417af6b
Compare
Collaborator
|
You might want to split this into parts with less than 300 files so clang-tidy-review can process the PR |
BUYT-1
added
the
python-packaging-risk
BUYT-1
approved these changes
Nov 29, 2025
BUYT-1
requested changes
Nov 29, 2025
Collaborator
BUYT-1
left a comment
BUYT-1
left a comment
There was a problem hiding this comment.
There are still target_include_directory in src/tests/CMakeLists.txt, remove them too.
Collaborator
|
Merged in the following PRs: Script is in progress: #633 |
Collaborator
|
Closed since merged in parts, see above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/).stripped_partition.hfrozen,boostlibraries andimmintrin.h