dev: update Biome from 2.3.4 to 2.3.8 and add some rules#1392
Merged
Conversation
DayKev
added
Dependencies
This comment was marked as resolved.
This comment was marked as resolved.
DayKev
force-pushed
the
dev/update-biome-2.3.7
branch
from
540b93b to
33f4b0e
Compare
DayKev
changed the title
2.3.4 to 2.3.7 and add some rules2.3.4 to 2.3.8 and add some rules
5 tasks
DayKev
force-pushed
the
dev/update-biome-2.3.7
branch
4 times, most recently
from
4a80233 to
a066717
Compare
The rule was fixed in Biome v2.3.6 to recognize nested ternaries within parentheses
DayKev
force-pushed
the
dev/update-biome-2.3.7
branch
from
a066717 to
95d5840
Compare
Tempo-anon
previously approved these changes
Dec 11, 2025
Remove now-obsolete `noUnusedImport` suppressions There's a bug where TSDoc usage on object properties isn't detected, leaving 4 files with suppressions still until the bug is fixed: `battle-scene-event-type.ts`, `challenge-type.ts`, `egg-event-type.ts`, and `move-flags.ts`; all in the `enums/` directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
Keep deps up-to-date, improve codebase with lint rules.
After Biome is updated, most of the
noUnusedImportssuppressions will be removed (except for 5, due to a bug where TSDoc usage on object properties is not detected).What are the changes from a developer perspective?
lint/style/noNestedTernaryrule was fixed in2.3.6to properly detect nested ternaries within parentheses, requiring updating the codebase to fix the newly-detected issues.encounter-pokemon-utils.tswhile fixing the nearby lint issues.2.3.6which incidentally caused the formatter to format them differently. Changes were minimized via specifically placed comments and suppression comments.New Rules
Nursery
Correctness
Checklist
betaas my base branch