fix(ability): Parental Bond no longer reduces damage improperly#1404
Merged
fix(ability): Parental Bond no longer reduces damage improperly#1404
Conversation
Parental Bond will no longer erroneously consider hitting the second Pokemon on the field as the second strike of a move when using a spread move (meaning the damage will no longer be improperly reduced) Co-authored-by: Bertie690 <taylormw163@gmail.com>
DayKev
added
Ability
innerthunder
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of pagefaultgames/pokerogue#6743
What are the changes the user will see?
Parental Bond will no longer erroneously consider hitting the second Pokémon on the field as the second strike of a move when using a spread move (meaning the damage will no longer be improperly reduced).
Why am I making these changes?
Fixing a bug.
What are the changes from a developer perspective?
The damage reduction of the second strike from Parental Bond is no longer handled by
AddSecondStrikeAbAttr. Instead, Parental Bond uses the existingDamageBoostAbAttrwith a multiplier of0.25with a condition function that checks if it's the second hit of the move.How to test the changes?
pnpm test:silent parental-bondChecklist
betaas my base branchpnpm test:silent)pnpm test:create) or updated existing tests related to the PR's changes?