Skip to content

Comments

refactor: move asset initialization from launchBattle to preload#1406

Merged
DayKev merged 3 commits intobetafrom
refactor/asset-init-preload
Jan 7, 2026
Merged

refactor: move asset initialization from launchBattle to preload#1406
DayKev merged 3 commits intobetafrom
refactor/asset-init-preload

Conversation

@DayKev
Copy link
Contributor

@DayKev DayKev commented Dec 26, 2025

What are the changes the user will see?

N/A

Why am I making these changes?

Asset initialization should be done in the preload step and not after launching the game.

What are the changes from a developer perspective?

Moved asset initialization from BattleScene#launchBattle to #preload.
Removed utility function waitUntil in game-manager-utils.ts and replaced its use with vi.waitUntil.
Replaced firstTimeScene variable in GameManager with private resetScene method.
Simplified if/elseif in MoveHelper#selectTarget.

Checklist

  • Otherwise: I'm using beta as my base branch
  • There is no overlap with another PR?
  • [-] The PR is self-contained and cannot be split into smaller PRs?
    • It could, but it's just a collection of small changes so w/e, might as well just port the whole thing at once.
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?

Co-authored-by: Bertie690 <136088738+Bertie690@users.noreply.github.com>
@DayKev DayKev force-pushed the refactor/asset-init-preload branch from 4238ebe to 19c325c Compare December 28, 2025 09:33
@DayKev DayKev merged commit 1562a6f into beta Jan 7, 2026
9 checks passed
@DayKev DayKev deleted the refactor/asset-init-preload branch January 7, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor For refactoring code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants