Update detsys-ts: Capture the version of Nix in addition to the nix store version (#108)#147
Conversation
…e nix store version (DeterminateSystems#108)` (`c7303495f43d348cac78091ef434443b1ef22485`)
WalkthroughDependency version bumps in package.json for got, @types/node, eslint-plugin-prettier, and typescript. No source code or control-flow changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
package.json (1)
32-34: No action required: detsys-ts is already pinned to commit c7303495f43d3… in your lockfile and bundled output. Optional: if you want package.json to reflect that exact commit (so fresh installs without an existing lockfile still resolve to c7303495f43d3…), you can change the spec to- "detsys-ts": "github:DeterminateSystems/detsys-ts", + "detsys-ts": "github:DeterminateSystems/detsys-ts#c7303495f43d348cac78091ef434443b1ef22485",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (2)
dist/index.jsis excluded by!**/dist/**pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build
🔇 Additional comments (2)
package.json (2)
38-38: @types/node ^20.19.12 bump looks fine.No action needed if the action targets Node 20. Keep tsconfig lib/target aligned.
47-47: eslint-plugin-prettier ^5.5.4 bump is OK.Peer deps with Prettier 3 and ESLint 8 appear satisfied.
| "@actions/glob": "^0.5.0", | ||
| "detsys-ts": "github:DeterminateSystems/detsys-ts", | ||
| "got": "^14.4.7", | ||
| "got": "^14.4.8", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
got ^14.4.8: confirm Node engine and ESM-only usage.
- got v14 is ESM-only; repo is "type":"module" so imports should be fine.
- Ensure runner Node version (GitHub-hosted) satisfies got’s engine.
Checks:
🏁 Script executed:
#!/bin/bash
# No CommonJS requires of got
rg -nP "require\\(['\"]got['\"]\\)" -g 'src/**/*.ts' -C2 || true
# Installed got version and engines
pnpm list got --depth=0 || true
jq -r '.engines // {}' node_modules/got/package.json 2>/dev/null || trueLength of output: 155
🏁 Script executed:
#!/bin/bash
# Confirm no CommonJS requires of got
rg -nP "require\(['\"]got['\"]\)" -g 'src/**/*.ts' -C2 || true
# Confirm ESM imports usage of got
rg -nP "import\s+got" -g 'src/**/*.ts' -C2 || true
# Project Node engine requirement
jq -r '.engines.node // "none"' package.json
# Got package engines requirement
curl -s 'https://registry.npmjs.org/got/14.4.8' | jq -r '.engines.node // "none"'Length of output: 572
got v14.4.8: ESM import confirmed; enforce Node.js ≥20
- No CommonJS
require("got")detected; ESMimport got…is in use. - In package.json, add
and update your GitHub Actions workflow to run on Node.js 20.x.
"engines": { "node": ">=20" }
🤖 Prompt for AI Agents
In package.json around line 33, the project depends on got v14.4.8 which is
ESM-only and requires Node.js ≥20; add an "engines": {"node": ">=20"} entry to
package.json and update any CI workflow files (e.g., GitHub Actions matrix) to
include/use Node.js 20.x so runners use a compatible Node version; ensure
package.json formatting stays valid and bump any docs or README that state
supported Node versions.
| "prettier": "^3.6.2", | ||
| "tsup": "^8.5.0", | ||
| "typescript": "^5.8.3" | ||
| "typescript": "^5.9.2" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
TypeScript ^5.9.2: verify lint/parser compatibility and typebreaks.
Ensure @typescript-eslint stack is compatible; bump if needed.
Quick sweep:
🏁 Script executed:
#!/bin/bash
# Show versions
node -v || true
pnpm list typescript @typescript-eslint/eslint-plugin @typescript-eslint/parser --depth=0 || true
# Typecheck without emitting
pnpm exec tsc --noEmit
# Lint to catch parser mismatch
pnpm run lintLength of output: 439
🏁 Script executed:
#!/bin/bash
# Install dependencies to enable eslint and tsc commands
pnpm install --frozen-lockfile || pnpm install
# Show Node and package versions
node -v
pnpm list typescript @typescript-eslint/eslint-plugin @typescript-eslint/parser --depth=0
# Verify type checking
pnpm exec tsc --noEmit
# Run lint to catch any parser mismatches
pnpm run lintLength of output: 3709
TypeScript ^5.9.2: fix typecheck & ESLint parser setup
• tsc is erroring on tsup.config.ts outside rootDir='src'—add it to tsconfig.json’s exclude (or expand rootDir).
• @typescript-eslint/parser isn’t installed but is required by the ESLint plugin—add it to devDependencies to match your 7.18.0 plugin.
Re-run pnpm exec tsc --noEmit and pnpm run lint to confirm.
🤖 Prompt for AI Agents
In package.json around line 50, TypeScript ^5.9.2 is causing tsc to error on
files outside rootDir (e.g., tsup.config.ts) and ESLint requires
@typescript-eslint/parser but it’s not installed; update tsconfig.json to
exclude tsup.config.ts (or adjust rootDir to include it) so tsc stops
typechecking that file, add @typescript-eslint/parser@7.18.0 to devDependencies
to match the plugin version, then re-run pnpm exec tsc --noEmit and pnpm run
lint to verify fixes.
2 participants
Bump
detsys-tsto the latestHEADand regenerate application bundle.c7303495f43d348cac78091ef434443b1ef22485DeterminateSystems/detsys-ts#108e439a01995ac029e7481a75c4661a7f60eeb8b19..c7303495f43d348cac78091ef434443b1ef22485108.diffSummary by CodeRabbit