dxFileManager: fix 'First item is selected when right-clicking on an empty area' (T1307139)#31170
Merged
miherlosev merged 7 commits intoDevExpress:25_2from Oct 2, 2025
Merged
Conversation
miherlosev
changed the title
Staziz
reviewed
Sep 29, 2025
Contributor
Staziz
left a comment
Staziz
left a comment
There was a problem hiding this comment.
In single selection mode, the component should synchronize the selection and focus state. This is the original intention that we've put into it. Perhaps it's a bit unusual, but nevertherless.
And I believe we need to mimic the details view behavior in the single selection mode, namely, not focusing any items during _focusInHandler. (This is a rough estimate that requires verification). The focus frame should appear only after an element is selected, not when we simply focus the thumbnails view with a mouse click or context menu
packages/devextreme/js/ui/file_manager/ui.file_manager.item_list.thumbnails.js
Outdated
Show resolved
Hide resolved
Staziz
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.