Skip to content

dxFileManager: fix 'First item is selected when right-clicking on an empty area' (T1307139) #31170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miherlosev merged 7 commits into from
Oct 2, 2025
Merged

dxFileManager: fix 'First item is selected when right-clicking on an empty area' (T1307139) #31170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
63092ce
initial
miherlosev Sep 26, 2025
231b7df
add test
miherlosev Sep 29, 2025
d0bdc24
small changes
miherlosev Sep 29, 2025
e3f6aa9
rewrite logic
miherlosev Sep 30, 2025
7db6586
remove testcafe test
miherlosev Sep 30, 2025
d851fa3
add a test
miherlosev Oct 1, 2025
45bdf96
revert change
miherlosev Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/devextreme/js/ui/file_manager/ui.file_manager.items_list.thumbnails.list_box.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,8 @@ class FileManagerThumbnailListBox extends CollectionWidget {

_focusOutHandler() {}

_focusInHandler() {}

_getItems() {
return this.option('items') || [];
}
Expand Down
10 changes: 10 additions & 0 deletions ...s/devextreme/testing/tests/DevExpress.ui.widgets/fileManagerParts/thumbnailsView.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import 'ui/file_manager';
import fx from 'common/core/animation/fx';
import { FileManagerWrapper, createTestFileSystem } from '../../../helpers/fileManagerHelpers.js';
import { shouldSkipOnMobile } from '../../../helpers/device.js';
import pointerMock from '../../../helpers/pointerMock.js';

const { test } = QUnit;

Expand Down Expand Up @@ -302,4 +303,13 @@ QUnit.module('Thumbnails View', moduleConfig, () => {
assert.notOk(this.wrapper.isThumbnailsItemSelected('..'), 'parent folder is not visually highlited');
});

test('Thumbnails view - should focus item only on selection (T1307139)', function(assert) {
this.wrapper.getThumbnailsViewPort().trigger('focusin');
assert.notOk(this.wrapper.isThumbnailsItemFocused('Folder 1'));

pointerMock(this.wrapper.findThumbnailsItem('Folder 1')).click();
this.clock.tick(400);
assert.ok(this.wrapper.isThumbnailsItemSelected('Folder 1'));
assert.ok(this.wrapper.isThumbnailsItemFocused('Folder 1'));
});
});
Loading