Implement group management API #15
Conversation
- Added group creation, retrieval, updating, and deletion endpoints. - Implemented functionality for users to join and leave groups. - Created schemas for group requests and responses using Pydantic. - Developed service layer for group operations, including database interactions. - Added tests for group routes and service methods to ensure functionality.
✅ Deploy Preview for splitwizer canceled.
|
|
""" WalkthroughThis change introduces a comprehensive Groups Service to the backend application. It adds REST API endpoints, request/response schemas, business logic for group and membership management, and thorough documentation. The service is integrated into the FastAPI app, and extensive tests are provided for both the API routes and the service layer, covering all group operations and edge cases. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant API as Groups API (routes.py)
participant Service as GroupService (service.py)
participant DB as MongoDB
User->>API: POST /groups (create group)
API->>Service: create_group(group_data, user_id)
Service->>DB: Insert group document
DB-->>Service: Group created
Service-->>API: GroupResponse
API-->>User: Group details
User->>API: POST /groups/join (join by code)
API->>Service: join_group_by_code(join_code, user_id)
Service->>DB: Find group by join code
DB-->>Service: Group document
Service->>DB: Update group members
DB-->>Service: Updated group
Service-->>API: JoinGroupResponse
API-->>User: Join confirmation
User->>API: PATCH /groups/{group_id}/members/{member_id} (update role)
API->>Service: update_member_role(group_id, member_id, new_role, user_id)
Service->>DB: Find group and check admin
Service->>DB: Update member role
DB-->>Service: Success/failure
Service-->>API: Status response
API-->>User: Role update result
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Devasy
added
documentation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🔭 Outside diff range comments (1)
backend/app/groups/schemas.py (1)
1-54: Fix formatting issues to comply with PEP 8.The schema definitions are well-structured with proper validation, but there are consistent formatting violations flagged by static analysis tools.
Apply this diff to fix the formatting issues:
from pydantic import BaseModel, Field from typing import Optional, List from datetime import datetime + class GroupMember(BaseModel): userId: str role: str = "member" # "admin" or "member" joinedAt: datetime + class GroupCreateRequest(BaseModel): name: str = Field(..., min_length=1, max_length=100) currency: Optional[str] = "USD" imageUrl: Optional[str] = None + class GroupUpdateRequest(BaseModel): name: Optional[str] = Field(None, min_length=1, max_length=100) imageUrl: Optional[str] = None + class GroupResponse(BaseModel): id: str = Field(alias="_id") name: str currency: str joinCode: str createdBy: str createdAt: datetime imageUrl: Optional[str] = None members: Optional[List[GroupMember]] = [] model_config = {"populate_by_name": True} + class GroupListResponse(BaseModel): groups: List[GroupResponse] + class JoinGroupRequest(BaseModel): joinCode: str = Field(..., min_length=1) + class JoinGroupResponse(BaseModel): group: GroupResponse + class MemberRoleUpdateRequest(BaseModel): role: str = Field(..., pattern="^(admin|member)$") + class LeaveGroupResponse(BaseModel): success: bool message: str + class DeleteGroupResponse(BaseModel): success: bool message: str + class RemoveMemberResponse(BaseModel): success: bool message: str
🧹 Nitpick comments (10)
backend/app/groups/README.md (2)
75-81: Add language specification to code block.The markdown linter correctly flags the missing language specification for the code block.
Apply this diff:
-``` +```text backend/app/groups/ ├── __init__.py ├── schemas.py # Pydantic models for request/response ├── service.py # Business logic and database operations └── routes.py # FastAPI route handlers--- `93-93`: **Minor grammar improvement for consistency.** The grammar checker suggests using "to-dos" for better readability. Apply this diff: ```diff -- **Balance Integration Ready**: TODOs marked for expense service integration +- **Balance Integration Ready**: To-dos marked for expense service integrationbackend/app/groups/service.py (5)
1-5: Remove unused importsThe following imports are not used in the code and should be removed:
statusfrom fastapiDict,Anyfrom typing-from fastapi import HTTPException, status +from fastapi import HTTPException from app.database import get_database from bson import ObjectId from datetime import datetime, timezone -from typing import Optional, Dict, Any, List +from typing import Optional, List
9-12: Remove empty__init__methodThe
__init__method is empty and can be removed since Python will use the default constructor.class GroupService: - def __init__(self): - pass -
196-199: Address TODO: Implement balance checking before allowing group leaveThe TODO comment indicates that balance checking is needed before allowing users to leave groups. This is important to prevent users from leaving with unsettled debts.
Would you like me to help implement the balance checking logic or create an issue to track this task? The implementation would need to:
- Call the expense service to check user's balance in the group
- Only allow leaving if balance is zero or user is owed money
- Return appropriate error message if user owes money
273-279: Remove unnecessaryelseblock afterraiseThe
elseblock is unnecessary after araisestatement. De-indent the code for better readability.if not group: # Check if group exists at all group_exists = await db.groups.find_one({"_id": obj_id}) if not group_exists: raise HTTPException(status_code=404, detail="Group not found") - else: - raise HTTPException(status_code=403, detail="Only group admins can remove members") + raise HTTPException(status_code=403, detail="Only group admins can remove members")
297-298: Add blank lines for PEP 8 complianceAdd two blank lines after the class definition as per PEP 8 style guide.
return result.modified_count == 1 + group_service = GroupService()backend/app/groups/routes.py (3)
13-13: Add blank lines between functions for PEP 8 complianceAdd two blank lines between function definitions as per PEP 8 style guide. This applies to all function definitions in the file.
Example for the first occurrence:
router = APIRouter(prefix="/groups", tags=["Groups"]) + @router.post("", response_model=GroupResponse, status_code=status.HTTP_201_CREATED)Apply similar changes before each function definition.
Also applies to: 27-27, 33-33, 44-44, 60-60, 71-71, 82-82, 93-93, 102-102, 117-117
23-25: Remove redundant None checkThe
group_service.create_group()method raises HTTPException on failure rather than returning None, making this check redundant.group = await group_service.create_group( group_data.model_dump(exclude_unset=True), current_user["_id"] ) - if not group: - raise HTTPException(status_code=500, detail="Failed to create group") return group
77-80: Remove redundant None checkThe
group_service.join_group_by_code()method raises HTTPException for invalid join codes rather than returning None.group = await group_service.join_group_by_code(join_data.joinCode, current_user["_id"]) - if not group: - raise HTTPException(status_code=404, detail="Invalid join code") return {"group": group}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
backend/app/groups/README.md(1 hunks)backend/app/groups/routes.py(1 hunks)backend/app/groups/schemas.py(1 hunks)backend/app/groups/service.py(1 hunks)backend/main.py(2 hunks)backend/tests/groups/test_groups_routes.py(1 hunks)backend/tests/groups/test_groups_service.py(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
backend/app/groups/routes.py (2)
backend/app/groups/schemas.py (10)
GroupCreateRequest(10-13)GroupResponse(19-29)GroupListResponse(31-32)GroupUpdateRequest(15-17)JoinGroupRequest(34-35)JoinGroupResponse(37-38)MemberRoleUpdateRequest(40-41)LeaveGroupResponse(43-45)DeleteGroupResponse(47-49)RemoveMemberResponse(51-53)backend/app/groups/service.py (10)
create_group(41-73)get_user_groups(75-84)get_group_by_id(86-98)update_group(100-121)delete_group(123-140)join_group_by_code(142-168)leave_group(170-204)get_group_members(206-221)update_member_role(223-257)remove_member(259-295)
🪛 Flake8 (7.2.0)
backend/app/groups/schemas.py
[error] 5-5: expected 2 blank lines, found 1
(E302)
[error] 10-10: expected 2 blank lines, found 1
(E302)
[error] 15-15: expected 2 blank lines, found 1
(E302)
[error] 19-19: expected 2 blank lines, found 1
(E302)
[error] 31-31: expected 2 blank lines, found 1
(E302)
[error] 34-34: expected 2 blank lines, found 1
(E302)
[error] 37-37: expected 2 blank lines, found 1
(E302)
[error] 40-40: expected 2 blank lines, found 1
(E302)
[error] 43-43: expected 2 blank lines, found 1
(E302)
[error] 47-47: expected 2 blank lines, found 1
(E302)
[error] 51-51: expected 2 blank lines, found 1
(E302)
backend/tests/groups/test_groups_routes.py
[error] 1-1: 'pytest' imported but unused
(F401)
[error] 4-4: 'unittest.mock.AsyncMock' imported but unused
(F401)
[error] 5-5: 'bson.ObjectId' imported but unused
(F401)
backend/app/groups/service.py
[error] 1-1: 'fastapi.status' imported but unused
(F401)
[error] 5-5: 'typing.Dict' imported but unused
(F401)
[error] 5-5: 'typing.Any' imported but unused
(F401)
[error] 9-9: expected 2 blank lines, found 1
(E302)
[error] 297-297: expected 2 blank lines after class or function definition, found 1
(E305)
backend/app/groups/routes.py
[error] 13-13: expected 2 blank lines, found 1
(E302)
[error] 27-27: expected 2 blank lines, found 1
(E302)
[error] 33-33: expected 2 blank lines, found 1
(E302)
[error] 44-44: expected 2 blank lines, found 1
(E302)
[error] 60-60: expected 2 blank lines, found 1
(E302)
[error] 71-71: expected 2 blank lines, found 1
(E302)
[error] 82-82: expected 2 blank lines, found 1
(E302)
[error] 93-93: expected 2 blank lines, found 1
(E302)
[error] 102-102: expected 2 blank lines, found 1
(E302)
[error] 117-117: expected 2 blank lines, found 1
(E302)
🪛 Pylint (3.3.7)
backend/app/groups/schemas.py
[refactor] 5-5: Too few public methods (0/2)
(R0903)
[refactor] 10-10: Too few public methods (0/2)
(R0903)
[refactor] 15-15: Too few public methods (0/2)
(R0903)
[refactor] 19-19: Too few public methods (0/2)
(R0903)
[refactor] 31-31: Too few public methods (0/2)
(R0903)
[refactor] 34-34: Too few public methods (0/2)
(R0903)
[refactor] 37-37: Too few public methods (0/2)
(R0903)
[refactor] 40-40: Too few public methods (0/2)
(R0903)
[refactor] 43-43: Too few public methods (0/2)
(R0903)
[refactor] 47-47: Too few public methods (0/2)
(R0903)
[refactor] 51-51: Too few public methods (0/2)
(R0903)
backend/app/groups/service.py
[refactor] 275-278: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
(R1720)
🪛 LanguageTool
backend/app/groups/README.md
[grammar] ~93-~93: It appears that a hyphen is missing in the plural noun “to-dos”?
Context: ...emoval - Balance Integration Ready: TODOs marked for expense service integration ...
(TO_DO_HYPHEN)
🪛 markdownlint-cli2 (0.17.2)
backend/app/groups/README.md
75-75: Fenced code blocks should have a language specified
null
(MD040, fenced-code-language)
🪛 GitHub Actions: Run Tests
backend/tests/groups/test_groups_service.py
[error] 80-80: TypeError in async iteration: 'async for' requires an object with aiter method, got coroutine. This occurs in get_user_groups method when iterating over database cursor.
backend/tests/groups/test_groups_routes.py
[error] 11-11: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 42-42: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 52-52: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 73-73: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 95-95: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 106-106: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 129-129: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 142-142: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 167-167: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 180-180: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 196-196: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
[error] 214-214: Pytest error: fixture 'async_client' not found. Tests require 'async_client' fixture which is missing or not imported.
backend/app/groups/service.py
[error] 80-80: TypeError in async iteration: 'async for' requires an object with aiter method, got coroutine. Likely cause: 'db.groups.find' returns coroutine instead of async iterable.
🪛 Ruff (0.11.9)
backend/tests/groups/test_groups_routes.py
1-1: pytest imported but unused
Remove unused import: pytest
(F401)
4-4: unittest.mock.AsyncMock imported but unused
Remove unused import: unittest.mock.AsyncMock
(F401)
5-5: bson.ObjectId imported but unused
Remove unused import: bson.ObjectId
(F401)
backend/app/groups/service.py
1-1: fastapi.status imported but unused
Remove unused import: fastapi.status
(F401)
5-5: typing.Dict imported but unused
Remove unused import
(F401)
5-5: typing.Any imported but unused
Remove unused import
(F401)
backend/app/groups/routes.py
16-16: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
28-28: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
36-36: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
48-48: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
63-63: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
74-74: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
85-85: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
96-96: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
107-107: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
121-121: Do not perform function call Depends in argument defaults; instead, perform the call within the function, or read the default from a module-level singleton variable
(B008)
🔇 Additional comments (11)
backend/main.py (1)
8-8: Clean integration of groups router.The integration follows the established pattern and correctly imports and includes the groups router alongside existing auth and user routers.
Also applies to: 106-106
backend/app/groups/schemas.py (2)
5-8: Well-designed member schema with proper role validation.The
GroupMemberschema correctly models the member structure with appropriate default role and datetime handling.
19-29: Excellent ObjectId handling and configuration.The
GroupResponseschema properly handles MongoDB ObjectId aliasing and includes comprehensive group metadata. Themodel_configsetting enables proper field aliasing.backend/tests/groups/test_groups_routes.py (3)
8-41: Comprehensive test coverage with proper mocking.The test methods are well-structured with appropriate mocking of service layer calls and proper status code assertions.
42-51: Good validation testing for edge cases.The test correctly validates that empty names are rejected with proper HTTP status codes.
1-6: ```shell
#!/bin/bashDisplay the contents of the conftest.py to verify fixture definitions
cat backend/tests/conftest.py
</details> <details> <summary>backend/tests/groups/test_groups_service.py (3)</summary> `218-243`: **Excellent security testing for admin protection.** The test properly verifies that the last admin cannot demote themselves, which is a critical business rule for maintaining group integrity. --- `315-340`: **Good coverage of admin protection scenarios.** The test correctly verifies that the last admin cannot leave the group, ensuring business rule enforcement. --- `1-14`: **Well-structured test setup with proper mocking.** The test class setup and imports are appropriate for comprehensive service testing. </details> <details> <summary>backend/app/groups/README.md (1)</summary> `1-174`: **Comprehensive and well-structured documentation.** The README provides excellent coverage of the Groups Service implementation, including: - Complete endpoint documentation - Security considerations - Integration notes - Testing instructions - Usage examples This documentation will be valuable for developers working with the Groups API. </details> <details> <summary>backend/app/groups/service.py (1)</summary> `75-85`: **Fix async iteration error with MongoDB cursor** The pipeline failure indicates that `db.groups.find()` returns a coroutine that needs to be properly handled. In the Motor async driver, you need to create a cursor object before iterating. ```diff async def get_user_groups(self, user_id: str) -> List[dict]: """Get all groups where user is a member""" db = self.get_db() - cursor = db.groups.find({"members.userId": user_id}) groups = [] - async for group in cursor: + async for group in db.groups.find({"members.userId": user_id}): transformed = self.transform_group_document(group) if transformed: groups.append(transformed) return groupsLikely an incorrect or invalid review comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 76.27% 81.56% +5.29%
==========================================
Files 17 22 +5
Lines 864 1427 +563
==========================================
+ Hits 659 1164 +505
- Misses 205 263 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
backend/app/groups/service.py (1)
147-147: Join code case-insensitivity implementation looks good.The implementation correctly addresses the previous review comment by converting join codes to uppercase before database lookup, improving user experience.
🧹 Nitpick comments (6)
backend/tests/conftest.py (1)
43-43: Fix inline comment formatting.The static analysis tool correctly identified a formatting issue with the inline comment.
- patch("firebase_admin.auth.verify_id_token", mock_firebase_auth.verify_id_token) # Mock specific function + patch("firebase_admin.auth.verify_id_token", mock_firebase_auth.verify_id_token) # Mock specific functionbackend/tests/groups/test_groups_routes.py (2)
6-6: Remove unused import.The
datetimeimport is not used in this test file.-from datetime import datetime, timedelta +from datetime import timedelta
13-13: Add missing blank lines for PEP 8 compliance.Function definitions should be preceded by two blank lines.
TEST_USER_EMAIL = "[email protected]" + @pytest.fixture def auth_headers():return {"Authorization": f"Bearer {token}"} + @pytest.fixture async def async_client():Also applies to: 21-21
backend/app/groups/service.py (3)
1-1: Remove unused imports.Several imports are not used in the service implementation.
-from fastapi import HTTPException, status +from fastapi import HTTPException from app.database import get_database from bson import ObjectId from datetime import datetime, timezone -from typing import Optional, Dict, Any, List +from typing import Optional, List import secrets import stringAlso applies to: 5-5
9-9: Fix PEP 8 formatting issues.Add missing blank lines for proper class and module formatting.
import string + class GroupService:return result.modified_count == 1 + group_service = GroupService()Also applies to: 297-297
275-278: Simplify control flow by removing unnecessary else.The else clause after raise is redundant and reduces readability.
if not group_exists: raise HTTPException(status_code=404, detail="Group not found") - else: - raise HTTPException(status_code=403, detail="Only group admins can remove members") + raise HTTPException(status_code=403, detail="Only group admins can remove members")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
backend/app/groups/service.py(1 hunks)backend/tests/conftest.py(2 hunks)backend/tests/groups/test_groups_routes.py(1 hunks)backend/tests/groups/test_groups_service.py(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
backend/tests/groups/test_groups_routes.py (3)
backend/app/auth/security.py (1)
create_access_token(44-65)backend/tests/groups/test_groups_service.py (1)
test_create_group_success(48-87)backend/tests/conftest.py (1)
mock_db(61-90)
🪛 Flake8 (7.2.0)
backend/tests/conftest.py
[error] 43-43: at least two spaces before inline comment
(E261)
backend/app/groups/service.py
[error] 1-1: 'fastapi.status' imported but unused
(F401)
[error] 5-5: 'typing.Dict' imported but unused
(F401)
[error] 5-5: 'typing.Any' imported but unused
(F401)
[error] 9-9: expected 2 blank lines, found 1
(E302)
[error] 297-297: expected 2 blank lines after class or function definition, found 1
(E305)
backend/tests/groups/test_groups_routes.py
[error] 6-6: 'datetime.datetime' imported but unused
(F401)
[error] 13-13: expected 2 blank lines, found 1
(E302)
[error] 21-21: expected 2 blank lines, found 1
(E302)
🪛 Ruff (0.11.9)
backend/app/groups/service.py
1-1: fastapi.status imported but unused
Remove unused import: fastapi.status
(F401)
5-5: typing.Dict imported but unused
Remove unused import
(F401)
5-5: typing.Any imported but unused
Remove unused import
(F401)
backend/tests/groups/test_groups_routes.py
6-6: datetime.datetime imported but unused
Remove unused import: datetime.datetime
(F401)
🪛 Pylint (3.3.7)
backend/app/groups/service.py
[refactor] 275-278: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
(R1720)
🔇 Additional comments (5)
backend/tests/conftest.py (1)
68-84: Excellent patch management for multiple services.The explicit patch lifecycle management ensures proper cleanup and supports the new groups service integration. The approach of patching all service modules simultaneously provides consistent test isolation.
backend/tests/groups/test_groups_routes.py (1)
27-259: Comprehensive API test coverage with excellent mocking strategy.The test suite provides thorough coverage of all group management endpoints with proper:
- HTTP status code assertions
- Response payload validation
- Service method mocking for isolation
- Error case testing (empty name, not found scenarios)
- Authentication header usage
The tests effectively validate the API layer behavior independently of the service implementation.
backend/tests/groups/test_groups_service.py (2)
108-116: Proper async iterator implementation resolves previous pipeline issue.The async iterator mock correctly yields groups and prevents the pipeline failure mentioned in past reviews. This is a much cleaner approach than the previously suggested fix.
8-367: Excellent comprehensive service layer test coverage.The test suite demonstrates thorough testing of:
- Core CRUD operations with proper async patterns
- Role-based access control validation
- Admin protection mechanisms (preventing last admin removal/demotion)
- Error handling with appropriate HTTP exceptions
- Edge cases and boundary conditions
- Proper MongoDB interaction mocking
The tests effectively validate business logic isolation and ensure service correctness.
backend/app/groups/service.py (1)
41-298: Robust group management service with excellent business logic.The service implementation demonstrates:
- Comprehensive CRUD operations with proper validation
- Strong role-based access control enforcement
- Admin protection mechanisms preventing orphaned groups
- Unique join code generation with collision detection
- Proper error handling with descriptive HTTP exceptions
- Future-ready placeholders for expense service integration
- Consistent async/await patterns throughout
The business logic correctly enforces group management rules and provides a solid foundation for the API layer.
|
@codecov-ai-reviewer test |
|
On it! Codecov is generating unit tests for this PR. |
|
Sentry has determined that unit tests are not necessary for this PR. |
Introduce a comprehensive API for managing groups, including endpoints for creating, retrieving, updating, and deleting groups. Implement functionality for users to join and leave groups, along with robust error handling and role-based access control. Add Pydantic schemas for request and response validation, and ensure thorough testing of all routes and service methods.
Summary by CodeRabbit
New Features
Documentation
Tests