LIMS-1550: Add 'Mark Dispensing' button to plate well view#869
Merged
ndg63276 merged 6 commits intopre-release/2025-R3.3from Jun 24, 2025
Merged
Conversation
Collaborator
|
Hello! Is this still a draft, or is it ready for review? |
Collaborator
Author
|
Still a draft, on hold while we establish where CHIMP-CHOMP results will go in the database. |
Collaborator
Author
gfrn
reviewed
Jun 24, 2025
gfrn
reviewed
Jun 24, 2025
gfrn
approved these changes
Jun 24, 2025
ndg63276
added a commit
that referenced
this pull request
Jul 8, 2025
* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869) * LIMS-167: Dont default to mx type for calendar/logistics views (#942) * LIMS-1716: Multicrystal processing only shows one DC per group (#938) * LIMS-1718: Display cluster info on multiplex jobs (#937) * LIMS-1752: Create view for Ligand Fit pipeline (#943)
ndg63276
added a commit
that referenced
this pull request
Jul 22, 2025
* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869) * LIMS-1550: Add 'Mark Dispensing' button to plate well view * LIMS-1550: Dont throw an error if no subsamples exist * LIMS-1550: Use new BLSamplePosition table * LIMS-1550: Label positions as 'dispensing' * LIMS-1550: Change plus signs to crosses when the button text changes --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-167: Dont default to mx type for calendar/logistics views (#942) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1716: Multicrystal processing only shows one DC per group (#938) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1718: Display cluster info on multiplex jobs (#937) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1752: Create view for Ligand Fit pipeline (#943) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1798: Only show the latest dispensing position --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
ndg63276
added a commit
that referenced
this pull request
Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961) * LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956) * LIMS-1792: Allow container types from multiple villages (#960) * LIMS-1796: Display filepath for attachments (#959) * LIMS-1798: Only show the latest dispensing position (#952) * LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869) * LIMS-167: Dont default to mx type for calendar/logistics views (#942) * LIMS-1716: Multicrystal processing only shows one DC per group (#938) * LIMS-1718: Display cluster info on multiplex jobs (#937) * LIMS-1752: Create view for Ligand Fit pipeline (#943) * LIMS-1833: Fix XPDF DC view (#963) * LIMS-1845: Fix broken VMXi attachment names (#968) * LIMS-1848: Fix bug where no container types are available (#971) * Check type before assigning to proposal object (#975)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1550
Summary:
We need a way to store the dispensing location for each well in a plate. This PR adds buttons to mark that point manually, edit it, and delete it, and will also display the currently selected location. The location is stored in the BLSamplePosition table.
Changes:
To test: