Skip to content

LIMS-1550: Add 'Mark Dispensing' button to plate well view#869

Merged
ndg63276 merged 6 commits intopre-release/2025-R3.3from
improvement/LIMS-1550/add-mark-dispensing-button
Jun 24, 2025
Merged

LIMS-1550: Add 'Mark Dispensing' button to plate well view#869
ndg63276 merged 6 commits intopre-release/2025-R3.3from
improvement/LIMS-1550/add-mark-dispensing-button

Conversation

@ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Nov 29, 2024

JIRA ticket: LIMS-1550

Summary:

We need a way to store the dispensing location for each well in a plate. This PR adds buttons to mark that point manually, edit it, and delete it, and will also display the currently selected location. The location is stored in the BLSamplePosition table.

Changes:

  • Add 2 new buttons, 'Mark Dispensing' and (initially hidden) 'Delete'
  • Manage the logic between the new buttons and the existing 'Mark Point' and 'Mark Region' buttons
  • Insert or update the dispensing position in the database (the delete button updates the x/y/z positions to null)
  • Display the dispensing position as a white circle, to distinguish it from subsamples

To test:

  • Go to proposal nt37104, go to /containers, then click on any plate with subsamples
  • Go to a well with subsamples
  • Check the 'Mark Point', 'Mark Region' and 'Mark Dispensing' buttons turn to 'Finish' or 'Cancel' buttons when clicked, but only one can be active at once
  • Click 'Mark Dispensing' and then click on the well, check a white circle appears to display where you clicked
  • Check the white circle remains in place after a refresh, and after zooming in and out
  • Check the BLSamplePosition table has a new row or has been updated, with non-null values for posX/Y, and a positionType of 'dispensing'
  • Repeat the process, check the position updates on screen and in the database
  • Click 'Mark Dispensing' and then click 'Delete', check the white circle disappears, check the posX/Y values are now null

@gfrn
Copy link
Collaborator

gfrn commented Jan 21, 2025

Hello! Is this still a draft, or is it ready for review?

@ndg63276
Copy link
Collaborator Author

Still a draft, on hold while we establish where CHIMP-CHOMP results will go in the database.

@ndg63276
Copy link
Collaborator Author

ndg63276 commented Apr 1, 2025

@ndevenish

@ndg63276 ndg63276 marked this pull request as ready for review June 23, 2025 15:23
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.3 June 24, 2025 14:19
@ndg63276 ndg63276 merged commit 1343bff into pre-release/2025-R3.3 Jun 24, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1550/add-mark-dispensing-button branch June 24, 2025 14:20
ndg63276 added a commit that referenced this pull request Jul 8, 2025
* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

* LIMS-1718: Display cluster info on multiplex jobs (#937)

* LIMS-1752: Create view for Ligand Fit pipeline (#943)
ndg63276 added a commit that referenced this pull request Jul 22, 2025
* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-1550: Add 'Mark Dispensing' button to plate well view

* LIMS-1550: Dont throw an error if no subsamples exist

* LIMS-1550: Use new BLSamplePosition table

* LIMS-1550: Label positions as 'dispensing'

* LIMS-1550: Change plus signs to crosses when the button text changes

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1718: Display cluster info on multiplex jobs (#937)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1752: Create view for Ligand Fit pipeline (#943)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1798: Only show the latest dispensing position

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
ndg63276 added a commit that referenced this pull request Aug 26, 2025
* LIMS-742: Remove redundant 'pid' check (#961)

* LIMS-1780 / LIMS-1787: Show strategies on characterizations, auto processing on grid scans (#956)

* LIMS-1792: Allow container types from multiple villages (#960)

* LIMS-1796: Display filepath for attachments (#959)

* LIMS-1798: Only show the latest dispensing position (#952)

* LIMS-1550: Add 'Mark Dispensing' button to plate well view (#869)

* LIMS-167: Dont default to mx type for calendar/logistics views (#942)

* LIMS-1716: Multicrystal processing only shows one DC per group (#938)

* LIMS-1718: Display cluster info on multiplex jobs (#937)

* LIMS-1752: Create view for Ligand Fit pipeline (#943)

* LIMS-1833: Fix XPDF DC view (#963)

* LIMS-1845: Fix broken VMXi attachment names (#968)

* LIMS-1848: Fix bug where no container types are available (#971)

* Check type before assigning to proposal object (#975)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants