Skip to content

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1854

Summary:

A user accidentally submitted the same job several times as it was not clear it had been submitted.

Changes:

  • Change the various buttons to say "Submitted" after successful submission, and disable them
  • Revert the buttons after 5s
  • Fix a couple of typos and a bug where a dialog box would stay open even if you click Ok

To test:

  • Use the production database as Zocalo will fail otherwise
  • Go to any suitable data collection with downstream jobs (eg /dc/visit/cm40607-4/id/20164987)
  • Click the cog icon for reprocessing
  • Choose a pipeline (fast_dp is quickest) and some images, and click "Integrate". Check the button becomes disabled, and the text changes to "Submitted!"
  • Check the button changes back after 5s (when the toast also disappears)
  • Check the job runs ok
  • Repeat the test with "Process Individually" ticked
  • View one of the processing results, and then click the "Downstream Processing" button. Choose an eligible job and click "Submit". Check the button changes as above
  • Go to the multicrystal page (eg /mc/visit/cm40607-4), and click Integrate without selecting any data sets. Check the dialog that appears only has an Ok button and it goes away when you click it
  • Select some data from one or more data sets and click Integrate. Check the button changes as above.

@gfrn
Copy link
Collaborator

gfrn commented Oct 28, 2025

When clicking "integrate", the button doesn't grey out immediately, so there's still a small interval in which the user can click twice quickly and trigger two jobs

Don't know if that's much of a problem, though

@ndg63276
Copy link
Collaborator Author

When clicking "integrate", the button doesn't grey out immediately, so there's still a small interval in which the user can click twice quickly and trigger two jobs

Don't know if that's much of a problem, though

Good point, I've moved the disable button call to be the first thing done, so hopefully no one can trigger twice.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R5.2 November 11, 2025 11:39
@ndg63276 ndg63276 changed the base branch from pre-release/2025-R5.2 to master November 11, 2025 11:49
@ndg63276
Copy link
Collaborator Author

Superseded by #1009

@ndg63276 ndg63276 closed this Nov 21, 2025
@ndg63276 ndg63276 deleted the improvement/LIMS-1854/prevent-multiple-reprocessing-jobs branch November 21, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants