Skip to content

Conversation

@gfrn
Copy link
Collaborator

@gfrn gfrn commented Oct 29, 2025

JIRA ticket: LIMS-1964

Summary:

To consolidate all motion correction related data in EM tomography into one component, instead of one displayed pre-alignment and one displayed post alignment, the tomogram motion correction endpoint was moved to dataCollections, meaning a tomogram is no longer required to display motion correction data.

Changes:

  • Move /tomograms/{id}/motion to /dataCollection/{id}/tomogram-motion
  • getMiddle now return central slice of alignment images, instead of all images
  • alignedTotal now refers to the total number of movies with alignment data, and total to the raw total

To test:

  • Send a GET request to /dataCollections/6017406/tomogram-motion, check if 5 items are returned, and 5 aligned items are mentioned in alignedTotal
  • Send a GET request to /dataCollections/6017406/tomogram-motion?getMiddle=true, check if you're returned an item with a refined tilt angle of 16 (central slice)
  • Send a GET request to /dataCollections/6017411/tomogram-motion, check if no aligned movies are counted
  • Send a GET request to /dataCollections/6017408/tomogram-motion?page=1&limit=1, check if a single item is returned

@gfrn gfrn requested review from MattPrit and RichB-DLS October 29, 2025 15:52
@gfrn gfrn self-assigned this Oct 29, 2025
@gfrn gfrn added the enhancement New feature or request label Oct 29, 2025
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.83%. Comparing base (1514bc7) to head (b804d4d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
+ Coverage   94.78%   94.83%   +0.04%     
==========================================
  Files          46       46              
  Lines        1859     1857       -2     
==========================================
- Hits         1762     1761       -1     
+ Misses         97       96       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@MattPrit MattPrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfrn gfrn merged commit 003d8b3 into master Nov 13, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants