Skip to content
This repository was archived by the owner on Jan 28, 2026. It is now read-only.

Feature/pr screenshots#82

Open
amarilda611 wants to merge 41 commits intomainfrom
feature/pr-screenshots
Open

Feature/pr screenshots#82
amarilda611 wants to merge 41 commits intomainfrom
feature/pr-screenshots

Conversation

@amarilda611
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread tests/example.spec.js
@@ -1,16 +1,21 @@
// tests/example.spec.js
const { test, expect } = require('@playwright/test');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
const { test, expect } = require('@playwright/test');
const { test, expect } = require("@playwright/test");

Comment thread tests/example.spec.js
Comment on lines 4 to 6
test.describe('Playwright Basic Workflow Tests', () => {
test('should load example.com and verify title', async ({ page }) => {
await page.goto('https://example.com');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
test.describe('Playwright Basic Workflow Tests', () => {
test('should load example.com and verify title', async ({ page }) => {
await page.goto('https://example.com');
test.describe("Playwright Basic Workflow Tests", () => {
test("should load example.com and verify title", async ({ page }) => {
await page.goto("https://example.com");

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2025

Playwright Test Metrics

Total: 4
Passed: 2
Failed: 0
Skipped: 0

Duration: 4575687 ms
Pass Rate: ** %**

ESLint (GUI tests)


Test-Flow Chart

Note: The flowchart.png is uploaded as an artifact. To embed it directly like screenshots,

you would also need to copy it into the 'published-screenshots' directory in step 9,

and then reference it using the PR-specific GitHub Pages URL.

Artifact: test-flow-chart → flowchart.png

Playwright Screenshots for this PR

example-domain.png\n\nnavigation.png\n\n

Full run details: link

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

Comment thread tests/example.spec.js
await expect(page).toHaveTitle(/Example Domain/);
await page.screenshot({ path: 'playwright-report/example-domain.png' });
// **CHANGE THIS LINE:** Use process.env.PLAYWRIGHT_SCREENSHOT_DIR
await page.screenshot({ path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'published-screenshots'}/example-domain.png` });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
await page.screenshot({ path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'published-screenshots'}/example-domain.png` });
await page.screenshot({
path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || "published-screenshots"}/example-domain.png`,
});

Comment thread tests/example.spec.js
Comment on lines 12 to 14
test('should find and click the More information link', async ({ page }) => {
await page.goto('https://example.com');
await page.click('text=More information');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
test('should find and click the More information link', async ({ page }) => {
await page.goto('https://example.com');
await page.click('text=More information');
test("should find and click the More information link", async ({ page }) => {
await page.goto("https://example.com");
await page.click("text=More information");

Comment thread tests/example.spec.js
await expect(page).toHaveURL(/iana.org/);
await page.screenshot({ path: 'playwright-report/navigation.png' });
// **CHANGE THIS LINE:** Use process.env.PLAYWRIGHT_SCREENSHOT_DIR
await page.screenshot({ path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'published-screenshots'}/navigation.png` });
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
await page.screenshot({ path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'published-screenshots'}/navigation.png` });
await page.screenshot({
path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || "published-screenshots"}/navigation.png`,
});

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

Comment thread playwright.config.js
@@ -1,16 +1,86 @@
const { defineConfig } = require('@playwright/test');
// @ts-check
const { defineConfig, devices } = require('@playwright/test');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
const { defineConfig, devices } = require('@playwright/test');
const { defineConfig, devices } = require("@playwright/test");

Comment thread playwright.config.js
*/
module.exports = defineConfig({
testDir: './tests',
/* Run tests in files in parallel */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
testDir: './tests',
testDir: "./tests",

Comment thread playwright.config.js
workers: process.env.CI ? 1 : undefined,
/* Reporter to use. See https://playwright.dev/docs/test-reporters */
reporter: 'html', // Default reporter, can be overridden by CLI
/* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
reporter: 'html', // Default reporter, can be overridden by CLI
reporter: "html", // Default reporter, can be overridden by CLI

Comment thread playwright.config.js

/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
trace: 'on-first-retry',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
trace: 'on-first-retry',
trace: "on-first-retry",

Comment thread playwright.config.js
Comment on lines +45 to +46
use: { ...devices['Desktop Chrome'] },
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
name: 'chromium',
use: { ...devices['Desktop Chrome'] },
name: "chromium",
use: { ...devices["Desktop Chrome"] },

Comment thread playwright.config.js
Comment on lines +50 to +51
use: { ...devices['Desktop Firefox'] },
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
name: 'firefox',
use: { ...devices['Desktop Firefox'] },
name: "firefox",
use: { ...devices["Desktop Firefox"] },

Comment thread playwright.config.js
Comment on lines +55 to +56
use: { ...devices['Desktop Safari'] },
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
name: 'webkit',
use: { ...devices['Desktop Safari'] },
name: "webkit",
use: { ...devices["Desktop Safari"] },

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

Comment thread playwright.config.js Outdated
Comment on lines +37 to +39
screenshot: 'only-on-failure', // or 'on' if you want screenshots for all steps
video: 'on-first-retry',
output: process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'test-results', // This is the key!
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[prettier] reported by reviewdog 🐶

Suggested change
screenshot: 'only-on-failure', // or 'on' if you want screenshots for all steps
video: 'on-first-retry',
output: process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'test-results', // This is the key!
screenshot: "only-on-failure", // or 'on' if you want screenshots for all steps
video: "on-first-retry",
output: process.env.PLAYWRIGHT_SCREENSHOT_DIR || "test-results", // This is the key!

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hello!

Here's the link to our GitHub Pages site:
[View Blank Page]({{ https://digitalproductinnovationanddevelopment.github.io/Code-Reviews-of-GUI-Tests/ }})

This link will always show the latest version from our main branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant