This repository was archived by the owner on Jan 28, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/pr screenshots #82
Open
amarilda611
wants to merge
41
commits into
main
Choose a base branch
from
feature/pr-screenshots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
d8f74cb
Create published-screenshots
amarilda611 d66f40b
Delete published-screenshots
amarilda611 bb95f3c
Create .gitkeep
amarilda611 cddf92e
Update example.spec.js
amarilda611 98aca7f
Create .gitignore
amarilda611 1d9d9ae
Update playwright.yml
amarilda611 c6cff76
Update playwright.yml
amarilda611 a312f38
Update playwright.yml
amarilda611 61b4578
Update playwright.yml
amarilda611 f25f00d
Docs: Publish Playwright screenshots for PR #82 [skip ci]
github-actions[bot] 223d1df
Update playwright.yml
amarilda611 8f24ec7
Update playwright.yml
amarilda611 f3cde19
Update playwright.yml
amarilda611 5a1684d
Update playwright.yml
amarilda611 3c56246
Update example.spec.js
amarilda611 e9ba776
Update playwright.yml
amarilda611 04f3c49
Update example.spec.js
amarilda611 4cf6f0d
Update playwright.yml
amarilda611 842a81d
Update playwright.yml
amarilda611 56b6c9c
Update playwright.yml
amarilda611 0c52e5e
Update playwright.yml
amarilda611 0a7f235
Update playwright.yml
amarilda611 b38735c
Update playwright.yml
amarilda611 32115ab
Update playwright.yml
amarilda611 b32f909
Update playwright.yml
amarilda611 faa6cf9
Update playwright.yml
amarilda611 1077279
Update playwright.yml
amarilda611 c8e1a10
Update playwright.yml
amarilda611 53c64b3
Update playwright.config.js
amarilda611 8f38e11
Update playwright.yml
amarilda611 8b91826
Update playwright.config.js
amarilda611 4100ed6
Update playwright.yml
amarilda611 6761349
Update playwright.yml
amarilda611 c7eb28b
Update playwright.config.js
amarilda611 e2edaea
Update playwright.config.js
amarilda611 0690cec
Update playwright.yml
amarilda611 9ca36a1
Update playwright.config.js
amarilda611 cd72dc5
Update playwright.yml
amarilda611 1f42352
Update playwright.config.js
amarilda611 eeee5ff
Update playwright.yml
amarilda611 d800730
Update playwright.yml
amarilda611 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Ignore generated screenshots | ||
| published-screenshots/ | ||
|
|
||
| # You might also want to ignore Node.js dependencies | ||
| node_modules/ | ||
|
|
||
| # And Playwright test results/reports | ||
| playwright-report/ |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,16 +1,19 @@ | ||||||||||||||
| // tests/example.spec.js | ||||||||||||||
| const { test, expect } = require('@playwright/test'); | ||||||||||||||
|
|
||||||||||||||
| test.describe('Playwright Basic Workflow Tests', () => { | ||||||||||||||
| test('should load example.com and verify title', async ({ page }) => { | ||||||||||||||
| await page.goto('https://example.com'); | ||||||||||||||
|
Comment on lines
4
to
6
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [prettier] reported by reviewdog 🐶
Suggested change
|
||||||||||||||
| await expect(page).toHaveTitle(/Example Domain/); | ||||||||||||||
| await page.screenshot({ path: 'playwright-report/example-domain.png' }); | ||||||||||||||
| // **CHANGE THIS LINE:** Use process.env.PLAYWRIGHT_SCREENSHOT_DIR | ||||||||||||||
| await page.screenshot({ path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'published-screenshots'}/example-domain.png` }); | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [prettier] reported by reviewdog 🐶
Suggested change
|
||||||||||||||
| }); | ||||||||||||||
|
|
||||||||||||||
| test('should find and click the More information link', async ({ page }) => { | ||||||||||||||
| await page.goto('https://example.com'); | ||||||||||||||
| await page.click('text=More information'); | ||||||||||||||
|
Comment on lines
12
to
14
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [prettier] reported by reviewdog 🐶
Suggested change
|
||||||||||||||
| await expect(page).toHaveURL(/iana.org/); | ||||||||||||||
| await page.screenshot({ path: 'playwright-report/navigation.png' }); | ||||||||||||||
| // **CHANGE THIS LINE:** Use process.env.PLAYWRIGHT_SCREENSHOT_DIR | ||||||||||||||
| await page.screenshot({ path: `${process.env.PLAYWRIGHT_SCREENSHOT_DIR || 'published-screenshots'}/navigation.png` }); | ||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [prettier] reported by reviewdog 🐶
Suggested change
|
||||||||||||||
| }); | ||||||||||||||
| }); | ||||||||||||||
| }); | ||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[prettier] reported by reviewdog 🐶