Conversation
rrgeorge
pushed a commit
to rrgeorge/IceCubesApp
that referenced
this pull request
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Sectionwith aButtonlabeledLabel("account.list.create", systemImage: "plus")insideListAddAccountViewso the create action appears in the list content.@State private var isPresentingCreateListand presentListCreateView()with.sheet(isPresented:)to show the create flow locally on top of the current sheet.RouterPathcreate action and the toolbar create button while keeping the Done action in the toolbar.Packages/Lists/Sources/Lists/AddAccounts/ListAddAccountView.swiftto implement the above UX and presentation changes.Testing
xcodebuild -scheme IceCubesApp -project IceCubesApp.xcodeproj -destination 'platform=iOS Simulator,name=iPhone 15' build, butxcodebuildis not available in the environment so the build could not be executed.ListAddAccountViewUI code confirms the create button is now in-list andListCreateViewis presented locally via.sheet.xcodebuildor in Xcode to confirm compile and runtime behavior.Codex Task