Merged
Conversation
1. Multi-Language Text Search System - Added AdaptiveKeyboard system supporting universal language matching - Implemented 4-tier hybrid matching strategy with priority ordering - Added support for non-Latin scripts (Cyrillic, Arabic, CJK, Indic, Greek) - Added typo tolerance with keyboard-aware substitution costs - Enabled mixed-script matching capabilities Matching strategy priority: 1. Learned patterns (user corrections, highest priority) 2. Physical key distance (layout-independent proximity) 3. Unicode similarity (codepoint-based matching) 4. Phonetic groups (cross-script phonetic similarity) 2. Display vs Value Fix - Fixed select button to show proper capitalized display text - Enhanced separation between machine-readable values and human-readable display - Added proper display text preservation between selections - Implemented clean fallback to formatted value when display not provided Before: Selects "Apple" → Button shows "apple" After: Selects "Apple" → Button shows "Apple"
npatsakula
commented
Jul 25, 2025
ealmloff
reviewed
Jul 25, 2025
npatsakula
commented
Jul 27, 2025
|
Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-96/ |
Contributor
Author
|
@ealmloff, looks like it's ready 🤔 Meme
|
Member
|
When messing with the preview, I noticed regressions in two places that weren't tested in the playwright tests:
I pushed some new tests that demonstrate the issues |
npatsakula
commented
Jul 29, 2025
Contributor
Author
npatsakula
left a comment
npatsakula
left a comment
There was a problem hiding this comment.
@ealmloff, I fixed the bugs that you mentioned before.
ealmloff
approved these changes
Jul 31, 2025
Member
ealmloff
left a comment
ealmloff
left a comment
There was a problem hiding this comment.
Thanks for working on this! I pushed some changes to unify the old and new fuzzy searching system so we can support both alternate keyboard layouts and non-ascii inputs. I also swapped out the context for a boxed variant so we only need explicit types in the select and option components
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#95
Plan
text_valueproperty.#[cfg!()]macro.Post testing
Disclaimers
Tests
I ran and maintained the tests that were in the repository. I also ran my own tests for my environment to make sure it worked.
Code structure
The component file was too big to work with adequately, so I split it into several. I also moved the tests under the сап macro, so as not to compile them in a production environment.
Language
English is not my native language, so sometimes my speech may seem edgy, even if I did not intend it that way. If you have such a feeling, I ask you to indicate this clearly, I will correct the message ASAP.