Skip to content

ENG-1266: Bug: Component not loading on any page #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdroidian merged 3 commits into from
Jan 12, 2026
+6 −8
Merged

ENG-1266: Bug: Component not loading on any page #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
253c9ed
findDiscourseNode accepts title as well
sid597 Jan 10, 2026
76f23d1
Refactor findDiscourseNode to ensure uid is always a string and updat…
mdroidian Jan 12, 2026
26deb26
.
mdroidian Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/roam/src/components/canvas/Tldraw.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ const TldrawCanvas = ({ title }: { title: string }) => {
? { x: lastTime.x + w * 0.025, y: lastTime.y + h * 0.05 }
: { x: x - DEFAULT_WIDTH / 2, y: y - DEFAULT_HEIGHT / 2 };
const nodeType = findDiscourseNode({
uid: e.detail.uid,
uid: e.detail.uid || "",
nodes: allNodes,
});
if (nodeType) {
Expand Down
5 changes: 2 additions & 3 deletions apps/roam/src/utils/findDiscourseNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,18 @@ const findDiscourseNode = ({
title,
nodes = getDiscourseNodes(),
}: {
uid?: string;
uid: string;
title?: string;
nodes?: DiscourseNode[];
}): DiscourseNode | false => {
if (uid === undefined) return false;
if (typeof discourseNodeTypeCache[uid] !== "undefined") {
return discourseNodeTypeCache[uid];
}

const matchingNode =
nodes.find((node) =>
title === undefined
? matchDiscourseNode({ ...node, uid: uid })
? matchDiscourseNode({ ...node, uid })
: matchDiscourseNode({ ...node, title }),
) || false;
discourseNodeTypeCache[uid] = matchingNode;
Expand Down
2 changes: 1 addition & 1 deletion apps/roam/src/utils/formatUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export const getReferencedNodeInFormat = ({
}) => {
let format = providedFormat;
if (!format) {
const discourseNode = findDiscourseNode({ uid });
const discourseNode = findDiscourseNode({ uid: uid || "" });
if (discourseNode) format = discourseNode.format;
}
if (!format) return null;
Expand Down
5 changes: 2 additions & 3 deletions apps/roam/src/utils/initializeObserversAndListeners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,10 @@ export const initObservers = async ({
text: "(BETA) Suggestive Mode Enabled",
}).value;

const nodes = getDiscourseNodes();
const node = findDiscourseNode({ title, nodes });
const uid = getPageUidByPageTitle(title);
Copy link
Contributor

@mdroidian mdroidian Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing UID lets us use the findDiscourseNode cache, at the tradeoff of running a pull on every page. Queries on every page are not ideal, but this pull is pretty insignificant.

const node = findDiscourseNode({ uid, title });
const isDiscourseNode = node && node.backedBy !== "default";
if (isDiscourseNode) {
const uid = getPageUidByPageTitle(title);
if (isSuggestiveModeEnabled) {
renderPossibleDuplicates(h1, title, node);
}
Expand Down