feat(emoji)!: implement app emojis#1224
feat(emoji)!: implement app emojis#1224onerandomusername merged 34 commits intoDisnakeDev:masterfrom
Conversation
|
I marked this ready for review even though i still don't know if we should provide the ability to cache app emojis at startup, as you can see i did put a boolean argument but didn't implement any logic for it so far. |
Victorsitou
left a comment
There was a problem hiding this comment.
In the documentation, referring the emojis as "application emojis" instead of "app emojis" would be more consistent
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: Victor <67214928+Victorsitou@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Enegg
left a comment
There was a problem hiding this comment.
Since .guild/.guild_id is changed to possibly return None, this is a breaking change. (Rename PR title to feat!(emoji): ...?)
Personally I'd rather see a separate class for app emojis.
Enegg
left a comment
There was a problem hiding this comment.
I'm strongly in favor of splitting the models into a GuildEmoji and AppEmoji. The current approach is pretty much saying "an Emoji can have both .guild_id and .application_id, one of, or neither!"
Anyhow, minor nitpicks below.
If we want to split them into different classes (I had this talk with @shiftinv in the past, but at the time they said it was fine to go with this approach) we would most likely split them into |
Co-authored-by: Eneg <42005170+Enegg@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
Co-authored-by: Eneg <42005170+Enegg@users.noreply.github.com> Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@shiftinv did your opinion change on this? |
Summary
Checklist
pdm lintpdm pyright