Skip to content

docs(emoji): misc documentation fixes for app emojis#1388

Merged
onerandomusername merged 12 commits intomasterfrom
misc/app-emojis
Sep 23, 2025
Merged

docs(emoji): misc documentation fixes for app emojis#1388
onerandomusername merged 12 commits intomasterfrom
misc/app-emojis

Conversation

@shiftinv
Copy link
Member

@shiftinv shiftinv commented Sep 17, 2025

Summary

Followup to #1224. This is a mix of different documentation clarifications.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm run nox -s lint
    • I have type-checked the code by running pdm run nox -s pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added this to the disnake v2.12 milestone Sep 17, 2025
@shiftinv shiftinv added the t: documentation Improvements or additions to documentation/examples label Sep 17, 2025
@shiftinv shiftinv added this to disnake Sep 17, 2025
@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: refactor/typing/lint Refactors, typing changes and/or linting changes labels Sep 17, 2025
@github-project-automation github-project-automation bot moved this to Todo in disnake Sep 17, 2025
@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 17, 2025

Documentation build overview

📚 disnake | 🛠️ Build #29696468 | 📁 Comparing 40affc3 against latest (0306a61)


🔍 Preview build

Show files changed (48 files in total): 📝 48 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

@onerandomusername onerandomusername changed the title fix(emoji): misc documentation and parameter fixes for app emojis fix(emoji)!: misc documentation and parameter fixes for app emojis Sep 17, 2025
Copy link
Member

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_app_emoji and is_guild_emoji are now methods instead of properties

The title of this pull should reflect that. However, this seems to be two seperate issues in one pull. Please consider splitting this into two pull requests. Thank you.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in disnake Sep 21, 2025
shiftinv and others added 3 commits September 22, 2025 14:41
Co-authored-by: arielle <me@arielle.codes>
Signed-off-by: vi <8530778+shiftinv@users.noreply.github.com>
Co-authored-by: arielle <me@arielle.codes>
@shiftinv shiftinv changed the title fix(emoji)!: misc documentation and parameter fixes for app emojis docs(emoji): misc documentation fixes for app emojis Sep 22, 2025
@shiftinv shiftinv removed the t: refactor/typing/lint Refactors, typing changes and/or linting changes label Sep 22, 2025
@shiftinv
Copy link
Member Author

The title of this pull should reflect that. However, this seems to be two seperate issues in one pull. Please consider splitting this into two pull requests. Thank you.

Sure. #1397

Signed-off-by: arielle <me@arielle.codes>
@github-project-automation github-project-automation bot moved this from In Progress to Needs Merge in disnake Sep 23, 2025
@onerandomusername onerandomusername enabled auto-merge (squash) September 23, 2025 17:59
@onerandomusername onerandomusername enabled auto-merge (squash) September 23, 2025 18:00
@onerandomusername onerandomusername merged commit 731eda1 into master Sep 23, 2025
37 checks passed
@onerandomusername onerandomusername deleted the misc/app-emojis branch September 23, 2025 18:02
@github-project-automation github-project-automation bot moved this from Needs Merge to Done in disnake Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

s: needs review Issue/PR is awaiting reviews t: documentation Improvements or additions to documentation/examples

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants