docs(emoji): misc documentation fixes for app emojis#1388
Merged
onerandomusername merged 12 commits intomasterfrom Sep 23, 2025
Merged
docs(emoji): misc documentation fixes for app emojis#1388onerandomusername merged 12 commits intomasterfrom
onerandomusername merged 12 commits intomasterfrom
Conversation
onerandomusername
requested changes
Sep 21, 2025
Member
onerandomusername
left a comment
There was a problem hiding this comment.
is_app_emoji and is_guild_emoji are now methods instead of properties
The title of this pull should reflect that. However, this seems to be two seperate issues in one pull. Please consider splitting this into two pull requests. Thank you.
Co-authored-by: arielle <me@arielle.codes> Signed-off-by: vi <8530778+shiftinv@users.noreply.github.com>
Co-authored-by: arielle <me@arielle.codes>
8 tasks
Member
Author
Sure. #1397 |
Signed-off-by: arielle <me@arielle.codes>
onerandomusername
approved these changes
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Followup to #1224. This is a mix of different documentation clarifications.
Checklist
pdm run nox -s lintpdm run nox -s pyright