fix(emoji): turn Emoji.is_* properties into methods#1397
Merged
onerandomusername merged 3 commits intomasterfrom Sep 25, 2025
Merged
fix(emoji): turn Emoji.is_* properties into methods#1397onerandomusername merged 3 commits intomasterfrom
Emoji.is_* properties into methods#1397onerandomusername merged 3 commits intomasterfrom
Conversation
8 tasks
This reverts commit c66d0fe.
391e5f2 to
8d9d7b6
Compare
shiftinv
commented
Sep 23, 2025
onerandomusername
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime changes split from #1388. These changes are for consistency with other existing code:
is_app_emojiandis_guild_emojiare now methods instead of propertiesHTTPClientmethods are now kwarg-onlyChecklist
uv run nox -s lintuv run nox -s pyright