-
Notifications
You must be signed in to change notification settings - Fork 144
feat(components): add FileUpload
component
#1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For obvious reason, untested.
|
||
class _BaseComponent(TypedDict): | ||
# type: ComponentType # FIXME: current version of pyright only supports PEP 705 experimentally, this can be re-enabled in 1.1.353+ | ||
type: ReadOnly[ComponentType] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of scope. Please submit a separate change request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't worth a separate PR, as it doesn't really fix anything. I can just remove it from this one, if you'd like.
Co-authored-by: arielle <[email protected]> Signed-off-by: vi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codewise I cannot test, but this looks good, i believe.
Summary
Note
This is in private testing at the moment, and will be made available to everyone in the near future.
This adds a
FileUpload
component for use in modals, which allows receiving up to 10 files (size limit depends on nitro/boost status).Example
Checklist
pdm run nox -s lint
pdm run nox -s pyright