Change: Set a max height for the dropdown menus in the search screen#593
Change: Set a max height for the dropdown menus in the search screen#593HTossy wants to merge 2 commits intoDroidKaigi:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements max height and width constraints for dropdown menus in the search screen to prevent them from growing too large and improving the user interface. The changes ensure better visual appearance and usability when there are many filter options.
- Added height constraint to the dropdown menu itself
- Added width constraint and text overflow handling to the filter button text
- Imported necessary layout and text styling components
| ) | ||
| } | ||
| Text( | ||
| modifier = Modifier.widthIn(max = 150.dp), |
There was a problem hiding this comment.
The hardcoded width value of 150.dp should be extracted to a constant or design system value for consistency and maintainability across the app.
| ) | ||
|
|
||
| DropdownMenu( | ||
| modifier = Modifier.heightIn(max = 300.dp), |
There was a problem hiding this comment.
The hardcoded height value of 300.dp should be extracted to a constant or design system value for consistency and maintainability across the app.
kilalabu
left a comment
There was a problem hiding this comment.
Thanks for the suggestion! I've reviewed the changes.
Regarding the height limit on the dropdown menu, I'm concerned that simply limiting the height might make it difficult for users to realize that the menu is scrollable (that is, that there are more options). While making the scrollbar visible might solve this, I'm not confident that this is the optimal solution.
Similarly, with TextOverflow.Ellipsis, it's difficult to say with certainty that not being able to see the full category name until you select it is the best user experience.
Because of these points, I would like to take this back to the designers for discussion. As a result, we might decide to close this pull request. Also, since this will likely take a few days, I may not be able to get back to you with an answer before DroidKaigi.
I apologize for the delay, but I'll set this PR to a “awaiting design check" status.



Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
screen_movie.mov