Skip to content

Change: Set a max height for the dropdown menus in the search screen#593

Open
HTossy wants to merge 2 commits intoDroidKaigi:mainfrom
HTossy:feature/set_dropdown_menu_max_height
Open

Change: Set a max height for the dropdown menus in the search screen#593
HTossy wants to merge 2 commits intoDroidKaigi:mainfrom
HTossy:feature/set_dropdown_menu_max_height

Conversation

@HTossy
Copy link
Contributor

@HTossy HTossy commented Sep 7, 2025

Issue

Overview (Required)

  • Set a max height and width for the dropdown menus in the search screen.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

screen_movie.mov

@HTossy HTossy marked this pull request as ready for review September 7, 2025 13:24
Copilot AI review requested due to automatic review settings September 7, 2025 13:24
@HTossy HTossy requested a review from a team as a code owner September 7, 2025 13:24
@HTossy HTossy requested review from kilalabu and removed request for a team September 7, 2025 13:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements max height and width constraints for dropdown menus in the search screen to prevent them from growing too large and improving the user interface. The changes ensure better visual appearance and usability when there are many filter options.

  • Added height constraint to the dropdown menu itself
  • Added width constraint and text overflow handling to the filter button text
  • Imported necessary layout and text styling components

)
}
Text(
modifier = Modifier.widthIn(max = 150.dp),
Copy link

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded width value of 150.dp should be extracted to a constant or design system value for consistency and maintainability across the app.

Copilot uses AI. Check for mistakes.
)

DropdownMenu(
modifier = Modifier.heightIn(max = 300.dp),
Copy link

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded height value of 300.dp should be extracted to a constant or design system value for consistency and maintainability across the app.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@kilalabu kilalabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've reviewed the changes.

Regarding the height limit on the dropdown menu, I'm concerned that simply limiting the height might make it difficult for users to realize that the menu is scrollable (that is, that there are more options). While making the scrollbar visible might solve this, I'm not confident that this is the optimal solution.

Similarly, with TextOverflow.Ellipsis, it's difficult to say with certainty that not being able to see the full category name until you select it is the best user experience.

Because of these points, I would like to take this back to the designers for discussion. As a result, we might decide to close this pull request. Also, since this will likely take a few days, I may not be able to get back to you with an answer before DroidKaigi.

I apologize for the delay, but I'll set this PR to a “awaiting design check" status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Truncate filter display when multiple categories are selected in search screen

3 participants