Skip to content

Change: Set a max height for the dropdown menus in the search screen #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HTossy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change: Set a max height for the dropdown menus in the search screen #593

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1acb955
Set a max height for the dropdown menus in the search screen.
HTossy Sep 7, 2025
cca8fb7
Set a max width for the dropdown menus in the search screen.
HTossy Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...c/commonMain/kotlin/io/github/droidkaigi/confsched/sessions/components/SearchFilterRow.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import androidx.compose.foundation.horizontalScroll
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.heightIn
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.widthIn
import androidx.compose.foundation.rememberScrollState
import androidx.compose.material.icons.Icons
import androidx.compose.material.icons.filled.ArrowDropDown
Expand All @@ -27,6 +29,7 @@ import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalSoftwareKeyboardController
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import io.github.droidkaigi.confsched.sessions.SearchScreenEvent
import io.github.droidkaigi.confsched.sessions.SearchScreenUiState
Expand Down Expand Up @@ -154,13 +157,15 @@ private fun <T> FilterDropdown(
)
}
Text(
modifier = Modifier.widthIn(max = 150.dp),
Copy link

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded width value of 150.dp should be extracted to a constant or design system value for consistency and maintainability across the app.

Copilot uses AI. Check for mistakes.
text = if (selectedItems.isNotEmpty()) {
selectedItems.joinToString { itemLabel(it) }
} else {
label
},
style = MaterialTheme.typography.labelLarge,
maxLines = 1,
overflow = TextOverflow.Ellipsis,
)
Icon(
imageVector = Icons.Default.ArrowDropDown,
Expand All @@ -175,6 +180,7 @@ private fun <T> FilterDropdown(
)

DropdownMenu(
modifier = Modifier.heightIn(max = 300.dp),
Copy link

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded height value of 300.dp should be extracted to a constant or design system value for consistency and maintainability across the app.

Copilot uses AI. Check for mistakes.
expanded = expanded,
onDismissRequest = { expanded = false },
) {
Expand Down
Loading