[DYN-8595] Curve Mapper : enable unevenly distributed values to be mapped #16030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per-Enable-unevenly-distributed-values-to-be-mapped
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8595
reddyashish
reviewed
Apr 1, 2025
Collaborator
|
Conflicts here. |
…per-Enable-unevenly-distributed-values-to-be-mapped
reddyashish
reviewed
Apr 2, 2025
| private readonly AssociativeNode pointsCountDefaultValue = | ||
| AstFactory.BuildExprList(new List<AssociativeNode> | ||
| { | ||
| AstFactory.BuildDoubleNode(pointCountDefaultValue) |
Collaborator
There was a problem hiding this comment.
The pointsCount will always be int right? why use the double node?
Collaborator
There was a problem hiding this comment.
oh, is it to support a list of doubles too.
Collaborator
|
@avidit This smoke test SaveGraphAs.SaveGraphAs is failing here and i don't see any relevant changes. Is that test flaky or something we need to investigate? |
9 tasks
Collaborator
|
Closing this as these changes are in #16078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR aims to addressDYN-8595.
Curve Mapper now supports a list of doubles to unevenly distribute points along the selected curve.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Curve Mapper now supports a list of doubles to unevenly distribute points along the selected curve.
Reviewers
@QilongTang
@reddyashish
@zeusongit
FYIs
@achintyabhat
@dnenov