-
Notifications
You must be signed in to change notification settings - Fork 665
[DYN-8596] Do not allow list for x & y min/max input #16078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DYN-8596] Do not allow list for x & y min/max input #16078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8596
|
So this #16030 is not needed? Those changes are in here? |
Correct. |
reddyashish
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with couple of comments.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin RC3.5.0_master
git worktree add -d .worktree/cherrypick-16078 origin/RC3.5.0_master
cd .worktree/cherrypick-16078
git switch --create cherrypick-16078
git cherry-pick -x c2f4070e070589d135d523f2acdaa9f2a45ab7a2 |
|
/cherrypick |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin RC3.5.0_master
git worktree add -d .worktree/cherrypick-16078 origin/RC3.5.0_master
cd .worktree/cherrypick-16078
git switch --create cherrypick-16078
git cherry-pick -x c2f4070e070589d135d523f2acdaa9f2a45ab7a2 |
|
Will cherrypick this manually. |
|
Also @ivaylo-matov I think you missed the resources change here #16030 to get into this PR. |
Co-authored-by: Ashish Aggarwal <[email protected]> (cherry picked from commit c2f4070)
…6078) (#16090) Co-authored-by: Ivo Petrov <[email protected]>
|
apologies for the oversight, @reddyashish |
Purpose
This PR aims to address DYN-8596.
Curve Mapper now blocks list inputs on X and Y domain ports: minX, maxX, minY, maxY. If the user passes a list to any those input ports the node displays an "Expects argument types: double" warning instead of the generic runtime error. The output for both X and Y values in that case is null.
It's also prevents input replication, which previously caused CalculateValues to execute multiple times unintentionally.
Dynamo normally replicates function calls when a list is passed into a node. This breaks Curve Mapper’s logic.
To prevent this:
🙌 All credit to @aparajit-pratap
P.S.: I had to included the changes that enable support for List to allow uneven distribution of points, to ensure that the node remains fully functional. All feedback from 16030 at the time of publishing has been incorporated into this version.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Curve Mapper now blocks list inputs on X and Y domain ports: minX, maxX, minY, maxY.
Reviewers
@reddyashish
@zeusongit
FYIs
@achintyabhat
@dnenov