Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Apr 3, 2025

Purpose

Attempt to address this thread:
https://jira.autodesk.com/browse/DYN-8630

The change here is that we are now getting the compatibility_matrix from the cached search results' header/version. There are a couple of implications.

  • first of all, the rest of the information that we populate comes from the local pkg.json
  • this means that if the local package has changed, and most importantly, the version was incremented for whatever reason, we won't find a matching version on the server, leading to a null result for the compatibility_matrix
  • a general mismatch of the local information inside the pkg.json and the server version

This will need a proper attention and review going forward. Splitting the 'Installed Packages' from 'My Packages' further should be the goal.

Works with this PR https://git.autodesk.com/Dynamo/PackagePublishWizard/pull/47.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • now takes the compatibiltiy_matrix information from the cached search result for the provided version
  • risk of not finding a version if the local package has changed

Reviewers

@zeusongit
@reddyashish

FYIs

@achintyabhat

- now takes the compatibiltiy_matrix information from the cached search result for the provided version
- risk of not finding a version if the local package has changed
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8630

@zeusongit zeusongit added this to the 3.5 milestone Apr 3, 2025
@zeusongit zeusongit merged commit a64b23b into DynamoDS:master Apr 3, 2025
36 of 37 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 3, 2025
@github-actions
Copy link

github-actions bot commented Apr 3, 2025

Successfully created backport PR for RC3.5.0_master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants